From: tip-bot for Thomas Richter <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, tmricht@linux.ibm.com,
jolsa@redhat.com, hpa@zytor.com, acme@redhat.com,
heiko.carstens@de.ibm.com, schwidefsky@de.ibm.com,
tglx@linutronix.de, brueckner@linux.ibm.com, mingo@kernel.org
Subject: [tip:perf/urgent] perf alias: Remove trailing newline when reading sysfs files
Date: Mon, 25 Jun 2018 23:57:50 -0700 [thread overview]
Message-ID: <tip-ea23ac73085743a4f1682d6605fe019577c82e1e@git.kernel.org> (raw)
In-Reply-To: <20180615101105.47047-1-tmricht@linux.ibm.com>
Commit-ID: ea23ac73085743a4f1682d6605fe019577c82e1e
Gitweb: https://git.kernel.org/tip/ea23ac73085743a4f1682d6605fe019577c82e1e
Author: Thomas Richter <tmricht@linux.ibm.com>
AuthorDate: Fri, 15 Jun 2018 12:11:03 +0200
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 25 Jun 2018 11:59:37 -0300
perf alias: Remove trailing newline when reading sysfs files
Remove a trailing newline when reading sysfs file contents such as
/sys/devices/cpum_cf/events/TX_NC_TEND. This shows when verbose option
-v is used.
Output before:
tx_nc_tend -> 'cpum_cf'/'event=0x008d
'/
Output after:
tx_nc_tend -> 'cpum_cf'/'event=0x8d'/
Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
Reviewed-by: Hendrik Brueckner <brueckner@linux.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Link: http://lkml.kernel.org/r/20180615101105.47047-1-tmricht@linux.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/pmu.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
index d2fb597c9a8c..2738fc8d200d 100644
--- a/tools/perf/util/pmu.c
+++ b/tools/perf/util/pmu.c
@@ -303,6 +303,9 @@ static int perf_pmu__new_alias(struct list_head *list, char *dir, char *name, FI
buf[ret] = 0;
+ /* Remove trailing newline from sysfs file */
+ rtrim(buf);
+
return __perf_pmu__new_alias(list, dir, name, NULL, buf, NULL, NULL, NULL,
NULL, NULL, NULL);
}
prev parent reply other threads:[~2018-06-26 6:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 10:11 [PATCH 1/3 v2] perf alias: Remove trailing newline when reading sysfs files Thomas Richter
2018-06-15 10:11 ` [PATCH 2/3 v2] perf alias: Rebuild alias expression string to make it comparable Thomas Richter
2018-06-19 15:16 ` Arnaldo Carvalho de Melo
2018-06-26 6:58 ` [tip:perf/urgent] " tip-bot for Thomas Richter
2018-06-15 10:11 ` [PATCH 3/3 v2] perf stat: Remove duplicate event counting Thomas Richter
2018-06-26 6:58 ` [tip:perf/urgent] " tip-bot for Thomas Richter
2018-06-19 15:13 ` [PATCH 1/3 v2] perf alias: Remove trailing newline when reading sysfs files Arnaldo Carvalho de Melo
2018-06-26 6:57 ` tip-bot for Thomas Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-ea23ac73085743a4f1682d6605fe019577c82e1e@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=brueckner@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox