From: tip-bot for Byungchul Park <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: byungchul.park@lge.com, hpa@zytor.com, tglx@linutronix.de,
linux-kernel@vger.kernel.org, peterz@infradead.org,
torvalds@linux-foundation.org, mingo@kernel.org
Subject: [tip:locking/core] locking/lockdep: Rename CONFIG_LOCKDEP_COMPLETE to CONFIG_LOCKDEP_COMPLETIONS
Date: Thu, 17 Aug 2017 03:22:24 -0700 [thread overview]
Message-ID: <tip-ea3f2c0fdfbb180f142cdbc0d1f055c7b9a5e63e@git.kernel.org> (raw)
In-Reply-To: <1502960261-16206-3-git-send-email-byungchul.park@lge.com>
Commit-ID: ea3f2c0fdfbb180f142cdbc0d1f055c7b9a5e63e
Gitweb: http://git.kernel.org/tip/ea3f2c0fdfbb180f142cdbc0d1f055c7b9a5e63e
Author: Byungchul Park <byungchul.park@lge.com>
AuthorDate: Thu, 17 Aug 2017 17:57:41 +0900
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 17 Aug 2017 11:38:55 +0200
locking/lockdep: Rename CONFIG_LOCKDEP_COMPLETE to CONFIG_LOCKDEP_COMPLETIONS
'complete' is an adjective and LOCKDEP_COMPLETE sounds like 'lockdep is complete',
so pick a better name that uses a noun.
Signed-off-by: Byungchul Park <byungchul.park@lge.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: kernel-team@lge.com
Link: http://lkml.kernel.org/r/1502960261-16206-3-git-send-email-byungchul.park@lge.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
include/linux/completion.h | 8 ++++----
lib/Kconfig.debug | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/linux/completion.h b/include/linux/completion.h
index 9bcebf5..791f053 100644
--- a/include/linux/completion.h
+++ b/include/linux/completion.h
@@ -9,7 +9,7 @@
*/
#include <linux/wait.h>
-#ifdef CONFIG_LOCKDEP_COMPLETE
+#ifdef CONFIG_LOCKDEP_COMPLETIONS
#include <linux/lockdep.h>
#endif
@@ -28,12 +28,12 @@
struct completion {
unsigned int done;
wait_queue_head_t wait;
-#ifdef CONFIG_LOCKDEP_COMPLETE
+#ifdef CONFIG_LOCKDEP_COMPLETIONS
struct lockdep_map_cross map;
#endif
};
-#ifdef CONFIG_LOCKDEP_COMPLETE
+#ifdef CONFIG_LOCKDEP_COMPLETIONS
static inline void complete_acquire(struct completion *x)
{
lock_acquire_exclusive((struct lockdep_map *)&x->map, 0, 0, NULL, _RET_IP_);
@@ -64,7 +64,7 @@ static inline void complete_release(struct completion *x) {}
static inline void complete_release_commit(struct completion *x) {}
#endif
-#ifdef CONFIG_LOCKDEP_COMPLETE
+#ifdef CONFIG_LOCKDEP_COMPLETIONS
#define COMPLETION_INITIALIZER(work) \
{ 0, __WAIT_QUEUE_HEAD_INITIALIZER((work).wait), \
STATIC_CROSS_LOCKDEP_MAP_INIT("(complete)" #work, &(work)) }
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 8fb8a20..a0e60d5 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -1082,7 +1082,7 @@ config PROVE_LOCKING
select DEBUG_RT_MUTEXES if RT_MUTEXES
select DEBUG_LOCK_ALLOC
select LOCKDEP_CROSSRELEASE
- select LOCKDEP_COMPLETE
+ select LOCKDEP_COMPLETIONS
select TRACE_IRQFLAGS
default n
help
@@ -1162,7 +1162,7 @@ config LOCKDEP_CROSSRELEASE
such as page locks or completions can use the lock correctness
detector, lockdep.
-config LOCKDEP_COMPLETE
+config LOCKDEP_COMPLETIONS
bool "Lock debugging: allow completions to use deadlock detector"
help
A deadlock caused by wait_for_completion() and complete() can be
next prev parent reply other threads:[~2017-08-17 10:26 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 8:57 [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all part of PROVE_LOCKING Byungchul Park
2017-08-17 8:57 ` [PATCH v3 2/3] lockdep: Reword title of LOCKDEP_CROSSRELEASE config Byungchul Park
2017-08-17 10:21 ` [tip:locking/core] locking/lockdep: " tip-bot for Byungchul Park
2017-08-17 8:57 ` [PATCH v3 3/3] lockdep: Rename LOCKDEP_COMPLETE config Byungchul Park
2017-08-17 10:22 ` tip-bot for Byungchul Park [this message]
2017-08-17 10:21 ` [tip:locking/core] locking/lockdep: Make CONFIG_LOCKDEP_CROSSRELEASE part of CONFIG_PROVE_LOCKING tip-bot for Byungchul Park
2017-08-17 10:45 ` Ingo Molnar
2017-08-18 5:33 ` Byungchul Park
2017-08-21 15:46 ` [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all part of PROVE_LOCKING Peter Zijlstra
2017-08-22 5:14 ` Byungchul Park
2017-08-22 7:52 ` Peter Zijlstra
2017-08-22 8:51 ` Byungchul Park
2017-08-22 9:21 ` Peter Zijlstra
2017-08-22 9:33 ` Byungchul Park
2017-08-22 10:08 ` Peter Zijlstra
2017-08-22 13:49 ` Peter Zijlstra
2017-08-22 14:46 ` Peter Zijlstra
2017-08-22 15:10 ` Peter Zijlstra
2017-08-22 15:59 ` Oleg Nesterov
2017-08-22 16:35 ` Peter Zijlstra
2017-08-23 16:39 ` Oleg Nesterov
2017-08-23 17:47 ` Peter Zijlstra
2017-08-24 6:11 ` Byungchul Park
2017-08-24 7:37 ` Byungchul Park
2017-08-24 8:11 ` Byungchul Park
2017-08-25 1:14 ` Byungchul Park
2017-08-29 15:52 ` Oleg Nesterov
2017-08-29 17:07 ` lockdep && recursive-read Oleg Nesterov
2017-08-29 17:30 ` Peter Zijlstra
2017-08-29 17:51 ` [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all part of PROVE_LOCKING Peter Zijlstra
2017-08-23 2:43 ` Byungchul Park
2017-08-23 6:31 ` Byungchul Park
2017-08-23 10:26 ` Peter Zijlstra
2017-08-24 5:07 ` Byungchul Park
2017-08-22 5:46 ` Dave Chinner
2017-08-22 9:06 ` Peter Zijlstra
2017-08-22 9:22 ` Byungchul Park
2017-08-22 9:37 ` Peter Zijlstra
2017-08-22 9:42 ` Peter Zijlstra
2017-08-23 2:12 ` Byungchul Park
2017-08-23 6:03 ` Byungchul Park
2017-08-23 10:20 ` Peter Zijlstra
2017-08-24 2:02 ` Byungchul Park
2017-08-24 7:30 ` Byungchul Park
2017-08-22 21:19 ` Dave Chinner
2017-08-23 2:31 ` Byungchul Park
2017-08-23 6:11 ` Byungchul Park
2017-08-23 10:46 ` Peter Zijlstra
2017-08-24 5:06 ` Byungchul Park
2017-08-23 1:56 ` Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-ea3f2c0fdfbb180f142cdbc0d1f055c7b9a5e63e@git.kernel.org \
--to=tipbot@zytor.com \
--cc=byungchul.park@lge.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox