* [PATCH 0/2] tip queue 2015-05-18 @ 2015-05-18 8:07 Borislav Petkov 2015-05-18 8:07 ` [PATCH 1/2] Documentation/ABI: Update contact for L3 cache index disable Borislav Petkov 2015-05-18 8:07 ` [PATCH 2/2] x86/mce: Use only critical MCE severity message Borislav Petkov 0 siblings, 2 replies; 7+ messages in thread From: Borislav Petkov @ 2015-05-18 8:07 UTC (permalink / raw) To: Ingo Molnar; +Cc: X86 ML, LKML From: Borislav Petkov <bp@suse.de> Just two this time, the mce one is urgent material, I've tagged it for stable@. Aravind Gopalakrishnan (1): Documentation/ABI: Update contact for L3 cache index disable Borislav Petkov (1): x86/mce: Use only critical MCE severity message ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] Documentation/ABI: Update contact for L3 cache index disable 2015-05-18 8:07 [PATCH 0/2] tip queue 2015-05-18 Borislav Petkov @ 2015-05-18 8:07 ` Borislav Petkov 2015-05-18 9:11 ` [tip:x86/urgent] x86/Documentation: Update the contact email for L3 cache index disable functionality tip-bot for Aravind Gopalakrishnan 2015-05-18 8:07 ` [PATCH 2/2] x86/mce: Use only critical MCE severity message Borislav Petkov 1 sibling, 1 reply; 7+ messages in thread From: Borislav Petkov @ 2015-05-18 8:07 UTC (permalink / raw) To: Ingo Molnar; +Cc: X86 ML, LKML From: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com> The mailing list discuss@x86-64.org is now defunct. Use x86@kernel.org in its place. Signed-off-by: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com> Cc: sudeep.holla@arm.com Cc: sboyd@codeaurora.org Cc: linux-api@vger.kernel.org Cc: Greg KH <greg@kroah.com> Link: http://lkml.kernel.org/r/1431125098-9470-1-git-send-email-Aravind.Gopalakrishnan@amd.com Signed-off-by: Borislav Petkov <bp@suse.de> --- Documentation/ABI/testing/sysfs-devices-system-cpu | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/ABI/testing/sysfs-devices-system-cpu b/Documentation/ABI/testing/sysfs-devices-system-cpu index 99983e67c13c..f1c46d0f5b46 100644 --- a/Documentation/ABI/testing/sysfs-devices-system-cpu +++ b/Documentation/ABI/testing/sysfs-devices-system-cpu @@ -162,7 +162,7 @@ Description: Discover CPUs in the same CPU frequency coordination domain What: /sys/devices/system/cpu/cpu*/cache/index3/cache_disable_{0,1} Date: August 2008 KernelVersion: 2.6.27 -Contact: discuss@x86-64.org +Contact: x86@kernel.org Description: Disable L3 cache indices These files exist in every CPU's cache/index3 directory. Each -- 2.3.5 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [tip:x86/urgent] x86/Documentation: Update the contact email for L3 cache index disable functionality 2015-05-18 8:07 ` [PATCH 1/2] Documentation/ABI: Update contact for L3 cache index disable Borislav Petkov @ 2015-05-18 9:11 ` tip-bot for Aravind Gopalakrishnan 0 siblings, 0 replies; 7+ messages in thread From: tip-bot for Aravind Gopalakrishnan @ 2015-05-18 9:11 UTC (permalink / raw) To: linux-tip-commits Cc: torvalds, linux-kernel, Aravind.Gopalakrishnan, bp, peterz, hpa, greg, tglx, mingo Commit-ID: ea8e080b604e2c8221af778221d83a59b6529c5b Gitweb: http://git.kernel.org/tip/ea8e080b604e2c8221af778221d83a59b6529c5b Author: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com> AuthorDate: Mon, 18 May 2015 10:07:16 +0200 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Mon, 18 May 2015 10:34:24 +0200 x86/Documentation: Update the contact email for L3 cache index disable functionality The mailing list discuss@x86-64.org is now defunct. Use the lkml in its place. Signed-off-by: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com> Signed-off-by: Borislav Petkov <bp@suse.de> Cc: Greg KH <greg@kroah.com> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: linux-api@vger.kernel.org Cc: sboyd@codeaurora.org Cc: sudeep.holla@arm.com Link: http://lkml.kernel.org/r/1431125098-9470-1-git-send-email-Aravind.Gopalakrishnan@amd.com Link: http://lkml.kernel.org/r/1431936437-25286-2-git-send-email-bp@alien8.de [ Changed the contact email to lkml. ] Signed-off-by: Ingo Molnar <mingo@kernel.org> --- Documentation/ABI/testing/sysfs-devices-system-cpu | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/ABI/testing/sysfs-devices-system-cpu b/Documentation/ABI/testing/sysfs-devices-system-cpu index 99983e6..da95513 100644 --- a/Documentation/ABI/testing/sysfs-devices-system-cpu +++ b/Documentation/ABI/testing/sysfs-devices-system-cpu @@ -162,7 +162,7 @@ Description: Discover CPUs in the same CPU frequency coordination domain What: /sys/devices/system/cpu/cpu*/cache/index3/cache_disable_{0,1} Date: August 2008 KernelVersion: 2.6.27 -Contact: discuss@x86-64.org +Contact: Linux kernel mailing list <linux-kernel@vger.kernel.org> Description: Disable L3 cache indices These files exist in every CPU's cache/index3 directory. Each ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] x86/mce: Use only critical MCE severity message 2015-05-18 8:07 [PATCH 0/2] tip queue 2015-05-18 Borislav Petkov 2015-05-18 8:07 ` [PATCH 1/2] Documentation/ABI: Update contact for L3 cache index disable Borislav Petkov @ 2015-05-18 8:07 ` Borislav Petkov 2015-05-18 9:11 ` [tip:x86/urgent] x86/mce: Fix MCE severity messages tip-bot for Borislav Petkov 1 sibling, 1 reply; 7+ messages in thread From: Borislav Petkov @ 2015-05-18 8:07 UTC (permalink / raw) To: Ingo Molnar; +Cc: X86 ML, LKML From: Borislav Petkov <bp@suse.de> Derek noticed that a critical MCE gets reported with the wrong error message: [Hardware Error]: CPU 34: Machine Check Exception: 5 Bank 9: f200003f000100b0 [Hardware Error]: RIP !INEXACT! 10:<ffffffff812e14c1> {intel_idle+0xb1/0x170} [Hardware Error]: TSC 49587b8e321cb [Hardware Error]: PROCESSOR 0:306e4 TIME 1431561296 SOCKET 1 APIC 29 [Hardware Error]: Some CPUs didn't answer in synchronization [Hardware Error]: Machine check: Invalid ^^^^^^^ due to the fact that mce_no_way_out() iterates over all MCA banks and possibly overwrites the @msg argument which is used in the panic printing later. Change behavior to take the message of only and the (last) critical MCE it detects. Reported-by: Derek <denc716@gmail.com> Signed-off-by: Borislav Petkov <bp@suse.de> Cc: Tony Luck <tony.luck@intel.com> Cc: <stable@vger.kernel.org> --- arch/x86/kernel/cpu/mcheck/mce.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c index 521e5016aca6..4d450ac74e3d 100644 --- a/arch/x86/kernel/cpu/mcheck/mce.c +++ b/arch/x86/kernel/cpu/mcheck/mce.c @@ -708,6 +708,7 @@ static int mce_no_way_out(struct mce *m, char **msg, unsigned long *validp, struct pt_regs *regs) { int i, ret = 0; + char *tmp; for (i = 0; i < mca_cfg.banks; i++) { m->status = mce_rdmsrl(MSR_IA32_MCx_STATUS(i)); @@ -716,9 +717,11 @@ static int mce_no_way_out(struct mce *m, char **msg, unsigned long *validp, if (quirk_no_way_out) quirk_no_way_out(i, m, regs); } - if (mce_severity(m, mca_cfg.tolerant, msg, true) >= - MCE_PANIC_SEVERITY) + + if (mce_severity(m, mca_cfg.tolerant, &tmp, true) >= MCE_PANIC_SEVERITY) { + *msg = tmp; ret = 1; + } } return ret; } -- 2.3.5 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [tip:x86/urgent] x86/mce: Fix MCE severity messages 2015-05-18 8:07 ` [PATCH 2/2] x86/mce: Use only critical MCE severity message Borislav Petkov @ 2015-05-18 9:11 ` tip-bot for Borislav Petkov 0 siblings, 0 replies; 7+ messages in thread From: tip-bot for Borislav Petkov @ 2015-05-18 9:11 UTC (permalink / raw) To: linux-tip-commits Cc: linux-kernel, mingo, hpa, peterz, tony.luck, torvalds, denc716, bp, tglx, stable Commit-ID: 17fea54bf0ab34fa09a06bbde2f58ed7bbdf9299 Gitweb: http://git.kernel.org/tip/17fea54bf0ab34fa09a06bbde2f58ed7bbdf9299 Author: Borislav Petkov <bp@suse.de> AuthorDate: Mon, 18 May 2015 10:07:17 +0200 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Mon, 18 May 2015 10:31:22 +0200 x86/mce: Fix MCE severity messages Derek noticed that a critical MCE gets reported with the wrong error type description: [Hardware Error]: CPU 34: Machine Check Exception: 5 Bank 9: f200003f000100b0 [Hardware Error]: RIP !INEXACT! 10:<ffffffff812e14c1> {intel_idle+0xb1/0x170} [Hardware Error]: TSC 49587b8e321cb [Hardware Error]: PROCESSOR 0:306e4 TIME 1431561296 SOCKET 1 APIC 29 [Hardware Error]: Some CPUs didn't answer in synchronization [Hardware Error]: Machine check: Invalid ^^^^^^^ The last line with 'Invalid' should have printed the high level MCE error type description we get from mce_severity, i.e. something like: [Hardware Error]: Machine check: Action required: data load error in a user process this happens due to the fact that mce_no_way_out() iterates over all MCA banks and possibly overwrites the @msg argument which is used in the panic printing later. Change behavior to take the message of only and the (last) critical MCE it detects. Reported-by: Derek <denc716@gmail.com> Signed-off-by: Borislav Petkov <bp@suse.de> Cc: <stable@vger.kernel.org> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Tony Luck <tony.luck@intel.com> Link: http://lkml.kernel.org/r/1431936437-25286-3-git-send-email-bp@alien8.de Signed-off-by: Ingo Molnar <mingo@kernel.org> --- arch/x86/kernel/cpu/mcheck/mce.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c index e535533..20190bd 100644 --- a/arch/x86/kernel/cpu/mcheck/mce.c +++ b/arch/x86/kernel/cpu/mcheck/mce.c @@ -708,6 +708,7 @@ static int mce_no_way_out(struct mce *m, char **msg, unsigned long *validp, struct pt_regs *regs) { int i, ret = 0; + char *tmp; for (i = 0; i < mca_cfg.banks; i++) { m->status = mce_rdmsrl(MSR_IA32_MCx_STATUS(i)); @@ -716,9 +717,11 @@ static int mce_no_way_out(struct mce *m, char **msg, unsigned long *validp, if (quirk_no_way_out) quirk_no_way_out(i, m, regs); } - if (mce_severity(m, mca_cfg.tolerant, msg, true) >= - MCE_PANIC_SEVERITY) + + if (mce_severity(m, mca_cfg.tolerant, &tmp, true) >= MCE_PANIC_SEVERITY) { + *msg = tmp; ret = 1; + } } return ret; } ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] Docmentation, ABI: Update contact for L3 cache index disable @ 2015-05-08 22:44 Aravind Gopalakrishnan 2015-05-14 9:25 ` Borislav Petkov 0 siblings, 1 reply; 7+ messages in thread From: Aravind Gopalakrishnan @ 2015-05-08 22:44 UTC (permalink / raw) To: bp, gregkh; +Cc: sudeep.holla, sboyd, linux-api, linux-kernel The mailing list discuss@x86-64.org is now defunct. Using x86@kernel.org in its place. Signed-off-by: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com> --- Documentation/ABI/testing/sysfs-devices-system-cpu | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/ABI/testing/sysfs-devices-system-cpu b/Documentation/ABI/testing/sysfs-devices-system-cpu index 99983e6..f1c46d0 100644 --- a/Documentation/ABI/testing/sysfs-devices-system-cpu +++ b/Documentation/ABI/testing/sysfs-devices-system-cpu @@ -162,7 +162,7 @@ Description: Discover CPUs in the same CPU frequency coordination domain What: /sys/devices/system/cpu/cpu*/cache/index3/cache_disable_{0,1} Date: August 2008 KernelVersion: 2.6.27 -Contact: discuss@x86-64.org +Contact: x86@kernel.org Description: Disable L3 cache indices These files exist in every CPU's cache/index3 directory. Each -- 2.4.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] Docmentation, ABI: Update contact for L3 cache index disable 2015-05-08 22:44 [PATCH] Docmentation, ABI: Update contact for L3 cache index disable Aravind Gopalakrishnan @ 2015-05-14 9:25 ` Borislav Petkov 0 siblings, 0 replies; 7+ messages in thread From: Borislav Petkov @ 2015-05-14 9:25 UTC (permalink / raw) To: Aravind Gopalakrishnan Cc: gregkh, sudeep.holla, sboyd, linux-api, linux-kernel On Fri, May 08, 2015 at 05:44:58PM -0500, Aravind Gopalakrishnan wrote: > The mailing list discuss@x86-64.org is now defunct. > Using x86@kernel.org in its place. > > Signed-off-by: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com> > --- > Documentation/ABI/testing/sysfs-devices-system-cpu | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/ABI/testing/sysfs-devices-system-cpu b/Documentation/ABI/testing/sysfs-devices-system-cpu > index 99983e6..f1c46d0 100644 > --- a/Documentation/ABI/testing/sysfs-devices-system-cpu > +++ b/Documentation/ABI/testing/sysfs-devices-system-cpu > @@ -162,7 +162,7 @@ Description: Discover CPUs in the same CPU frequency coordination domain > What: /sys/devices/system/cpu/cpu*/cache/index3/cache_disable_{0,1} > Date: August 2008 > KernelVersion: 2.6.27 > -Contact: discuss@x86-64.org > +Contact: x86@kernel.org > Description: Disable L3 cache indices > > These files exist in every CPU's cache/index3 directory. Each Applied, thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-05-18 9:13 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-05-18 8:07 [PATCH 0/2] tip queue 2015-05-18 Borislav Petkov 2015-05-18 8:07 ` [PATCH 1/2] Documentation/ABI: Update contact for L3 cache index disable Borislav Petkov 2015-05-18 9:11 ` [tip:x86/urgent] x86/Documentation: Update the contact email for L3 cache index disable functionality tip-bot for Aravind Gopalakrishnan 2015-05-18 8:07 ` [PATCH 2/2] x86/mce: Use only critical MCE severity message Borislav Petkov 2015-05-18 9:11 ` [tip:x86/urgent] x86/mce: Fix MCE severity messages tip-bot for Borislav Petkov -- strict thread matches above, loose matches on Subject: below -- 2015-05-08 22:44 [PATCH] Docmentation, ABI: Update contact for L3 cache index disable Aravind Gopalakrishnan 2015-05-14 9:25 ` Borislav Petkov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox