From: tip-bot for Anna-Maria Gleixner <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: ebiederm@xmission.com, anna-maria@linutronix.de,
linux-kernel@vger.kernel.org, paulmck@linux.vnet.ibm.com,
mingo@kernel.org, hpa@zytor.com, tglx@linutronix.de
Subject: [tip:core/urgent] rcu: Update documentation of rcu_read_unlock()
Date: Sat, 9 Jun 2018 21:18:45 -0700 [thread overview]
Message-ID: <tip-ec84b27f9b3b569f9235413d1945a2006b97b0aa@git.kernel.org> (raw)
In-Reply-To: <20180525090507.22248-2-anna-maria@linutronix.de>
Commit-ID: ec84b27f9b3b569f9235413d1945a2006b97b0aa
Gitweb: https://git.kernel.org/tip/ec84b27f9b3b569f9235413d1945a2006b97b0aa
Author: Anna-Maria Gleixner <anna-maria@linutronix.de>
AuthorDate: Fri, 25 May 2018 11:05:06 +0200
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Sun, 10 Jun 2018 06:14:01 +0200
rcu: Update documentation of rcu_read_unlock()
Since commit b4abf91047cf ("rtmutex: Make wait_lock irq safe") the
explanation in rcu_read_unlock() documentation about irq unsafe rtmutex
wait_lock is no longer valid.
Remove it to prevent kernel developers reading the documentation to rely on
it.
Suggested-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: bigeasy@linutronix.de
Link: https://lkml.kernel.org/r/20180525090507.22248-2-anna-maria@linutronix.de
---
include/linux/rcupdate.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h
index e679b175b411..65163aa0bb04 100644
--- a/include/linux/rcupdate.h
+++ b/include/linux/rcupdate.h
@@ -652,9 +652,7 @@ static inline void rcu_read_lock(void)
* Unfortunately, this function acquires the scheduler's runqueue and
* priority-inheritance spinlocks. This means that deadlock could result
* if the caller of rcu_read_unlock() already holds one of these locks or
- * any lock that is ever acquired while holding them; or any lock which
- * can be taken from interrupt context because rcu_boost()->rt_mutex_lock()
- * does not disable irqs while taking ->wait_lock.
+ * any lock that is ever acquired while holding them.
*
* That said, RCU readers are never priority boosted unless they were
* preempted. Therefore, one way to avoid deadlock is to make sure
next prev parent reply other threads:[~2018-06-10 4:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 9:05 [PATCH v2 0/2] rtmutex wait_lock is irq safe Anna-Maria Gleixner
2018-05-25 9:05 ` [PATCH v2 1/2] rcu: Update documentation of rcu_read_unlock() Anna-Maria Gleixner
2018-05-25 14:19 ` Paul E. McKenney
2018-05-28 9:49 ` Anna-Maria Gleixner
2018-06-10 4:18 ` tip-bot for Anna-Maria Gleixner [this message]
2018-05-25 9:05 ` [PATCH v2 2/2] signal: Remove no longer required irqsave/restore Anna-Maria Gleixner
2018-06-10 4:19 ` [tip:core/urgent] " tip-bot for Anna-Maria Gleixner
2018-05-25 20:02 ` [PATCH v2 0/2] rtmutex wait_lock is irq safe Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-ec84b27f9b3b569f9235413d1945a2006b97b0aa@git.kernel.org \
--to=tipbot@zytor.com \
--cc=anna-maria@linutronix.de \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox