From: tip-bot for Borislav Petkov <borislav.petkov@amd.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
konrad.wilk@oracle.com, yinghai@kernel.org, tglx@linutronix.de,
borislav.petkov@amd.com
Subject: [tip:x86/cpu] x86, cpu: Fix show_msr MSR accessing function
Date: Thu, 7 Jun 2012 14:59:38 -0700 [thread overview]
Message-ID: <tip-ecd431d95aa04257e977fd6878e4203ce462e7e9@git.kernel.org> (raw)
In-Reply-To: <1338562358-28182-3-git-send-email-bp@amd64.org>
Commit-ID: ecd431d95aa04257e977fd6878e4203ce462e7e9
Gitweb: http://git.kernel.org/tip/ecd431d95aa04257e977fd6878e4203ce462e7e9
Author: Borislav Petkov <borislav.petkov@amd.com>
AuthorDate: Fri, 1 Jun 2012 16:52:36 +0200
Committer: H. Peter Anvin <hpa@zytor.com>
CommitDate: Thu, 7 Jun 2012 11:41:28 -0700
x86, cpu: Fix show_msr MSR accessing function
There's no real reason why, when showing the MSRs on a CPU at boottime,
we should be using the AMD-specific variant. Simply use the generic safe
one which handles #GPs just fine.
Cc: Yinghai Lu <yinghai@kernel.org>
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
Link: http://lkml.kernel.org/r/1338562358-28182-3-git-send-email-bp@amd64.org
Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
---
arch/x86/kernel/cpu/common.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index 6b9333b..5bbc082 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -947,7 +947,7 @@ static void __cpuinit __print_cpu_msr(void)
index_max = msr_range_array[i].max;
for (index = index_min; index < index_max; index++) {
- if (rdmsrl_amd_safe(index, &val))
+ if (rdmsrl_safe(index, &val))
continue;
printk(KERN_INFO " MSR%08x: %016llx\n", index, val);
}
next prev parent reply other threads:[~2012-06-07 21:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1338562358-28182-1-git-send-email-bp@amd64.org>
2012-06-01 14:53 ` [PATCH 0/4] x86, CPU, AMD: Cleanup AMD-specific MSR-rw users H. Peter Anvin
2012-06-01 14:57 ` Borislav Petkov
2012-06-01 15:06 ` H. Peter Anvin
[not found] ` <1338562358-28182-2-git-send-email-bp@amd64.org>
2012-06-06 20:06 ` [PATCH 1/4] x86, pvops: Remove hooks for {rd,wr}msr_safe_regs Konrad Rzeszutek Wilk
2012-06-07 21:58 ` [tip:x86/cpu] " tip-bot for Andre Przywara
[not found] ` <1338562358-28182-3-git-send-email-bp@amd64.org>
2012-06-01 18:22 ` [PATCH 2/4] x86, CPU: Fix show_msr MSR accessing function Yinghai Lu
2012-06-01 22:50 ` Borislav Petkov
2012-06-06 20:07 ` Konrad Rzeszutek Wilk
2012-06-07 21:59 ` tip-bot for Borislav Petkov [this message]
[not found] ` <1338562358-28182-4-git-send-email-bp@amd64.org>
2012-06-06 20:07 ` [PATCH 3/4] x86, AMD: Fix crash as Xen Dom0 on AMD Trinity systems Konrad Rzeszutek Wilk
2012-06-06 22:00 ` H. Peter Anvin
2012-06-07 7:21 ` Borislav Petkov
2012-06-07 7:49 ` Andre Przywara
2012-06-07 8:08 ` Greg KH
2012-06-07 8:18 ` Andre Przywara
2012-06-07 13:25 ` [GIT PULL] x86, CPU, AMD: Cleanup AMD-specific MSR-rw users Borislav Petkov
2012-06-07 16:27 ` [PATCH 3/4] x86, AMD: Fix crash as Xen Dom0 on AMD Trinity systems H. Peter Anvin
2012-06-07 22:00 ` [tip:x86/cpu] x86, cpu, amd: " tip-bot for Andre Przywara
[not found] ` <1338562358-28182-5-git-send-email-bp@amd64.org>
2012-06-06 20:07 ` [PATCH 4/4] x86, CPU, AMD: Deprecate AMD-specific MSR variants Konrad Rzeszutek Wilk
2012-06-07 22:01 ` [tip:x86/cpu] x86, cpu, amd: " tip-bot for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-ecd431d95aa04257e977fd6878e4203ce462e7e9@git.kernel.org \
--to=borislav.petkov@amd.com \
--cc=hpa@zytor.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox