* sched: fix compilation warning on !SMP
@ 2012-01-31 2:40 Hiroshi Shimamoto
2012-01-31 8:46 ` Vincent Guittot
2012-01-31 13:28 ` [tip:sched/core] sched: Move SMP-only variable into the SMP section tip-bot for Hiroshi Shimamoto
0 siblings, 2 replies; 4+ messages in thread
From: Hiroshi Shimamoto @ 2012-01-31 2:40 UTC (permalink / raw)
To: Ingo Molnar, Peter Zijlstra, Vincent Guittot,
linux-kernel@vger.kernel.org
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
CC kernel/sched/fair.o
kernel/sched/fair.c:218:36: warning: 'max_load_balance_interval' defined but not used [-Wunused-variable]
Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
CC: Peter Zijlstra <a.p.zijlstra@chello.nl>
CC: Vincent Guittot <vincent.guittot@linaro.org>
---
kernel/sched/fair.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 8e77a6b..4ab60a2 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -215,8 +215,6 @@ calc_delta_mine(unsigned long delta_exec, unsigned long weight,
const struct sched_class fair_sched_class;
-static unsigned long __read_mostly max_load_balance_interval = HZ/10;
-
/**************************************************************
* CFS operations on generic schedulable entities:
*/
@@ -3086,6 +3084,8 @@ static bool yield_to_task_fair(struct rq *rq, struct task_struct *p, bool preemp
* Fair scheduling class load-balancing methods:
*/
+static unsigned long __read_mostly max_load_balance_interval = HZ/10;
+
/*
* pull_task - move a task from a remote runqueue to the local runqueue.
* Both runqueues must be locked.
--
1.7.7.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: sched: fix compilation warning on !SMP
2012-01-31 2:40 sched: fix compilation warning on !SMP Hiroshi Shimamoto
@ 2012-01-31 8:46 ` Vincent Guittot
2012-01-31 12:20 ` Vincent Guittot
2012-01-31 13:28 ` [tip:sched/core] sched: Move SMP-only variable into the SMP section tip-bot for Hiroshi Shimamoto
1 sibling, 1 reply; 4+ messages in thread
From: Vincent Guittot @ 2012-01-31 8:46 UTC (permalink / raw)
To: Hiroshi Shimamoto
Cc: Ingo Molnar, Peter Zijlstra, linux-kernel@vger.kernel.org
2012/1/31 Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>:
> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>
> CC kernel/sched/fair.o
> kernel/sched/fair.c:218:36: warning: 'max_load_balance_interval' defined but not used [-Wunused-variable]
>
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
> CC: Peter Zijlstra <a.p.zijlstra@chello.nl>
> CC: Vincent Guittot <vincent.guittot@linaro.org>
> ---
> kernel/sched/fair.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 8e77a6b..4ab60a2 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -215,8 +215,6 @@ calc_delta_mine(unsigned long delta_exec, unsigned long weight,
>
> const struct sched_class fair_sched_class;
>
> -static unsigned long __read_mostly max_load_balance_interval = HZ/10;
> -
> /**************************************************************
> * CFS operations on generic schedulable entities:
> */
> @@ -3086,6 +3084,8 @@ static bool yield_to_task_fair(struct rq *rq, struct task_struct *p, bool preemp
> * Fair scheduling class load-balancing methods:
> */
>
> +static unsigned long __read_mostly max_load_balance_interval = HZ/10;
> +
Sorry for moving it out of SMP. Thanks for fixing this
> /*
> * pull_task - move a task from a remote runqueue to the local runqueue.
> * Both runqueues must be locked.
> --
> 1.7.7.6
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: sched: fix compilation warning on !SMP
2012-01-31 8:46 ` Vincent Guittot
@ 2012-01-31 12:20 ` Vincent Guittot
0 siblings, 0 replies; 4+ messages in thread
From: Vincent Guittot @ 2012-01-31 12:20 UTC (permalink / raw)
To: Hiroshi Shimamoto
Cc: Ingo Molnar, Peter Zijlstra, linux-kernel@vger.kernel.org
On 31 January 2012 09:46, Vincent Guittot <vincent.guittot@linaro.org> wrote:
> 2012/1/31 Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>:
>> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>>
>> CC kernel/sched/fair.o
>> kernel/sched/fair.c:218:36: warning: 'max_load_balance_interval' defined but not used [-Wunused-variable]
>>
>> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>> CC: Peter Zijlstra <a.p.zijlstra@chello.nl>
>> CC: Vincent Guittot <vincent.guittot@linaro.org>
>> ---
>> kernel/sched/fair.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
>> index 8e77a6b..4ab60a2 100644
>> --- a/kernel/sched/fair.c
>> +++ b/kernel/sched/fair.c
>> @@ -215,8 +215,6 @@ calc_delta_mine(unsigned long delta_exec, unsigned long weight,
>>
>> const struct sched_class fair_sched_class;
>>
>> -static unsigned long __read_mostly max_load_balance_interval = HZ/10;
>> -
>> /**************************************************************
>> * CFS operations on generic schedulable entities:
>> */
>> @@ -3086,6 +3084,8 @@ static bool yield_to_task_fair(struct rq *rq, struct task_struct *p, bool preemp
>> * Fair scheduling class load-balancing methods:
>> */
>>
>> +static unsigned long __read_mostly max_load_balance_interval = HZ/10;
>> +
>
> Sorry for moving it out of SMP. Thanks for fixing this
>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
>> /*
>> * pull_task - move a task from a remote runqueue to the local runqueue.
>> * Both runqueues must be locked.
>> --
>> 1.7.7.6
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:sched/core] sched: Move SMP-only variable into the SMP section
2012-01-31 2:40 sched: fix compilation warning on !SMP Hiroshi Shimamoto
2012-01-31 8:46 ` Vincent Guittot
@ 2012-01-31 13:28 ` tip-bot for Hiroshi Shimamoto
1 sibling, 0 replies; 4+ messages in thread
From: tip-bot for Hiroshi Shimamoto @ 2012-01-31 13:28 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, h-shimamoto, hpa, mingo, a.p.zijlstra,
vincent.guittot, tglx, mingo
Commit-ID: ed387b781ea6e14b78f449aa2ee4f270b60b01ac
Gitweb: http://git.kernel.org/tip/ed387b781ea6e14b78f449aa2ee4f270b60b01ac
Author: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
AuthorDate: Tue, 31 Jan 2012 11:40:32 +0900
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 31 Jan 2012 13:40:59 +0100
sched: Move SMP-only variable into the SMP section
This also fixes the following compilation warning on !SMP:
CC kernel/sched/fair.o
kernel/sched/fair.c:218:36: warning: 'max_load_balance_interval' defined but not used [-Wunused-variable]
Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/4F2754A0.9090306@ct.jp.nec.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/sched/fair.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 8e77a6b..4ab60a2 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -215,8 +215,6 @@ calc_delta_mine(unsigned long delta_exec, unsigned long weight,
const struct sched_class fair_sched_class;
-static unsigned long __read_mostly max_load_balance_interval = HZ/10;
-
/**************************************************************
* CFS operations on generic schedulable entities:
*/
@@ -3086,6 +3084,8 @@ static bool yield_to_task_fair(struct rq *rq, struct task_struct *p, bool preemp
* Fair scheduling class load-balancing methods:
*/
+static unsigned long __read_mostly max_load_balance_interval = HZ/10;
+
/*
* pull_task - move a task from a remote runqueue to the local runqueue.
* Both runqueues must be locked.
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-31 13:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-31 2:40 sched: fix compilation warning on !SMP Hiroshi Shimamoto
2012-01-31 8:46 ` Vincent Guittot
2012-01-31 12:20 ` Vincent Guittot
2012-01-31 13:28 ` [tip:sched/core] sched: Move SMP-only variable into the SMP section tip-bot for Hiroshi Shimamoto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).