* [PATCH -next] rslib: Make some functions static
@ 2019-07-02 6:18 YueHaibing
2019-07-02 6:46 ` [tip:core/rslib] " tip-bot for YueHaibing
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-07-02 6:18 UTC (permalink / raw)
To: tglx, ferdinand.blomqvist; +Cc: linux-kernel, YueHaibing
Fix sparse warnings:
lib/reed_solomon/test_rslib.c:313:5: warning: symbol 'ex_rs_helper' was not declared. Should it be static?
lib/reed_solomon/test_rslib.c:349:5: warning: symbol 'exercise_rs' was not declared. Should it be static?
lib/reed_solomon/test_rslib.c:407:5: warning: symbol 'exercise_rs_bc' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
lib/reed_solomon/test_rslib.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/reed_solomon/test_rslib.c b/lib/reed_solomon/test_rslib.c
index eb62e03..4eb29f3 100644
--- a/lib/reed_solomon/test_rslib.c
+++ b/lib/reed_solomon/test_rslib.c
@@ -310,8 +310,8 @@ static void test_uc(struct rs_control *rs, int len, int errs,
stat->nwords += trials;
}
-int ex_rs_helper(struct rs_control *rs, struct wspace *ws,
- int len, int trials, int method)
+static int ex_rs_helper(struct rs_control *rs, struct wspace *ws,
+ int len, int trials, int method)
{
static const char * const desc[] = {
"Testing correction buffer interface...",
@@ -346,8 +346,8 @@ int ex_rs_helper(struct rs_control *rs, struct wspace *ws,
return retval;
}
-int exercise_rs(struct rs_control *rs, struct wspace *ws,
- int len, int trials)
+static int exercise_rs(struct rs_control *rs, struct wspace *ws,
+ int len, int trials)
{
int retval = 0;
@@ -404,8 +404,8 @@ static void test_bc(struct rs_control *rs, int len, int errs,
stat->nwords += trials;
}
-int exercise_rs_bc(struct rs_control *rs, struct wspace *ws,
- int len, int trials)
+static int exercise_rs_bc(struct rs_control *rs, struct wspace *ws,
+ int len, int trials)
{
struct bcstat stat = {0, 0, 0, 0};
int nroots = rs->codec->nroots;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:core/rslib] rslib: Make some functions static
2019-07-02 6:18 [PATCH -next] rslib: Make some functions static YueHaibing
@ 2019-07-02 6:46 ` tip-bot for YueHaibing
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for YueHaibing @ 2019-07-02 6:46 UTC (permalink / raw)
To: linux-tip-commits
Cc: ferdinand.blomqvist, yuehaibing, linux-kernel, tglx, hpa, hulkci,
mingo
Commit-ID: ede7c247abfaeef62484cfff320b072ec2b1dca0
Gitweb: https://git.kernel.org/tip/ede7c247abfaeef62484cfff320b072ec2b1dca0
Author: YueHaibing <yuehaibing@huawei.com>
AuthorDate: Tue, 2 Jul 2019 14:18:47 +0800
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 2 Jul 2019 08:41:37 +0200
rslib: Make some functions static
Fix sparse warnings:
lib/reed_solomon/test_rslib.c:313:5: warning: symbol 'ex_rs_helper' was not declared. Should it be static?
lib/reed_solomon/test_rslib.c:349:5: warning: symbol 'exercise_rs' was not declared. Should it be static?
lib/reed_solomon/test_rslib.c:407:5: warning: symbol 'exercise_rs_bc' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: <ferdinand.blomqvist@gmail.com>
Link: https://lkml.kernel.org/r/20190702061847.26060-1-yuehaibing@huawei.com
---
lib/reed_solomon/test_rslib.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/reed_solomon/test_rslib.c b/lib/reed_solomon/test_rslib.c
index eb62e0393c80..4eb29f365ece 100644
--- a/lib/reed_solomon/test_rslib.c
+++ b/lib/reed_solomon/test_rslib.c
@@ -310,8 +310,8 @@ static void test_uc(struct rs_control *rs, int len, int errs,
stat->nwords += trials;
}
-int ex_rs_helper(struct rs_control *rs, struct wspace *ws,
- int len, int trials, int method)
+static int ex_rs_helper(struct rs_control *rs, struct wspace *ws,
+ int len, int trials, int method)
{
static const char * const desc[] = {
"Testing correction buffer interface...",
@@ -346,8 +346,8 @@ int ex_rs_helper(struct rs_control *rs, struct wspace *ws,
return retval;
}
-int exercise_rs(struct rs_control *rs, struct wspace *ws,
- int len, int trials)
+static int exercise_rs(struct rs_control *rs, struct wspace *ws,
+ int len, int trials)
{
int retval = 0;
@@ -404,8 +404,8 @@ static void test_bc(struct rs_control *rs, int len, int errs,
stat->nwords += trials;
}
-int exercise_rs_bc(struct rs_control *rs, struct wspace *ws,
- int len, int trials)
+static int exercise_rs_bc(struct rs_control *rs, struct wspace *ws,
+ int len, int trials)
{
struct bcstat stat = {0, 0, 0, 0};
int nroots = rs->codec->nroots;
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-02 6:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-02 6:18 [PATCH -next] rslib: Make some functions static YueHaibing
2019-07-02 6:46 ` [tip:core/rslib] " tip-bot for YueHaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox