From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752724AbbJWIcz (ORCPT ); Fri, 23 Oct 2015 04:32:55 -0400 Received: from terminus.zytor.com ([198.137.202.10]:55685 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751754AbbJWIcv (ORCPT ); Fri, 23 Oct 2015 04:32:51 -0400 Date: Fri, 23 Oct 2015 01:32:34 -0700 From: tip-bot for Arnaldo Carvalho de Melo Message-ID: Cc: fweisbec@gmail.com, acme@redhat.com, linux-kernel@vger.kernel.org, bp@suse.de, dsahern@gmail.com, adrian.hunter@intel.com, hpa@zytor.com, wangnan0@huawei.com, eranian@google.com, namhyung@kernel.org, jolsa@redhat.com, mingo@kernel.org, tglx@linutronix.de Reply-To: dsahern@gmail.com, adrian.hunter@intel.com, bp@suse.de, linux-kernel@vger.kernel.org, wangnan0@huawei.com, hpa@zytor.com, acme@redhat.com, fweisbec@gmail.com, namhyung@kernel.org, jolsa@redhat.com, tglx@linutronix.de, mingo@kernel.org, eranian@google.com To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf ui tui: Register the error callbacks before initializing the widgets Git-Commit-ID: 464b01a48eb6be48bc58332e029760b5e40ea119 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 464b01a48eb6be48bc58332e029760b5e40ea119 Gitweb: http://git.kernel.org/tip/464b01a48eb6be48bc58332e029760b5e40ea119 Author: Arnaldo Carvalho de Melo AuthorDate: Thu, 22 Oct 2015 16:44:17 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 22 Oct 2015 16:44:17 -0300 perf ui tui: Register the error callbacks before initializing the widgets I.e. we want to tell the user about errors found during, for instance, the ui_browser initialization, so that a call to ui__warning() appears as a window waiting for a key to be pressed. Cc: Adrian Hunter Cc: Borislav Petkov Cc: David Ahern Cc: Frederic Weisbecker Cc: Jiri Olsa Cc: Namhyung Kim Cc: Stephane Eranian Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-ederrwizcl6mfz10vfobl5qq@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/ui/tui/setup.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/perf/ui/tui/setup.c b/tools/perf/ui/tui/setup.c index 60d1f29..7dfeba0 100644 --- a/tools/perf/ui/tui/setup.c +++ b/tools/perf/ui/tui/setup.c @@ -141,10 +141,6 @@ int ui__init(void) SLkp_define_keysym((char *)"^(kB)", SL_KEY_UNTAB); - ui_helpline__init(); - ui_browser__init(); - tui_progress__init(); - signal(SIGSEGV, ui__signal_backtrace); signal(SIGFPE, ui__signal_backtrace); signal(SIGINT, ui__signal); @@ -153,6 +149,10 @@ int ui__init(void) perf_error__register(&perf_tui_eops); + ui_helpline__init(); + ui_browser__init(); + tui_progress__init(); + hist_browser__init_hpp(); out: return err;