From: tip-bot for Namhyung Kim <namhyung.kim@lge.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, linux-kernel@vger.kernel.org, paulus@samba.org,
hpa@zytor.com, mingo@kernel.org, a.p.zijlstra@chello.nl,
namhyung.kim@lge.com, namhyung@kernel.org, tglx@linutronix.de
Subject: [tip:perf/core] perf trace: Explicitly enable system-wide mode if no option is given
Date: Tue, 9 Oct 2012 10:20:19 -0700 [thread overview]
Message-ID: <tip-ee76120e2d13a2d4eb0cc88da8a8e7f7909cc276@git.kernel.org> (raw)
In-Reply-To: <1349413336-26936-3-git-send-email-namhyung@kernel.org>
Commit-ID: ee76120e2d13a2d4eb0cc88da8a8e7f7909cc276
Gitweb: http://git.kernel.org/tip/ee76120e2d13a2d4eb0cc88da8a8e7f7909cc276
Author: Namhyung Kim <namhyung.kim@lge.com>
AuthorDate: Fri, 5 Oct 2012 14:02:14 +0900
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 5 Oct 2012 12:48:51 -0300
perf trace: Explicitly enable system-wide mode if no option is given
When no target cpu/user/task option is given, perf trace will do its job
system wide for all online cpus. Make it explicit to reduce possible
confusion when reading code.
No functional changes intended.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1349413336-26936-3-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-trace.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index f01fa6f..da1183f 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -343,5 +343,8 @@ int cmd_trace(int argc, const char **argv, const char *prefix __maybe_unused)
return err;
}
+ if (perf_target__none(&trace.opts.target))
+ trace.opts.target.system_wide = true;
+
return trace__run(&trace);
}
next prev parent reply other threads:[~2012-10-09 17:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 5:02 [PATCH 1/5] perf trace: Setup pager before running Namhyung Kim
2012-10-05 5:02 ` [PATCH 2/5] perf trace: Validate target task/user/cpu argument Namhyung Kim
2012-10-09 17:19 ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-10-05 5:02 ` [PATCH 3/5] perf trace: Explicitly enable system-wide mode if no option is given Namhyung Kim
2012-10-09 17:20 ` tip-bot for Namhyung Kim [this message]
2012-10-05 5:02 ` [PATCH 4/5] perf trace: Add -a switch for --all-cpus option Namhyung Kim
2012-10-05 5:02 ` [PATCH 5/5] perf trace: Add support for tracing workload given by command line Namhyung Kim
2012-10-09 17:21 ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-10-05 15:47 ` [PATCH 1/5] perf trace: Setup pager before running Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-ee76120e2d13a2d4eb0cc88da8a8e7f7909cc276@git.kernel.org \
--to=namhyung.kim@lge.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox