Re: [PATCH -tip v3 05/10] kprobes: Search non-suffixed symbol in blacklist

Ingo Molnar
2019-02-13T07:13:23Z

* Masami Hiramatsu <mhiramat@kernel.org> wrote:

> Newer gcc can generate some different instances of a function
> with suffixed symbols if the function is optimized and only
> has a part of that. (e.g. .constprop, .part etc.)
>
> In this case, it is not enough to check the entry of kprobe
> blacklist because it only records non-suffixed symbol address.
>
> To fix this issue, search non-suffixed symbol in blacklist if
> given address is within a symbol which has a suffix.
>
> Note that this can cause false positive cases if a kprobe-safe
> function is optimized to suffixed instance and has same name
> symbol which is blacklisted.
> But I would like to chose a fail-safe design for this issue.
>
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>

Why did you not add Steven's Reviewed-by tag?

Thanks,

Ingo