From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755602AbcIEL4S (ORCPT ); Mon, 5 Sep 2016 07:56:18 -0400 Received: from terminus.zytor.com ([198.137.202.10]:36450 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933003AbcIEL4N (ORCPT ); Mon, 5 Sep 2016 07:56:13 -0400 Date: Mon, 5 Sep 2016 04:55:42 -0700 From: "tip-bot for seokhoon.yoon" Message-ID: Cc: peterz@infradead.org, torvalds@linux-foundation.org, tglx@linutronix.de, hpa@zytor.com, linux-kernel@vger.kernel.org, iamyooon@gmail.com, mingo@kernel.org Reply-To: mingo@kernel.org, iamyooon@gmail.com, linux-kernel@vger.kernel.org, hpa@zytor.com, tglx@linutronix.de, torvalds@linux-foundation.org, peterz@infradead.org In-Reply-To: <1471339568-5790-1-git-send-email-iamyooon@gmail.com> References: <1471339568-5790-1-git-send-email-iamyooon@gmail.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:sched/core] schedcore: Remove duplicated init_task's preempt_notifiers init Git-Commit-ID: efca03ecbe29a46c2c5ae539563b6326af9dcba7 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: efca03ecbe29a46c2c5ae539563b6326af9dcba7 Gitweb: http://git.kernel.org/tip/efca03ecbe29a46c2c5ae539563b6326af9dcba7 Author: seokhoon.yoon AuthorDate: Tue, 16 Aug 2016 18:26:08 +0900 Committer: Ingo Molnar CommitDate: Mon, 5 Sep 2016 13:29:44 +0200 schedcore: Remove duplicated init_task's preempt_notifiers init init_task's preempt_notifiers is initialized twice: 1) sched_init() -> INIT_HLIST_HEAD(&init_task.preempt_notifiers) 2) sched_init() -> init_idle(current,) <--- current task is init_task at this time -> __sched_fork(,current) -> INIT_HLIST_HEAD(&p->preempt_notifiers) I think the first one is unnecessary, so remove it. Signed-off-by: seokhoon.yoon Signed-off-by: Peter Zijlstra (Intel) Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/1471339568-5790-1-git-send-email-iamyooon@gmail.com Signed-off-by: Ingo Molnar --- kernel/sched/core.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 7d602f5..90b1961 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -7554,10 +7554,6 @@ void __init sched_init(void) set_load_weight(&init_task); -#ifdef CONFIG_PREEMPT_NOTIFIERS - INIT_HLIST_HEAD(&init_task.preempt_notifiers); -#endif - /* * The boot idle thread does lazy MMU switching as well: */