From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1D38C43219 for ; Tue, 30 Apr 2019 11:23:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7F5F520675 for ; Tue, 30 Apr 2019 11:23:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=zytor.com header.i=@zytor.com header.b="uWS03uwo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727571AbfD3LXX (ORCPT ); Tue, 30 Apr 2019 07:23:23 -0400 Received: from terminus.zytor.com ([198.137.202.136]:55031 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726736AbfD3LXW (ORCPT ); Tue, 30 Apr 2019 07:23:22 -0400 Received: from terminus.zytor.com (localhost [127.0.0.1]) by terminus.zytor.com (8.15.2/8.15.2) with ESMTPS id x3UBMmxW1347914 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 30 Apr 2019 04:22:48 -0700 DKIM-Filter: OpenDKIM Filter v2.11.0 terminus.zytor.com x3UBMmxW1347914 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zytor.com; s=2019041745; t=1556623369; bh=Ge64oaq9IF85kTTWHMmPXyLrFHLm+O8W4XfcR0nuqaA=; h=Date:From:Cc:Reply-To:In-Reply-To:References:To:Subject:From; b=uWS03uwo9NpLZTnRJVBVkAeCCcJad+QmV6kZSGIyzbk0Vr0wNMwdeBfexZqf76JBL MgIa3QXdQUzhiYYg7eV2yFz0Pby36bCwqkCyy6G8wB7zpSSpXddfvtxBZiIAZrSGTZ 4mMO0ducgxIljAtec3kH5Raa1OUVSqPTFJstEmDTNj7tiaEvf+ibhjMQPRn8f2PIcN pRyaLdkFZVrjBXuMCIaxONuyGkoq39p8M719vxfd3ASvVOFkplOJXxDV+TrNh0o8f0 FrT1StoX9GgaPb/RKup5pF5gtcvt+PloDqkAE+3PGyYXr0O/fSbhwJcoomr+/XHTRl RVcWLRaDR5w1Q== Received: (from tipbot@localhost) by terminus.zytor.com (8.15.2/8.15.2/Submit) id x3UBMllL1347909; Tue, 30 Apr 2019 04:22:47 -0700 Date: Tue, 30 Apr 2019 04:22:47 -0700 X-Authentication-Warning: terminus.zytor.com: tipbot set sender to tipbot@zytor.com using -f From: tip-bot for Nadav Amit Message-ID: Cc: bp@alien8.de, ard.biesheuvel@linaro.org, deneen.t.dock@intel.com, jeyu@kernel.org, torvalds@linux-foundation.org, linux_dti@icloud.com, rick.p.edgecombe@intel.com, kernel-hardening@lists.openwall.com, keescook@chromium.org, mhiramat@kernel.org, dave.hansen@intel.com, luto@amacapital.net, peterz@infradead.org, namit@vmware.com, luto@kernel.org, kristen@linux.intel.com, mingo@kernel.org, tglx@linutronix.de, riel@surriel.com, linux-kernel@vger.kernel.org, will.deacon@arm.com, akpm@linux-foundation.org, hpa@zytor.com Reply-To: bp@alien8.de, jeyu@kernel.org, deneen.t.dock@intel.com, ard.biesheuvel@linaro.org, rick.p.edgecombe@intel.com, linux_dti@icloud.com, torvalds@linux-foundation.org, keescook@chromium.org, kernel-hardening@lists.openwall.com, luto@amacapital.net, dave.hansen@intel.com, mhiramat@kernel.org, mingo@kernel.org, kristen@linux.intel.com, luto@kernel.org, namit@vmware.com, peterz@infradead.org, will.deacon@arm.com, linux-kernel@vger.kernel.org, riel@surriel.com, tglx@linutronix.de, hpa@zytor.com, akpm@linux-foundation.org In-Reply-To: <20190426001143.4983-12-namit@vmware.com> References: <20190426001143.4983-12-namit@vmware.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/mm] x86/modules: Avoid breaking W^X while loading modules Git-Commit-ID: f2c65fb3221adc6b73b0549fc7ba892022db9797 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: f2c65fb3221adc6b73b0549fc7ba892022db9797 Gitweb: https://git.kernel.org/tip/f2c65fb3221adc6b73b0549fc7ba892022db9797 Author: Nadav Amit AuthorDate: Thu, 25 Apr 2019 17:11:31 -0700 Committer: Ingo Molnar CommitDate: Tue, 30 Apr 2019 12:37:55 +0200 x86/modules: Avoid breaking W^X while loading modules When modules and BPF filters are loaded, there is a time window in which some memory is both writable and executable. An attacker that has already found another vulnerability (e.g., a dangling pointer) might be able to exploit this behavior to overwrite kernel code. Prevent having writable executable PTEs in this stage. In addition, avoiding having W+X mappings can also slightly simplify the patching of modules code on initialization (e.g., by alternatives and static-key), as would be done in the next patch. This was actually the main motivation for this patch. To avoid having W+X mappings, set them initially as RW (NX) and after they are set as RO set them as X as well. Setting them as executable is done as a separate step to avoid one core in which the old PTE is cached (hence writable), and another which sees the updated PTE (executable), which would break the W^X protection. Suggested-by: Thomas Gleixner Suggested-by: Andy Lutomirski Signed-off-by: Nadav Amit Signed-off-by: Rick Edgecombe Signed-off-by: Peter Zijlstra (Intel) Cc: Cc: Cc: Cc: Cc: Cc: Cc: Cc: Andy Lutomirski Cc: Borislav Petkov Cc: Dave Hansen Cc: H. Peter Anvin Cc: Jessica Yu Cc: Kees Cook Cc: Linus Torvalds Cc: Masami Hiramatsu Cc: Rik van Riel Link: https://lkml.kernel.org/r/20190426001143.4983-12-namit@vmware.com Signed-off-by: Ingo Molnar --- arch/x86/kernel/alternative.c | 28 +++++++++++++++++++++------- arch/x86/kernel/module.c | 2 +- include/linux/filter.h | 1 + kernel/module.c | 5 +++++ 4 files changed, 28 insertions(+), 8 deletions(-) diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c index 599203876c32..3d2b6b6fb20c 100644 --- a/arch/x86/kernel/alternative.c +++ b/arch/x86/kernel/alternative.c @@ -668,15 +668,29 @@ void __init alternative_instructions(void) * handlers seeing an inconsistent instruction while you patch. */ void *__init_or_module text_poke_early(void *addr, const void *opcode, - size_t len) + size_t len) { unsigned long flags; - local_irq_save(flags); - memcpy(addr, opcode, len); - local_irq_restore(flags); - sync_core(); - /* Could also do a CLFLUSH here to speed up CPU recovery; but - that causes hangs on some VIA CPUs. */ + + if (boot_cpu_has(X86_FEATURE_NX) && + is_module_text_address((unsigned long)addr)) { + /* + * Modules text is marked initially as non-executable, so the + * code cannot be running and speculative code-fetches are + * prevented. Just change the code. + */ + memcpy(addr, opcode, len); + } else { + local_irq_save(flags); + memcpy(addr, opcode, len); + local_irq_restore(flags); + sync_core(); + + /* + * Could also do a CLFLUSH here to speed up CPU recovery; but + * that causes hangs on some VIA CPUs. + */ + } return addr; } diff --git a/arch/x86/kernel/module.c b/arch/x86/kernel/module.c index b052e883dd8c..cfa3106faee4 100644 --- a/arch/x86/kernel/module.c +++ b/arch/x86/kernel/module.c @@ -87,7 +87,7 @@ void *module_alloc(unsigned long size) p = __vmalloc_node_range(size, MODULE_ALIGN, MODULES_VADDR + get_module_load_offset(), MODULES_END, GFP_KERNEL, - PAGE_KERNEL_EXEC, 0, NUMA_NO_NODE, + PAGE_KERNEL, 0, NUMA_NO_NODE, __builtin_return_address(0)); if (p && (kasan_module_alloc(p, size) < 0)) { vfree(p); diff --git a/include/linux/filter.h b/include/linux/filter.h index 6074aa064b54..14ec3bdad9a9 100644 --- a/include/linux/filter.h +++ b/include/linux/filter.h @@ -746,6 +746,7 @@ static inline void bpf_prog_unlock_ro(struct bpf_prog *fp) static inline void bpf_jit_binary_lock_ro(struct bpf_binary_header *hdr) { set_memory_ro((unsigned long)hdr, hdr->pages); + set_memory_x((unsigned long)hdr, hdr->pages); } static inline void bpf_jit_binary_unlock_ro(struct bpf_binary_header *hdr) diff --git a/kernel/module.c b/kernel/module.c index 0b9aa8ab89f0..2b2845ae983e 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -1950,8 +1950,13 @@ void module_enable_ro(const struct module *mod, bool after_init) return; frob_text(&mod->core_layout, set_memory_ro); + frob_text(&mod->core_layout, set_memory_x); + frob_rodata(&mod->core_layout, set_memory_ro); + frob_text(&mod->init_layout, set_memory_ro); + frob_text(&mod->init_layout, set_memory_x); + frob_rodata(&mod->init_layout, set_memory_ro); if (after_init)