From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759545AbcBYFt4 (ORCPT ); Thu, 25 Feb 2016 00:49:56 -0500 Received: from torg.zytor.com ([198.137.202.12]:53818 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751830AbcBYFtx (ORCPT ); Thu, 25 Feb 2016 00:49:53 -0500 Date: Wed, 24 Feb 2016 21:47:36 -0800 From: tip-bot for Josh Poimboeuf Message-ID: Cc: palves@redhat.com, bernd@petrovitsch.priv.at, chris.j.arges@canonical.com, dvlasenk@redhat.com, peterz@infradead.org, jslaby@suse.cz, brgerst@gmail.com, herbert@gondor.apana.org.au, mmarek@suse.cz, davem@davemloft.net, luto@amacapital.net, hpa@zytor.com, torvalds@linux-foundation.org, luto@kernel.org, mingo@kernel.org, akpm@linux-foundation.org, bp@suse.de, acme@kernel.org, linux-kernel@vger.kernel.org, namhyung@gmail.com, jpoimboe@redhat.com, bp@alien8.de, tglx@linutronix.de Reply-To: namhyung@gmail.com, linux-kernel@vger.kernel.org, jpoimboe@redhat.com, bp@alien8.de, tglx@linutronix.de, mingo@kernel.org, akpm@linux-foundation.org, bp@suse.de, acme@kernel.org, herbert@gondor.apana.org.au, luto@amacapital.net, mmarek@suse.cz, davem@davemloft.net, torvalds@linux-foundation.org, hpa@zytor.com, luto@kernel.org, bernd@petrovitsch.priv.at, palves@redhat.com, chris.j.arges@canonical.com, dvlasenk@redhat.com, peterz@infradead.org, jslaby@suse.cz, brgerst@gmail.com In-Reply-To: <1dbf80c097bb9d89c0cbddc01a815ada690e3b32.1453405861.git.jpoimboe@redhat.com> References: <1dbf80c097bb9d89c0cbddc01a815ada690e3b32.1453405861.git.jpoimboe@redhat.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/debug] x86/asm/crypto: Move jump_table to .rodata section Git-Commit-ID: f66f61919eb38c5f20e8a978cae7ecdede4c23b9 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: f66f61919eb38c5f20e8a978cae7ecdede4c23b9 Gitweb: http://git.kernel.org/tip/f66f61919eb38c5f20e8a978cae7ecdede4c23b9 Author: Josh Poimboeuf AuthorDate: Thu, 21 Jan 2016 16:49:16 -0600 Committer: Ingo Molnar CommitDate: Wed, 24 Feb 2016 08:35:42 +0100 x86/asm/crypto: Move jump_table to .rodata section stacktool reports the following warning: stacktool: arch/x86/crypto/crc32c-pcl-intel-asm_64.o: crc_pcl()+0x11dd: can't decode instruction It gets confused when trying to decode jump_table data. Move jump_table to the .rodata section which is a more appropriate home for read-only data. Signed-off-by: Josh Poimboeuf Reviewed-by: Borislav Petkov Cc: Andrew Morton Cc: Andy Lutomirski Cc: Andy Lutomirski Cc: Arnaldo Carvalho de Melo Cc: Bernd Petrovitsch Cc: Borislav Petkov Cc: Brian Gerst Cc: Chris J Arges Cc: David S. Miller Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Herbert Xu Cc: Jiri Slaby Cc: Linus Torvalds Cc: Michal Marek Cc: Namhyung Kim Cc: Pedro Alves Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: live-patching@vger.kernel.org Link: http://lkml.kernel.org/r/1dbf80c097bb9d89c0cbddc01a815ada690e3b32.1453405861.git.jpoimboe@redhat.com Signed-off-by: Ingo Molnar --- arch/x86/crypto/crc32c-pcl-intel-asm_64.S | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/crypto/crc32c-pcl-intel-asm_64.S b/arch/x86/crypto/crc32c-pcl-intel-asm_64.S index 4fe27e0..dc05f01 100644 --- a/arch/x86/crypto/crc32c-pcl-intel-asm_64.S +++ b/arch/x86/crypto/crc32c-pcl-intel-asm_64.S @@ -170,8 +170,8 @@ continue_block: ## branch into array lea jump_table(%rip), bufp movzxw (bufp, %rax, 2), len - offset=crc_array-jump_table - lea offset(bufp, len, 1), bufp + lea crc_array(%rip), bufp + lea (bufp, len, 1), bufp jmp *bufp ################################################################ @@ -310,7 +310,9 @@ do_return: popq %rdi popq %rbx ret +ENDPROC(crc_pcl) +.section .rodata, "a", %progbits ################################################################ ## jump table Table is 129 entries x 2 bytes each ################################################################ @@ -324,13 +326,11 @@ JMPTBL_ENTRY %i i=i+1 .endr -ENDPROC(crc_pcl) ################################################################ ## PCLMULQDQ tables ## Table is 128 entries x 2 words (8 bytes) each ################################################################ -.section .rodata, "a", %progbits .align 8 K_table: .long 0x493c7d27, 0x00000001