From: tip-bot for Kan Liang <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, jolsa@redhat.com, mingo@redhat.com,
mingo@kernel.org, hpa@zytor.com, namhyung@kernel.org,
ak@linux.intel.com, linux-kernel@vger.kernel.org,
tglx@linutronix.de, a.p.zijlstra@chello.nl, paulus@samba.org,
kan.liang@intel.com, eranian@google.com
Subject: [tip:perf/urgent] perf callchain: Fixup parameter handling error message
Date: Fri, 12 Dec 2014 00:17:50 -0800 [thread overview]
Message-ID: <tip-f70b4e39de4ef25aade966c0dfc69cfb97091be9@git.kernel.org> (raw)
In-Reply-To: <1417532814-26208-2-git-send-email-kan.liang@intel.com>
Commit-ID: f70b4e39de4ef25aade966c0dfc69cfb97091be9
Gitweb: http://git.kernel.org/tip/f70b4e39de4ef25aade966c0dfc69cfb97091be9
Author: Kan Liang <kan.liang@intel.com>
AuthorDate: Tue, 2 Dec 2014 10:06:52 -0500
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 9 Dec 2014 10:06:11 -0300
perf callchain: Fixup parameter handling error message
Fix up parse_callchain_record_opt error message for 'fp', in the past using '-g
fp' was a valid alternative to '--call-graph fp', which is not the case since:
commit 09b0fd45ff63413df94cbd832a765076b201edbb
Author: Jiri Olsa <jolsa@redhat.com>
Date: Sat Oct 26 16:25:33 2013 +0200
perf record: Split -g and --call-graph
I.e. -g means "use the configured unwind data collection method" which has as
default 'fp', while --call-graph requires passing the method to use.
Signed-off-by: Kan Liang <kan.liang@intel.com>
Acked-by: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1417532814-26208-2-git-send-email-kan.liang@intel.com
[ split this from a larger patch related to LBR based unwinding ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/callchain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c
index cf524a3..64b377e 100644
--- a/tools/perf/util/callchain.c
+++ b/tools/perf/util/callchain.c
@@ -77,7 +77,7 @@ int parse_callchain_record_opt(const char *arg)
ret = 0;
} else
pr_err("callchain: No more arguments "
- "needed for -g fp\n");
+ "needed for --call-graph fp\n");
break;
#ifdef HAVE_DWARF_UNWIND_SUPPORT
next prev parent reply other threads:[~2014-12-12 8:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 15:06 [PATCH V5 0/3] perf tool: Haswell LBR call stack support (user) kan.liang
2014-12-02 15:06 ` [PATCH V5 1/3] perf tools: enable LBR call stack support kan.liang
2014-12-12 8:17 ` tip-bot for Kan Liang [this message]
2014-12-02 15:06 ` [PATCH V5 2/3] perf tool: Move cpumode resolve code to add_callchain_ip kan.liang
2014-12-12 8:18 ` [tip:perf/urgent] perf callchain: " tip-bot for Kan Liang
2014-12-02 15:06 ` [PATCH V5 3/3] perf tools: Construct LBR call chain kan.liang
2014-12-04 14:23 ` [PATCH V5 0/3] perf tool: Haswell LBR call stack support (user) Jiri Olsa
2014-12-04 14:49 ` Liang, Kan
2014-12-04 15:51 ` Arnaldo Carvalho de Melo
2014-12-04 16:02 ` Jiri Olsa
2014-12-04 16:18 ` Liang, Kan
2014-12-09 12:27 ` Arnaldo Carvalho de Melo
2014-12-09 12:53 ` Jiri Olsa
2014-12-09 13:11 ` Arnaldo Carvalho de Melo
2014-12-09 13:22 ` Jiri Olsa
2014-12-09 13:27 ` Arnaldo Carvalho de Melo
2014-12-09 13:33 ` Jiri Olsa
2015-01-05 13:57 ` Peter Zijlstra
2015-01-05 15:58 ` Liang, Kan
2014-12-11 22:21 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-f70b4e39de4ef25aade966c0dfc69cfb97091be9@git.kernel.org \
--to=tipbot@zytor.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox