public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Li Fei <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
	stable@kernel.org, tglx@linutronix.de, chuansheng.liu@intel.com,
	fei.li@intel.com
Subject: [tip:perf/urgent] x86: Eliminate irq_mis_count counted in arch_irq_stat
Date: Tue, 30 Apr 2013 09:45:29 -0700	[thread overview]
Message-ID: <tip-f7b0e1055574ce06ab53391263b4e205bf38daf3@git.kernel.org> (raw)
In-Reply-To: <1366980611.32469.7.camel@fli24-HP-Compaq-8100-Elite-CMT-PC>

Commit-ID:  f7b0e1055574ce06ab53391263b4e205bf38daf3
Gitweb:     http://git.kernel.org/tip/f7b0e1055574ce06ab53391263b4e205bf38daf3
Author:     Li Fei <fei.li@intel.com>
AuthorDate: Fri, 26 Apr 2013 20:50:11 +0800
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 30 Apr 2013 10:56:37 +0200

x86: Eliminate irq_mis_count counted in arch_irq_stat

With the current implementation, kstat_cpu(cpu).irqs_sum is also
increased in case of irq_mis_count increment.

So there is no need to count irq_mis_count in arch_irq_stat,
otherwise irq_mis_count will be counted twice in the sum of
/proc/stat.

Reported-by: Liu Chuansheng <chuansheng.liu@intel.com>
Signed-off-by: Li Fei <fei.li@intel.com>
Acked-by: Liu Chuansheng <chuansheng.liu@intel.com>
Cc: tomoki.sekiyama.qu@hitachi.com
Cc: joe@perches.com
Link: http://lkml.kernel.org/r/1366980611.32469.7.camel@fli24-HP-Compaq-8100-Elite-CMT-PC
Cc: <stable@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/kernel/irq.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
index e4595f1..84b7789 100644
--- a/arch/x86/kernel/irq.c
+++ b/arch/x86/kernel/irq.c
@@ -165,10 +165,6 @@ u64 arch_irq_stat_cpu(unsigned int cpu)
 u64 arch_irq_stat(void)
 {
 	u64 sum = atomic_read(&irq_err_count);
-
-#ifdef CONFIG_X86_IO_APIC
-	sum += atomic_read(&irq_mis_count);
-#endif
 	return sum;
 }
 

      reply	other threads:[~2013-04-30 16:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-26  7:56 [PATCH] x86: eliminate irq_mis_count counted in arch_irq_stat Li Fei
2013-04-26  8:19 ` Ingo Molnar
2013-04-26  8:44   ` Li, Fei
2013-04-26  9:33     ` Ingo Molnar
2013-04-26 12:50 ` [PATCH V2] " Li Fei
2013-04-30 16:45   ` tip-bot for Li Fei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-f7b0e1055574ce06ab53391263b4e205bf38daf3@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=chuansheng.liu@intel.com \
    --cc=fei.li@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=stable@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox