public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "tip-bot for H. Peter Anvin" <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
	mjg59@srcf.ucam.org, aubrey.li@intel.com, tglx@linutronix.de,
	hpa@linux.intel.com
Subject: [tip:x86/reboot] x86, reboot: Only use CF9_COND automatically, not CF9
Date: Wed, 5 Mar 2014 15:45:27 -0800	[thread overview]
Message-ID: <tip-fb3bd7b19b2b6ef779d18573c10c00c53cd8add6@git.kernel.org> (raw)
In-Reply-To: <53130A46.1010801@linux.intel.com>

Commit-ID:  fb3bd7b19b2b6ef779d18573c10c00c53cd8add6
Gitweb:     http://git.kernel.org/tip/fb3bd7b19b2b6ef779d18573c10c00c53cd8add6
Author:     H. Peter Anvin <hpa@linux.intel.com>
AuthorDate: Wed, 5 Mar 2014 15:41:15 -0800
Committer:  H. Peter Anvin <hpa@linux.intel.com>
CommitDate: Wed, 5 Mar 2014 15:41:15 -0800

x86, reboot: Only use CF9_COND automatically, not CF9

Only CF9_COND is appropriate for inclusion in the default chain, not
CF9; the latter will poke that register unconditionally, whereas
CF9_COND will at least look for PCI configuration method #1 or #2
first (a weak check, but better than nothing.)

CF9 should be used for explicit system configuration (command line or
DMI) only.

Cc: Aubrey Li <aubrey.li@intel.com>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
Link: http://lkml.kernel.org/r/53130A46.1010801@linux.intel.com
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
---
 arch/x86/kernel/reboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
index f601295..654b465 100644
--- a/arch/x86/kernel/reboot.c
+++ b/arch/x86/kernel/reboot.c
@@ -535,7 +535,7 @@ static void native_machine_emergency_restart(void)
 						 EFI_RESET_WARM :
 						 EFI_RESET_COLD,
 						 EFI_SUCCESS, 0, NULL);
-			reboot_type = BOOT_CF9;
+			reboot_type = BOOT_CF9_COND;
 			break;
 
 		case BOOT_CF9:

      parent reply	other threads:[~2014-03-05 23:45 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-28  4:11 [patch] x86: Introduce BOOT_EFI and BOOT_CF9 into the reboot sequence loop Li, Aubrey
2014-02-28  4:56 ` Matthew Garrett
2014-02-28  5:22   ` Li, Aubrey
2014-02-28  5:56     ` Matthew Garrett
2014-02-28  6:07       ` Li, Aubrey
2014-02-28  6:12         ` Matthew Garrett
2014-02-28  6:20           ` Li, Aubrey
2014-02-28  6:23             ` Matthew Garrett
2014-02-28  6:39               ` Li, Aubrey
2014-02-28  6:44                 ` Matthew Garrett
2014-02-28  6:54                   ` Li, Aubrey
2014-02-28 17:47                     ` H. Peter Anvin
2014-02-28 22:11                       ` Li, Aubrey
2014-02-28 22:16                         ` Adam Williamson
2014-03-01 17:10                         ` Li, Aubrey
2014-03-01 17:22                           ` Matthew Garrett
2014-03-01 17:31                             ` Li, Aubrey
2014-03-01 18:19                               ` Matthew Garrett
2014-03-01 19:01                                 ` Matthew Garrett
2014-03-02  0:15                                   ` Li, Aubrey
2014-03-01 20:06                             ` H. Peter Anvin
2014-03-01 20:21                               ` Matthew Garrett
2014-03-01 20:26                                 ` H. Peter Anvin
2014-03-02  0:26                                   ` Li, Aubrey
2014-03-02  0:33                                     ` H. Peter Anvin
2014-03-02  1:47                                       ` Li, Aubrey
2014-03-02  2:07                                         ` H. Peter Anvin
2014-03-02  2:20                                           ` Li, Aubrey
2014-03-02  2:23                                           ` Matthew Garrett
2014-03-02  2:35                                             ` H. Peter Anvin
2014-03-02 10:39                                               ` Li, Aubrey
2014-03-02 16:52                                                 ` H. Peter Anvin
2014-03-02 22:13                                                   ` Li, Aubrey
2014-03-02 22:26                                                     ` Matthew Garrett
2014-03-02 22:45                                                       ` Li, Aubrey
2014-03-02 23:11                                                         ` Matthew Garrett
2014-03-02 23:23                                                           ` Li, Aubrey
2014-03-03  0:07                                                             ` Matthew Garrett
2014-03-03  0:18                                                               ` H. Peter Anvin
2014-03-03  1:36                                                                 ` Li, Aubrey
2014-03-03  1:47                                                                   ` H. Peter Anvin
2014-03-03  1:49                                                                     ` Li, Aubrey
2014-03-03 22:11                                                                       ` Li, Aubrey
2014-03-02 23:57                                                     ` H. Peter Anvin
2014-03-05 23:39                                                 ` [tip:x86/reboot] x86, reboot: Add EFI and CF9 reboot methods into the default list tip-bot for Li, Aubrey
2014-03-05 23:45                                                 ` tip-bot for H. Peter Anvin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-fb3bd7b19b2b6ef779d18573c10c00c53cd8add6@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=aubrey.li@intel.com \
    --cc=hpa@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox