* [PATCH] irqchip: sunxi-nmi: Fix off-by-one for iterating over gc->num_ct
@ 2015-06-07 13:33 Axel Lin
2015-06-08 7:59 ` Maxime Ripard
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Axel Lin @ 2015-06-07 13:33 UTC (permalink / raw)
To: Thomas Gleixner, Jason Cooper; +Cc: Maxime Ripard, Carlo Caione, linux-kernel
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/irqchip/irq-sunxi-nmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-sunxi-nmi.c b/drivers/irqchip/irq-sunxi-nmi.c
index 12f547a..eb9b59e 100644
--- a/drivers/irqchip/irq-sunxi-nmi.c
+++ b/drivers/irqchip/irq-sunxi-nmi.c
@@ -104,7 +104,7 @@ static int sunxi_sc_nmi_set_type(struct irq_data *data, unsigned int flow_type)
irqd_set_trigger_type(data, flow_type);
irq_setup_alt_chip(data, flow_type);
- for (i = 0; i <= gc->num_ct; i++, ct++)
+ for (i = 0; i < gc->num_ct; i++, ct++)
if (ct->type & flow_type)
ctrl_off = ct->regs.type;
--
1.8.3.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] irqchip: sunxi-nmi: Fix off-by-one for iterating over gc->num_ct
2015-06-07 13:33 [PATCH] irqchip: sunxi-nmi: Fix off-by-one for iterating over gc->num_ct Axel Lin
@ 2015-06-08 7:59 ` Maxime Ripard
2015-06-08 8:11 ` Carlo Caione
2015-06-08 8:12 ` [tip:irq/urgent] irqchip: sunxi-nmi: Fix off-by-one error in irq iterator tip-bot for Axel Lin
2 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2015-06-08 7:59 UTC (permalink / raw)
To: Axel Lin; +Cc: Thomas Gleixner, Jason Cooper, Carlo Caione, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 302 bytes --]
On Sun, Jun 07, 2015 at 09:33:29PM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] irqchip: sunxi-nmi: Fix off-by-one for iterating over gc->num_ct
2015-06-07 13:33 [PATCH] irqchip: sunxi-nmi: Fix off-by-one for iterating over gc->num_ct Axel Lin
2015-06-08 7:59 ` Maxime Ripard
@ 2015-06-08 8:11 ` Carlo Caione
2015-06-08 8:12 ` [tip:irq/urgent] irqchip: sunxi-nmi: Fix off-by-one error in irq iterator tip-bot for Axel Lin
2 siblings, 0 replies; 4+ messages in thread
From: Carlo Caione @ 2015-06-08 8:11 UTC (permalink / raw)
To: Axel Lin
Cc: Thomas Gleixner, Jason Cooper, Maxime Ripard, Carlo Caione,
linux-kernel
On Sun, Jun 7, 2015 at 3:33 PM, Axel Lin <axel.lin@ingics.com> wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/irqchip/irq-sunxi-nmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-sunxi-nmi.c b/drivers/irqchip/irq-sunxi-nmi.c
> index 12f547a..eb9b59e 100644
> --- a/drivers/irqchip/irq-sunxi-nmi.c
> +++ b/drivers/irqchip/irq-sunxi-nmi.c
> @@ -104,7 +104,7 @@ static int sunxi_sc_nmi_set_type(struct irq_data *data, unsigned int flow_type)
> irqd_set_trigger_type(data, flow_type);
> irq_setup_alt_chip(data, flow_type);
>
> - for (i = 0; i <= gc->num_ct; i++, ct++)
> + for (i = 0; i < gc->num_ct; i++, ct++)
> if (ct->type & flow_type)
> ctrl_off = ct->regs.type;
Acked-by: Carlo Caione <carlo@endlessm.com>
--
Carlo Caione
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:irq/urgent] irqchip: sunxi-nmi: Fix off-by-one error in irq iterator
2015-06-07 13:33 [PATCH] irqchip: sunxi-nmi: Fix off-by-one for iterating over gc->num_ct Axel Lin
2015-06-08 7:59 ` Maxime Ripard
2015-06-08 8:11 ` Carlo Caione
@ 2015-06-08 8:12 ` tip-bot for Axel Lin
2 siblings, 0 replies; 4+ messages in thread
From: tip-bot for Axel Lin @ 2015-06-08 8:12 UTC (permalink / raw)
To: linux-tip-commits
Cc: jason, hpa, mingo, axel.lin, linux-kernel, tglx, carlo,
maxime.ripard
Commit-ID: febe06962ab191db50e633a0f79d9fb89a2d1078
Gitweb: http://git.kernel.org/tip/febe06962ab191db50e633a0f79d9fb89a2d1078
Author: Axel Lin <axel.lin@ingics.com>
AuthorDate: Sun, 7 Jun 2015 21:33:29 +0800
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 8 Jun 2015 10:08:50 +0200
irqchip: sunxi-nmi: Fix off-by-one error in irq iterator
Fixes: 6058bb362818 'ARM: sun7i/sun6i: irqchip: Add irqchip driver for NMI controller'
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Carlo Caione <carlo@caione.org>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/1433684009.9134.1.camel@ingics.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
drivers/irqchip/irq-sunxi-nmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-sunxi-nmi.c b/drivers/irqchip/irq-sunxi-nmi.c
index 4a9ce5b..6b2b582 100644
--- a/drivers/irqchip/irq-sunxi-nmi.c
+++ b/drivers/irqchip/irq-sunxi-nmi.c
@@ -104,7 +104,7 @@ static int sunxi_sc_nmi_set_type(struct irq_data *data, unsigned int flow_type)
irqd_set_trigger_type(data, flow_type);
irq_setup_alt_chip(data, flow_type);
- for (i = 0; i <= gc->num_ct; i++, ct++)
+ for (i = 0; i < gc->num_ct; i++, ct++)
if (ct->type & flow_type)
ctrl_off = ct->regs.type;
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-06-08 8:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-07 13:33 [PATCH] irqchip: sunxi-nmi: Fix off-by-one for iterating over gc->num_ct Axel Lin
2015-06-08 7:59 ` Maxime Ripard
2015-06-08 8:11 ` Carlo Caione
2015-06-08 8:12 ` [tip:irq/urgent] irqchip: sunxi-nmi: Fix off-by-one error in irq iterator tip-bot for Axel Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox