From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932551AbdHVKZs (ORCPT ); Tue, 22 Aug 2017 06:25:48 -0400 Received: from terminus.zytor.com ([65.50.211.136]:57603 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932156AbdHVKZq (ORCPT ); Tue, 22 Aug 2017 06:25:46 -0400 Date: Tue, 22 Aug 2017 03:23:29 -0700 From: tip-bot for Arnaldo Carvalho de Melo Message-ID: Cc: jolsa@kernel.org, tglx@linutronix.de, adrian.hunter@intel.com, wangnan0@huawei.com, mingo@kernel.org, acme@redhat.com, namhyung@kernel.org, linux-kernel@vger.kernel.org, dsahern@gmail.com, hpa@zytor.com Reply-To: wangnan0@huawei.com, jolsa@kernel.org, tglx@linutronix.de, adrian.hunter@intel.com, linux-kernel@vger.kernel.org, dsahern@gmail.com, hpa@zytor.com, mingo@kernel.org, acme@redhat.com, namhyung@kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf trace: Fix off by one string allocation problem Git-Commit-ID: d6d4fc6fefda26a88eb99d30e87a8834c59c144a X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: d6d4fc6fefda26a88eb99d30e87a8834c59c144a Gitweb: http://git.kernel.org/tip/d6d4fc6fefda26a88eb99d30e87a8834c59c144a Author: Arnaldo Carvalho de Melo AuthorDate: Thu, 17 Aug 2017 15:12:55 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 17 Aug 2017 16:39:14 -0300 perf trace: Fix off by one string allocation problem We need to consider the null terminator, oops, fix it. Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Fixes: 017037ff3d0b ("perf trace: Allow specifying list of syscalls and events in -e/--expr/--event") Link: http://lkml.kernel.org/n/tip-j79jpqqe91gvxqmsgxgfn2ni@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index de02413..9190583 100644 --- a/tools/perf/builtin-trace.c +++ b/tools/perf/builtin-trace.c @@ -2806,7 +2806,7 @@ static int trace__parse_events_option(const struct option *opt, const char *str, struct trace *trace = (struct trace *)opt->value; const char *s = str; char *sep = NULL, *lists[2] = { NULL, NULL, }; - int len = strlen(str), err = -1, list; + int len = strlen(str) + 1, err = -1, list; char *strace_groups_dir = system_path(STRACE_GROUPS_DIR); char group_name[PATH_MAX];