From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752658AbbB1JcR (ORCPT ); Sat, 28 Feb 2015 04:32:17 -0500 Received: from terminus.zytor.com ([198.137.202.10]:45025 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752568AbbB1JcO (ORCPT ); Sat, 28 Feb 2015 04:32:14 -0500 Date: Sat, 28 Feb 2015 01:31:25 -0800 From: tip-bot for Arnaldo Carvalho de Melo Message-ID: Cc: namhyung@kernel.org, dsahern@gmail.com, naota@elisp.net, hpa@zytor.com, jolsa@redhat.com, masami.hiramatsu.pt@hitachi.com, acme@redhat.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@kernel.org Reply-To: dsahern@gmail.com, naota@elisp.net, namhyung@kernel.org, tglx@linutronix.de, mingo@kernel.org, linux-kernel@vger.kernel.org, acme@redhat.com, hpa@zytor.com, masami.hiramatsu.pt@hitachi.com, jolsa@redhat.com To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf probe: Handle strdup() failure Git-Commit-ID: 38ae502b1df196f712f6f5d3609afc36337b330b X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 38ae502b1df196f712f6f5d3609afc36337b330b Gitweb: http://git.kernel.org/tip/38ae502b1df196f712f6f5d3609afc36337b330b Author: Arnaldo Carvalho de Melo AuthorDate: Thu, 26 Feb 2015 11:47:18 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 27 Feb 2015 10:08:29 -0300 perf probe: Handle strdup() failure We could end up returning 0 (Ok) with a NULL raw_path. Fix it. Acked-by: Masami Hiramatsu Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Naohiro Aota Link: http://lkml.kernel.org/n/tip-l0kcbcg5f4nnzqt01cv42vec@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/probe-event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c index 4a93bf4..9526cf3 100644 --- a/tools/perf/util/probe-event.c +++ b/tools/perf/util/probe-event.c @@ -533,7 +533,7 @@ static int get_real_path(const char *raw_path, const char *comp_dir, else { if (access(raw_path, R_OK) == 0) { *new_path = strdup(raw_path); - return 0; + return *new_path ? 0 : -ENOMEM; } else return -errno; }