* [tip:perf/urgent] perf/x86: Add SNB offcore event constraints
@ 2012-03-27 15:36 tip-bot for Peter Zijlstra
2012-03-27 18:31 ` Stephane Eranian
2012-03-27 21:52 ` Peter Zijlstra
0 siblings, 2 replies; 3+ messages in thread
From: tip-bot for Peter Zijlstra @ 2012-03-27 15:36 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, eranian, hpa, mingo, a.p.zijlstra, stable, tglx
Commit-ID: c370117c978adba861fad467427a9301c2c7082b
Gitweb: http://git.kernel.org/tip/c370117c978adba861fad467427a9301c2c7082b
Author: Peter Zijlstra <a.p.zijlstra@chello.nl>
AuthorDate: Thu, 22 Mar 2012 11:41:23 +0100
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 27 Mar 2012 14:53:46 +0200
perf/x86: Add SNB offcore event constraints
As found in the Intel SDM (March 2012 edition) in Volume 3
section 18.8.5, the offcore response events are constrained
to PMC0 and PMC3 resp..
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Cc: <stable@kernel.org>
Link: http://lkml.kernel.org/n/tip-n6vf6grjv94vnzvuccu0clcv@git.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/kernel/cpu/perf_event_intel.c | 14 ++++++++------
1 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/arch/x86/kernel/cpu/perf_event_intel.c b/arch/x86/kernel/cpu/perf_event_intel.c
index 26b3e2f..bab8c6d 100644
--- a/arch/x86/kernel/cpu/perf_event_intel.c
+++ b/arch/x86/kernel/cpu/perf_event_intel.c
@@ -96,12 +96,14 @@ static struct event_constraint intel_westmere_event_constraints[] __read_mostly
static struct event_constraint intel_snb_event_constraints[] __read_mostly =
{
- FIXED_EVENT_CONSTRAINT(0x00c0, 0), /* INST_RETIRED.ANY */
- FIXED_EVENT_CONSTRAINT(0x003c, 1), /* CPU_CLK_UNHALTED.CORE */
- FIXED_EVENT_CONSTRAINT(0x0300, 2), /* CPU_CLK_UNHALTED.REF */
- INTEL_EVENT_CONSTRAINT(0x48, 0x4), /* L1D_PEND_MISS.PENDING */
- INTEL_UEVENT_CONSTRAINT(0x01c0, 0x2), /* INST_RETIRED.PREC_DIST */
- INTEL_EVENT_CONSTRAINT(0xcd, 0x8), /* MEM_TRANS_RETIRED.LOAD_LATENCY */
+ FIXED_EVENT_CONSTRAINT(0x00c0, 0), /* INST_RETIRED.ANY */
+ FIXED_EVENT_CONSTRAINT(0x003c, 1), /* CPU_CLK_UNHALTED.CORE */
+ FIXED_EVENT_CONSTRAINT(0x0300, 2), /* CPU_CLK_UNHALTED.REF */
+ INTEL_EVENT_CONSTRAINT(0x48, 0x4), /* L1D_PEND_MISS.PENDING */
+ INTEL_UEVENT_CONSTRAINT(0x01c0, 0x2), /* INST_RETIRED.PREC_DIST */
+ INTEL_EVENT_CONSTRAINT(0xcd, 0x8), /* MEM_TRANS_RETIRED.LOAD_LATENCY */
+ INTEL_UEVENT_CONSTRAINT(0x01b7, 0x1), /* OFFCORE_RSP_0 */
+ INTEL_UEVENT_CONSTRAINT(0x01bb, 0x8), /* OFFCORE_RSP_1 */
EVENT_CONSTRAINT_END
};
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [tip:perf/urgent] perf/x86: Add SNB offcore event constraints
2012-03-27 15:36 [tip:perf/urgent] perf/x86: Add SNB offcore event constraints tip-bot for Peter Zijlstra
@ 2012-03-27 18:31 ` Stephane Eranian
2012-03-27 21:52 ` Peter Zijlstra
1 sibling, 0 replies; 3+ messages in thread
From: Stephane Eranian @ 2012-03-27 18:31 UTC (permalink / raw)
To: mingo, hpa, eranian, linux-kernel, a.p.zijlstra, stable, tglx
Cc: linux-tip-commits
On Tue, Mar 27, 2012 at 8:36 AM, tip-bot for Peter Zijlstra
<a.p.zijlstra@chello.nl> wrote:
> Commit-ID: c370117c978adba861fad467427a9301c2c7082b
> Gitweb: http://git.kernel.org/tip/c370117c978adba861fad467427a9301c2c7082b
> Author: Peter Zijlstra <a.p.zijlstra@chello.nl>
> AuthorDate: Thu, 22 Mar 2012 11:41:23 +0100
> Committer: Ingo Molnar <mingo@kernel.org>
> CommitDate: Tue, 27 Mar 2012 14:53:46 +0200
>
> perf/x86: Add SNB offcore event constraints
>
> As found in the Intel SDM (March 2012 edition) in Volume 3
> section 18.8.5, the offcore response events are constrained
> to PMC0 and PMC3 resp..
>
I don't believe this is correct in the SDM. It may be a side effect
of how Intel tools work. I'll check again.
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Stephane Eranian <eranian@google.com>
> Cc: <stable@kernel.org>
> Link: http://lkml.kernel.org/n/tip-n6vf6grjv94vnzvuccu0clcv@git.kernel.org
> Signed-off-by: Ingo Molnar <mingo@kernel.org>
> ---
> arch/x86/kernel/cpu/perf_event_intel.c | 14 ++++++++------
> 1 files changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/perf_event_intel.c b/arch/x86/kernel/cpu/perf_event_intel.c
> index 26b3e2f..bab8c6d 100644
> --- a/arch/x86/kernel/cpu/perf_event_intel.c
> +++ b/arch/x86/kernel/cpu/perf_event_intel.c
> @@ -96,12 +96,14 @@ static struct event_constraint intel_westmere_event_constraints[] __read_mostly
>
> static struct event_constraint intel_snb_event_constraints[] __read_mostly =
> {
> - FIXED_EVENT_CONSTRAINT(0x00c0, 0), /* INST_RETIRED.ANY */
> - FIXED_EVENT_CONSTRAINT(0x003c, 1), /* CPU_CLK_UNHALTED.CORE */
> - FIXED_EVENT_CONSTRAINT(0x0300, 2), /* CPU_CLK_UNHALTED.REF */
> - INTEL_EVENT_CONSTRAINT(0x48, 0x4), /* L1D_PEND_MISS.PENDING */
> - INTEL_UEVENT_CONSTRAINT(0x01c0, 0x2), /* INST_RETIRED.PREC_DIST */
> - INTEL_EVENT_CONSTRAINT(0xcd, 0x8), /* MEM_TRANS_RETIRED.LOAD_LATENCY */
> + FIXED_EVENT_CONSTRAINT(0x00c0, 0), /* INST_RETIRED.ANY */
> + FIXED_EVENT_CONSTRAINT(0x003c, 1), /* CPU_CLK_UNHALTED.CORE */
> + FIXED_EVENT_CONSTRAINT(0x0300, 2), /* CPU_CLK_UNHALTED.REF */
> + INTEL_EVENT_CONSTRAINT(0x48, 0x4), /* L1D_PEND_MISS.PENDING */
> + INTEL_UEVENT_CONSTRAINT(0x01c0, 0x2), /* INST_RETIRED.PREC_DIST */
> + INTEL_EVENT_CONSTRAINT(0xcd, 0x8), /* MEM_TRANS_RETIRED.LOAD_LATENCY */
> + INTEL_UEVENT_CONSTRAINT(0x01b7, 0x1), /* OFFCORE_RSP_0 */
> + INTEL_UEVENT_CONSTRAINT(0x01bb, 0x8), /* OFFCORE_RSP_1 */
> EVENT_CONSTRAINT_END
> };
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [tip:perf/urgent] perf/x86: Add SNB offcore event constraints
2012-03-27 15:36 [tip:perf/urgent] perf/x86: Add SNB offcore event constraints tip-bot for Peter Zijlstra
2012-03-27 18:31 ` Stephane Eranian
@ 2012-03-27 21:52 ` Peter Zijlstra
1 sibling, 0 replies; 3+ messages in thread
From: Peter Zijlstra @ 2012-03-27 21:52 UTC (permalink / raw)
To: mingo, hpa, eranian, linux-kernel, stable, tglx; +Cc: linux-tip-commits
On Tue, 2012-03-27 at 08:36 -0700, tip-bot for Peter Zijlstra wrote:
> Commit-ID: c370117c978adba861fad467427a9301c2c7082b
> Gitweb: http://git.kernel.org/tip/c370117c978adba861fad467427a9301c2c7082b
> Author: Peter Zijlstra <a.p.zijlstra@chello.nl>
> AuthorDate: Thu, 22 Mar 2012 11:41:23 +0100
> Committer: Ingo Molnar <mingo@kernel.org>
> CommitDate: Tue, 27 Mar 2012 14:53:46 +0200
>
> perf/x86: Add SNB offcore event constraints
>
> As found in the Intel SDM (March 2012 edition) in Volume 3
> section 18.8.5, the offcore response events are constrained
> to PMC0 and PMC3 resp..
Ingo, Stephane talked to some Intel folks and the SDM was wrong, can you
make this here patch go away?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-27 21:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-27 15:36 [tip:perf/urgent] perf/x86: Add SNB offcore event constraints tip-bot for Peter Zijlstra
2012-03-27 18:31 ` Stephane Eranian
2012-03-27 21:52 ` Peter Zijlstra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox