From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933236AbeAXLW5 (ORCPT ); Wed, 24 Jan 2018 06:22:57 -0500 Received: from terminus.zytor.com ([65.50.211.136]:54943 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933079AbeAXLW4 (ORCPT ); Wed, 24 Jan 2018 06:22:56 -0500 Date: Wed, 24 Jan 2018 03:20:43 -0800 From: tip-bot for Arnaldo Carvalho de Melo Message-ID: Cc: wangnan0@huawei.com, tglx@linutronix.de, dsahern@gmail.com, mingo@kernel.org, hpa@zytor.com, acme@redhat.com, adrian.hunter@intel.com, linux-kernel@vger.kernel.org, jolsa@kernel.org, namhyung@kernel.org Reply-To: namhyung@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com, linux-kernel@vger.kernel.org, hpa@zytor.com, dsahern@gmail.com, mingo@kernel.org, tglx@linutronix.de, wangnan0@huawei.com, acme@redhat.com To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf tools: Use ui__error() for reporting --fields errors Git-Commit-ID: 56271170438df39c1b9a39c7aaf69010e6a4b59a X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 56271170438df39c1b9a39c7aaf69010e6a4b59a Gitweb: https://git.kernel.org/tip/56271170438df39c1b9a39c7aaf69010e6a4b59a Author: Arnaldo Carvalho de Melo AuthorDate: Thu, 18 Jan 2018 10:28:14 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 18 Jan 2018 10:28:14 -0300 perf tools: Use ui__error() for reporting --fields errors So that we can get it working for TUI, where using just pr_err() would end up making the message emitted to stderr to be erased by the TUI exit routine restoring the terminal to its previous state. Now we can see that trying to use a tracepoint field as one of the --field entries isn't working: # perf top --stdio --no-children -e syscalls:sys_enter_write --fields pid,sym,count Error: Unknown --fields key: `count' Usage: perf top [] --fields output field(s): overhead, period, sample plus all of sort keys # Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: https://lkml.kernel.org/n/tip-usy9hhy7umdd4bbblkn63t8w@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/sort.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c index 211e7f3..2da4d04 100644 --- a/tools/perf/util/sort.c +++ b/tools/perf/util/sort.c @@ -2887,10 +2887,10 @@ static int setup_output_list(struct perf_hpp_list *list, char *str) tok; tok = strtok_r(NULL, ", ", &tmp)) { ret = output_field_add(list, tok); if (ret == -EINVAL) { - pr_err("Invalid --fields key: `%s'", tok); + ui__error("Invalid --fields key: `%s'", tok); break; } else if (ret == -ESRCH) { - pr_err("Unknown --fields key: `%s'", tok); + ui__error("Unknown --fields key: `%s'", tok); break; } }