From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753420AbbG2IMJ (ORCPT ); Wed, 29 Jul 2015 04:12:09 -0400 Received: from terminus.zytor.com ([198.137.202.10]:56840 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752897AbbG2IMH (ORCPT ); Wed, 29 Jul 2015 04:12:07 -0400 Date: Wed, 29 Jul 2015 01:11:50 -0700 From: tip-bot for Arnaldo Carvalho de Melo Message-ID: Cc: eranian@google.com, dsahern@gmail.com, linux-kernel@vger.kernel.org, fweisbec@gmail.com, tglx@linutronix.de, jolsa@redhat.com, namhyung@kernel.org, mingo@kernel.org, adrian.hunter@intel.com, bp@suse.de, acme@redhat.com, hpa@zytor.com Reply-To: mingo@kernel.org, adrian.hunter@intel.com, hpa@zytor.com, bp@suse.de, acme@redhat.com, tglx@linutronix.de, fweisbec@gmail.com, linux-kernel@vger.kernel.org, dsahern@gmail.com, eranian@google.com, namhyung@kernel.org, jolsa@redhat.com To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf symbols: Add front end cache for DSO symbol lookup Git-Commit-ID: b685ac22b436455db9c9c16b384d7aa4531cdd80 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: b685ac22b436455db9c9c16b384d7aa4531cdd80 Gitweb: http://git.kernel.org/tip/b685ac22b436455db9c9c16b384d7aa4531cdd80 Author: Arnaldo Carvalho de Melo AuthorDate: Wed, 22 Jul 2015 12:52:17 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 23 Jul 2015 11:28:35 -0300 perf symbols: Add front end cache for DSO symbol lookup Acked-by: David Ahern Cc: Adrian Hunter Cc: Borislav Petkov Cc: Frederic Weisbecker Cc: Jiri Olsa Cc: Namhyung Kim Cc: Stephane Eranian Link: http://lkml.kernel.org/n/tip-voo94tow8wpkcc76mlkny6sc@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/dso.h | 4 ++++ tools/perf/util/symbol.c | 7 ++++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/dso.h b/tools/perf/util/dso.h index 2fe98bb..c73276d 100644 --- a/tools/perf/util/dso.h +++ b/tools/perf/util/dso.h @@ -137,6 +137,10 @@ struct dso { struct rb_node rb_node; /* rbtree node sorted by long name */ struct rb_root symbols[MAP__NR_TYPES]; struct rb_root symbol_names[MAP__NR_TYPES]; + struct { + u64 addr; + struct symbol *symbol; + } last_find_result[MAP__NR_TYPES]; void *a2l; char *symsrc_filename; unsigned int a2l_fails; diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c index 45c2e3a..725640f 100644 --- a/tools/perf/util/symbol.c +++ b/tools/perf/util/symbol.c @@ -444,7 +444,12 @@ static struct symbol *symbols__find_by_name(struct rb_root *symbols, struct symbol *dso__find_symbol(struct dso *dso, enum map_type type, u64 addr) { - return symbols__find(&dso->symbols[type], addr); + if (dso->last_find_result[type].addr != addr) { + dso->last_find_result[type].addr = addr; + dso->last_find_result[type].symbol = symbols__find(&dso->symbols[type], addr); + } + + return dso->last_find_result[type].symbol; } struct symbol *dso__first_symbol(struct dso *dso, enum map_type type)