From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux-kernel@vger.kernel.org
Cc: linux1394-devel@lists.sourceforge.net,
Clemens Ladisch <cladisch@fastmail.net>
Subject: [PATCH 2/5] firewire: cdev: fix another memory leak in an error path
Date: Sat, 26 Dec 2009 01:34:29 +0100 (CET) [thread overview]
Message-ID: <tkrat.22fe3865dde96d48@s5r6.in-berlin.de> (raw)
In-Reply-To: <tkrat.edaaa9d0f51812e8@s5r6.in-berlin.de>
If copy_from_user in an FW_CDEV_IOC_SEND_RESPONSE ioctl failed, the
fw_request pointed to by the inbound_transaction_resource is no
longer referenced and needs to be freed.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
drivers/firewire/core-cdev.c | 1 +
1 file changed, 1 insertion(+)
Index: linux-2.6.33-rc2/drivers/firewire/core-cdev.c
===================================================================
--- linux-2.6.33-rc2.orig/drivers/firewire/core-cdev.c
+++ linux-2.6.33-rc2/drivers/firewire/core-cdev.c
@@ -723,6 +723,7 @@ static int ioctl_send_response(struct cl
if (copy_from_user(r->data, u64_to_uptr(request->data),
r->length)) {
ret = -EFAULT;
+ kfree(r->request);
goto out;
}
fw_send_response(client->device->card, r->request,
--
Stefan Richter
-=====-==--= ==-- ==-=-
http://arcgraph.de/sr/
next prev parent reply other threads:[~2009-12-26 0:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-26 0:32 [PATCH 0/5] firewire: fixes, status update Stefan Richter
2009-12-26 0:33 ` [PATCH 1/5] firewire: fix use of multiple AV/C devices, allow multiple FCP listeners Stefan Richter
2009-12-26 8:35 ` Pieter Palmers
2009-12-26 12:01 ` Stefan Richter
2009-12-26 13:23 ` Pieter Palmers
2009-12-26 14:13 ` Stefan Richter
2009-12-26 14:33 ` Stefan Richter
2010-01-23 14:51 ` Stefan Richter
2010-01-24 15:45 ` [PATCH] firewire: core: fix use-after-free regression in FCP handler Stefan Richter
2009-12-26 0:34 ` Stefan Richter [this message]
2009-12-26 0:35 ` [PATCH 3/5] firewire: ohci: always use packet-per-buffer mode for isochronous reception Stefan Richter
2009-12-26 0:36 ` [PATCH 4/5] firewire, ieee1394: update MAINTAINERS entries Stefan Richter
2009-12-26 15:57 ` Dan Dennedy
2009-12-26 0:36 ` [PATCH 5/5] firewire, ieee1394: update Kconfig help Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tkrat.22fe3865dde96d48@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=cladisch@fastmail.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox