From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: cluster-devel@redhat.com
Cc: linux-kernel@vger.kernel.org,
Patrick Caulfield <pcaulfie@redhat.com>,
David Teigland <teigland@redhat.com>,
Andrew Morton <akpm@osdl.org>
Subject: [PATCH 2.6.19-rc5-mm2] fs/dlm: fix recursive dependency in Kconfig
Date: Sat, 18 Nov 2006 16:52:29 +0100 (CET) [thread overview]
Message-ID: <tkrat.c2d67cf7278af0e7@s5r6.in-berlin.de> (raw)
make xconfig says
"Warning! Found recursive dependency: INET IPV6 DLM (null) DLM_TCP INET"
Seems to be another example of how badly the "select" keyword is handled
by the .config make targets. Replace all occurences of "select" in dlm's
Kconfig by "depends on" and some additional help texts.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
fs/dlm/Kconfig | 20 ++++++++++++++++----
1 files changed, 16 insertions(+), 4 deletions(-)
Index: linux-2.6.19-rc5-mm2/fs/dlm/Kconfig
===================================================================
--- linux-2.6.19-rc5-mm2.orig/fs/dlm/Kconfig 2006-11-18 13:25:31.000000000 +0100
+++ linux-2.6.19-rc5-mm2/fs/dlm/Kconfig 2006-11-18 16:40:21.000000000 +0100
@@ -1,14 +1,22 @@
menu "Distributed Lock Manager"
depends on EXPERIMENTAL
+comment "DLM requires CONFIGFS_FS in section 'Pseudo filesystems'"
+ depends on CONFIGFS_FS=n
+
+comment "DLM requires at least one of INET and IP_SCTP in section 'Networking'"
+ depends on !(INET || IP_SCTP)
+
config DLM
tristate "Distributed Lock Manager (DLM)"
- depends on IPV6 || IPV6=n
- select CONFIGFS_FS
+ depends on (IPV6 || IPV6=n) && (INET || IP_SCTP) && CONFIGFS_FS
help
A general purpose distributed lock manager for kernel or userspace
applications.
+ If you want to link DLM statically instead of as a module, configure
+ IPV6 as statically linked too or switch it off.
+
choice
prompt "Select DLM communications protocol"
depends on DLM
@@ -18,13 +26,17 @@ choice
SCTP supports multi-homed operations whereas TCP doesn't.
However, SCTP seems to have stability problems at the moment.
+ Activate INET (TCP/IP networking) in the Networking section
+ to be able to use DLM over TCP. Activate SCTP in the
+ Networking section to use DLM over SCTP.
+
config DLM_TCP
bool "TCP/IP"
- select INET
+ depends on INET
config DLM_SCTP
bool "SCTP"
- select IP_SCTP
+ depends on IP_SCTP
endchoice
next reply other threads:[~2006-11-18 15:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-18 15:52 Stefan Richter [this message]
2006-11-20 9:48 ` [PATCH 2.6.19-rc5-mm2] fs/dlm: fix recursive dependency in Kconfig Patrick Caulfield
2006-11-20 11:45 ` Stefan Richter
2006-11-20 17:45 ` Adrian Bunk
2006-11-20 23:35 ` Randy Dunlap
2006-11-21 0:12 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tkrat.c2d67cf7278af0e7@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=akpm@osdl.org \
--cc=cluster-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pcaulfie@redhat.com \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox