[PATCH 0/5] SCSI and FireWire: fix/add START STOP UNIT for SBP-2 disks

Stefan Richter
2008-05-10T22:33:28Z

This series contains:

Patch 1/5...3/5: Some SBP-2 disks don't work as expected if the power
condition field in the START STOP UNIT command is not set. They either
don't spin down on start=0, or they become unresponsive after it. These
patches selectively adds power condition values for known affected
devices. We can't do so across the board because certain other SBP-2
devices have been found to not support power condition (even though it
is mandatory as per RBC).

These three patches should IMO go into mainline during the current -rc
phase.

Patch 4/5...5/5: Enable scsi_device.manage_start_stop for all SBP-2
devices (except if logged in non-exclusively). This lets FireWire disks
spin down on suspend, driver unbinding, or system shutdown.

These two patches are post 2.6.26 material.

James, how do we handle patch 1/5, assumed that this one is OK? Do you
route it through scsi-rc-fixes (or scsi-misc if really necessary), or do
you make an exception and let it slip through linux1394-2.6.git? The
patch applies to plain 2.6.25 as well as to current scsi-misc without
conflicts.

drivers/firewire/fw-sbp2.c | 25 +++++++++++++++++++++++--
drivers/ieee1394/sbp2.c | 22 ++++++++++++++++++++--
drivers/ieee1394/sbp2.h | 1 +
drivers/scsi/sd.c | 5 +++++
include/scsi/scsi_device.h | 1 +
5 files changed, 50 insertions(+), 4 deletions(-)

Stefan Richter (5):
scsi: sd: optionally set power condition in START STOP UNIT
firewire: fw-sbp2: fix spindown for PL-3507 and TSB42AA9 firmwares
ieee1394: sbp2: fix spindown for PL-3507 and TSB42AA9 firmwares
firewire: fw-sbp2: spin disks down on suspend and shutdown
ieee1394: sbp2: spin disks down on suspend and shutdown
--
Stefan Richter
-=====-==--- -=-= -=-==