From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753257AbcETFHm (ORCPT <rfc822;w@1wt.eu>);
	Fri, 20 May 2016 01:07:42 -0400
Received: from mga02.intel.com ([134.134.136.20]:33757 "EHLO mga02.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751199AbcETFHl convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 20 May 2016 01:07:41 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,337,1459839600"; 
   d="scan'208";a="970910560"
From: Ashutosh Dixit <ashutosh.dixit@intel.com>
To: Mike Danese <mikedanese@google.com>
Cc: "Dutt\, Sudeep" <sudeep.dutt@intel.com>, Jonathan Corbet <corbet@lwn.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Chandramouli\, Dasaratharaman" 
	<dasaratharaman.chandramouli@intel.com>,
        Mahesh Khanwalkar <maheshkhanwalkar@gmail.com>,
        "open list\:DOCUMENTATION" <linux-doc@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mpssd: fix buffer overflow warning
References: <1463720092-18470-1-git-send-email-mikedanese@google.com>
Date: Fri, 20 May 2016 01:07:38 -0400
In-Reply-To: <1463720092-18470-1-git-send-email-mikedanese@google.com> (Mike
	Danese's message of "Thu, 19 May 2016 22:54:51 -0600")
Message-ID: <tnm1tvb29z59h.fsf@phwtpriv05.ph.intel.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, May 20 2016 at 12:54:51 AM, Mike Danese <mikedanese@google.com> wrote:
> The compilation emits a warning in function ‘snprintf’,
>     inlined from ‘set_cmdline’ at
>     ../Documentation/mic/mpssd/mpssd.c:1541:9:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:64:10:
>     warning: call to __builtin___snprintf_chk will always overflow
>     destination buffer
>
> This was introduced in commit f4a66c204482 ("misc: mic: Update MIC host
> daemon with COSM changes") and is fixed by reverting the changes to the
> size argument of these snprintf statements.

Thanks for the patch, the fix is fine.