Re: 2.6.13-rc3: cache flush missing from somewhere

Russell King
2005-08-01T16:40:37Z

On Mon, Aug 01, 2005 at 01:24:04PM +0100, Catalin Marinas wrote:
> "David S. Miller" <davem@davemloft.net> wrote:
> > From: Russell King <rmk+lkml@arm.linux.org.uk>
> > Date: Fri, 29 Jul 2005 16:13:43 +0100
> >
> >> My current patch to get this working is below. The only thing which
> >> really seems to fix the issue is the __flush_dcache_page call in
> >> read_pages() - if I remove this, I get spurious segfaults and illegal
> >> instruction faults.
> >
> > If one cpu stores, does it get picked up in the other cpu's I-cache?
>
> It only gets picked up by the other CPU's D-cache (which is fully
> coherent between cores). The I-cache needs to be invalidated on each
> CPU.

Are you sure about this requirement? I see no evidence of it in Harry's
patch set.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core