Re: [PATCH v3 0/4] tools: Add a toplevel Makefile

Borislav Petkov
2012-03-30T16:15:39Z

On Fri, Mar 30, 2012 at 07:26:05AM +0200, Sam Ravnborg wrote:
> > $ make tools/<toolname> tinstall
> But this makes no sense.
>
> It would be better to be consistent - so the user does not need to remember
> when to add a space and when not.
>
> make tools/<command> where <command> is one of help, install, clean, "nothing"
> make tools/<toolname>
> make tools/<toolname>_<comand> where command is the same set of commands
>
>
> then a user could do:
>
> make tools/clean
> make tools/perf
> make tools/perf_install
>
> or
>
> make tools/clean
> make tools/
> make tools/install

This one I had hard time imagining: who would install all tools but I
guess it could have it's use...

> The install target could implicitly include the build target.
>
> With this scheme the user is up to less suprises.
>
> All the above are only minor adjustments compared to what you already did.
> bt the consistency here is a gain (IMO).

... but yeah, those make sense to me too, let's see what the others
think, Arnaldo, Ingo?

--
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551