Re: [PATCH v3 0/4] tools: Add a toplevel Makefile

Sam Ravnborg
2012-03-30T05:26:18Z

On Thu, Mar 29, 2012 at 02:25:53PM +0200, Borislav Petkov wrote:
> From: Borislav Petkov <borislav.petkov@amd.com>
>
>
> Hi all,
>
> yet another version of the toplevel Makefile integration of tools/.
> This round gives you the ability to build the tools from the toplevel
> Makefile (explanation below can be found also in patch 4/4's commit
> message):
>
> "Now you can do
>
> $ make tools/<toolname>
Makes sense.
>
> from the toplevel kernel directory and have the respective tool built.
>
> If you want to build and install it, do
>
> $ make tools/<toolname> tinstall
But this makes no sense.

It would be better to be consistent - so the user does not need to remember
when to add a space and when not.

make tools/<command> where <command> is one of help, install, clean, "nothing"
make tools/<toolname>
make tools/<toolname>_<comand> where command is the same set of commands

then a user could do:

make tools/clean
make tools/perf
make tools/perf_install

or

make tools/clean
make tools/
make tools/install

The install target could implicitly include the build target.

With this scheme the user is up to less suprises.

All the above are only minor adjustments compared to what you already did.
bt the consistency here is a gain (IMO).

Sam