From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A3373BED56 for ; Tue, 11 Aug 2026 02:55:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786416906; cv=none; b=XjNJCV/D/qtqm8uuKQlX9KGzuWvEELPJpqK0yKKz2Wk1wQaQ0aSGAN4vo5ZoraIcNW6pxxnUgDqP+9M/yKPflZJwRdreNEPeTyMGxMx5wsLI2PIaGr9w5AXalUY5Gc7E3z1SaU4vuVxbNr1SuDCPy+PjYYewVVmefW8m8JSSkrs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786416906; c=relaxed/simple; bh=YmfmUQLDb3l+7s1j1ocN2ORQuYUiCg/HyHTRArKEq6k=; h=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References; b=V8+FWN/6ZRJV7fMG1eUnTKofHkVWFFItenGoEEcojZLvRcWHvYsbgju/IB+AC6Gu5/Qycx5NNjvRQtkEMz6yyXokeMgU6PSbUYsE9Aq9KQMfXxQ/ZAz/SlER0vR0v5fwoe9/+IbNDU2d3HLQb+91t+EedlPv6RAY2p0epd1Yjgk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=De4Vz6+n; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="De4Vz6+n" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-38fdeaed181so3316667a91.1 for ; Mon, 10 Aug 2026 19:55:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786416904; x=1787021704; darn=vger.kernel.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to:content-type; bh=7f7P6+Mg6gW/zIFPZnZ9O0n8HYHX0J4ooE2hsII09M4=; b=De4Vz6+nBjxph8C49DQUHUViBTk9Sfkfbu57l1cEocM/xBcRkKb+DcX9vXWr1HZ7SD OzdeepwtEHJA+UvcwXWVkAZcHVLKct9DhsXDtwizsA4QnnhcPTWcIq0zdzSufSU5KpO3 aLPVZplZzw167UgFiA/gdMvx+n4R3FRUjRcNlLEcMEtuZXrePwxSpQbDdvJKGNdwgbI9 mDKk3NAhbLadM45jPLqzrDA8hKH4dLRjmDzn1VgpkzKbVX8NBNI32S9nZOiPRqR81JRQ ym+GSSb70RbGywq7ZJxeYUcC/328clScP1w/rJSrpQ+22gIsEp/gZm10+to+ERVq32/r 4bFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786416904; x=1787021704; h=references:message-id:date:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7f7P6+Mg6gW/zIFPZnZ9O0n8HYHX0J4ooE2hsII09M4=; b=gisBez24pswazxzmf0w1cJiJIk9+WmIIQP/qiP/Q35uTlfv4f0he0gSiaoiXduAiIT WGj1ZQcV8CzHUv6fa0MvCyqjM/6Vk9ETNC7vuY/ilUbzVj70caZ3GjaxmXx3rpqmswSR mIxyvxvXxbLakW9kN9vuLXvVlN4BesBOA/SzMIfvxSZV2cXuCJKT7BsvBWpG0D8ZO3Db uKnbuyOkQK31bbEC4Wjhp9J55pKst56/ClI8/0ovqDvGWYp1npxXvA/3oP+J5kwSTq81 rFu7gGBecAVf2/EULUKg06Ps6sy+8ZQT5fYuSsj6oySeYQIXWQFCi9E1e8bI5k9gAk7i n7MQ== X-Forwarded-Encrypted: i=1; AHgh+Rq89JhOlvQ+qswf4BXMcA87PCmyHRVeNsEOygRYQ5yAd1x2zFd/gA3B6wuouJG6dRj6cKGW1IQY/GRh4Ts=@vger.kernel.org X-Gm-Message-State: AOJu0YwYIaeGui8p+zTuIJkgbdVfs3Q8FEE6cOjVyHrOc3ASeT+Y0kGz 3gVYqSRzbDTrdHWNEQyzq+JC+GA439bqdN+cW3WX4kYAYIxR1L207Cdn X-Gm-Gg: AR+sD12s//bt3UMvLEqGr6nqxo5m/xtZU+A+HUn/JxGOjTNtB+hbJANknveCgpvpDF1 eUzkX0XKWQV7b8VQyV/CChEqZ5KHgd/tTR9X3f4L3GWpSeWB59IhgyEz1ke0ciidF3HZbwge4Af 2kf/4x1WmYiwT2eW3htcSe9qrNba89AA/pstDTfowAZypOzJxJrGwCFDsj25J6Hq5Bln2fzuknJ cVeUr7PQVEj49NGWvn826SfEyyBp5UJHitAAnQ9/6GzBbr8QH3sRcxGaorC59G4lxjNySkT+kco sfnmpozScPDOKYleGKgCgtXNYTTSRzfF5Fcy76uPRVjpm3j76y1mSQ0eBp8b0nAPW/AdxqFfuVp RxG3ASMksTI5eZ60YDBxJwAGoEzaOrD7lcmQHbSlJ4DN9c5ga8YmOAiIGL/+5CWOOqOtJp0Ynhm Y6PVPLiibW4vOTafu+w+8AEIPM7mqeFXxLdkKvHWTXdJbDXFqW6C73NfyKcn6LouyJwG5b388= X-Received: by 2002:a05:6a21:1fc5:b0:398:8870:b58f with SMTP id adf61e73a8af0-3cc2b872b58mr583456637.14.1786416904467; Mon, 10 Aug 2026 19:55:04 -0700 (PDT) Received: from pve-server ([49.205.216.49]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315bec128a0sm55473900eec.25.2026.08.10.19.54.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 19:55:03 -0700 (PDT) From: Ritesh Harjani (IBM) To: guzebing , tytso@mit.edu Cc: adilger.kernel@dilger.ca, libaokun@linux.alibaba.com, jack@suse.cz, ojaswin@linux.ibm.com, yi.zhang@huawei.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, guzebing Subject: Re: [PATCH] ext4: fix reserved group initialization In-Reply-To: <20260811021848.1821435-1-guzebing1612@gmail.com> Date: Tue, 11 Aug 2026 08:20:32 +0530 Message-ID: References: <20260811021848.1821435-1-guzebing1612@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: guzebing writes: > ext4 initializes the in-memory reserved uid and gid from the on-disk > default reserved id fields during mount. The s_resgid assignment > accidentally uses ext4_get_resuid(), so the reserved group is initialized > from the reserved uid instead of the reserved gid. > > As a result, members of the configured reserved group can be denied access > to reserved blocks, while members of a group whose gid matches the > reserved uid can be incorrectly allowed to use them. > > Initialize s_resgid with ext4_get_resgid() instead. > > Fixes: 12c84dd4d308 ("ext4: add support for 32-bit default reserved uid and gid values") > Signed-off-by: guzebing This was posted before [1] and looks it already landed in ext4's dev branch [2]. [1]: https://lore.kernel.org/all/20260727104103.28916-1-liujiazi@amazon.com/ [2]: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git/commit/?h=dev&id=c87abbab6147dcc5aa1fd8f2a61734d58d8b99ec -ritesh > --- > fs/ext4/super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ext4/super.c b/fs/ext4/super.c > index 245f67d10ded3..63de62a75a543 100644 > --- a/fs/ext4/super.c > +++ b/fs/ext4/super.c > @@ -5369,7 +5369,7 @@ static int __ext4_fill_super(struct fs_context *fc, struct super_block *sb) > ext4_set_def_opts(sb, es); > > sbi->s_resuid = make_kuid(&init_user_ns, ext4_get_resuid(es)); > - sbi->s_resgid = make_kgid(&init_user_ns, ext4_get_resuid(es)); > + sbi->s_resgid = make_kgid(&init_user_ns, ext4_get_resgid(es)); > sbi->s_commit_interval = JBD2_DEFAULT_MAX_COMMIT_AGE * HZ; > sbi->s_min_batch_time = EXT4_DEF_MIN_BATCH_TIME; > sbi->s_max_batch_time = EXT4_DEF_MAX_BATCH_TIME; > > base-commit: 06cf61899d6498b33e4b7c87d99d5bd471ccc375 > -- > 2.20.1