The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Vasily Gorbik <gor@linux.ibm.com>
To: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: Heiko Carstens <hca@linux.ibm.com>,
	Thomas Huth <thuth@redhat.com>,
	linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390/uapi: Remove obsolete unistd_32.h from Kbuild file
Date: Thu, 9 Jul 2026 12:16:37 +0200	[thread overview]
Message-ID: <tthwkjp@ub.hpns> (raw)
In-Reply-To: <f0bf4797-7706-477e-a99e-7c895bfa77c0-agordeev@linux.ibm.com>

On Thu, Jul 09, 2026 at 08:59:23AM +0200, Alexander Gordeev wrote:
> On Thu, Jul 09, 2026 at 07:57:15AM +0200, Heiko Carstens wrote:
> > > On repeated builds it results in:
> > > 
> > >   SYSHDR  arch/s390/include/generated/uapi/asm/unistd_32.h
> > >   REMOVE  arch/s390/include/generated/uapi/asm/unistd_32.h
> > 
> > How did you achieve that unistd_32.h is actually generated? The required
> > syscall table information to generate such a header file is not present.
> > This looks very odd to me.
> > 
> > The above should be impossible with current upstream code, and I cannot
> > reproduce it. Any chance you applied Thomas' patch on top of an old commit
> > which still includes compat support?
> 
> I can not reproduce it anymore of course, but I am pretty sure I was
> trying exactly that :/
> 
> > > A complete removal would require changes to arch/s390/kernel/syscalls/Makefile
> > > at least,
> > 
> > I don't think so.
> > 
> > > but we still  might want to have unistd_32.h around.
> > 
> > No, that doesn't make sense. compat support is completely gone, including all
> > header files. The patch looks fine as it is for me, but we need to sort out
> > what you reported.
> 
> Yes, my report is false. Sorry for the noise.

Maybe you have not started with a clean tree.
Anyhow, I'm picking up this patch then.

  reply	other threads:[~2026-07-09 10:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-01 13:47 [PATCH] s390/uapi: Remove obsolete unistd_32.h from Kbuild file Thomas Huth
2026-07-08 12:47 ` Alexander Gordeev
2026-07-09  5:57   ` Heiko Carstens
2026-07-09  6:59     ` Alexander Gordeev
2026-07-09 10:16       ` Vasily Gorbik [this message]
2026-07-09 10:42 ` Vasily Gorbik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tthwkjp@ub.hpns \
    --to=gor@linux.ibm.com \
    --cc=agordeev@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox