linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Li Hong <lihong.hi@gmail.com>
To: Ryusuke Konishi <ryusuke@osrg.net>
Cc: konishi.ryusuke@lab.ntt.co.jp, linux-nilfs@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] nilfs2: add a print message after loading nilfs2
Date: Thu, 8 Apr 2010 13:45:05 +0800	[thread overview]
Message-ID: <u2p3a3680031004072245t5ea476a5xbd6cbe6d3302de00@mail.gmail.com> (raw)
In-Reply-To: <20100408.113405.221629738.ryusuke@osrg.net>

2010/4/8 Ryusuke Konishi <ryusuke@osrg.net>:
> On Wed, 7 Apr 2010 22:20:58 +0800, Li Hong <lihong.hi@gmail.com> wrote:
>> Hi KONISHI Ryusuke,
>>
>> Any feedbacks on these patches?
>>
>> Thanks,
>> Li Hong
>
> Well, adding a load message is ok, but it should be more moderate like
> "nilfs2 file system loaded\n".
Yes. I just thought that printing a message after loading a file
system is a practice.
You may choose any string that you think is suitable :)

> I think this sort of change should be discussed in the sub topic
> mailing list (i.e. linux-nilfs).  You don't have to cc every patch to
> linux-kernel.
Ok. No problem.

> And, please include some explanation in the change log to clarify the
> aim or motivation.
I took it as a very simple patch and thought a header was enough. I can add more
explanations if here has a demand.

> Thanks,
> Ryusuke Konishi
>

Thanks very much,
Li Hong

  reply	other threads:[~2010-04-08  5:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-05 17:34 [PATCH 1/2] nilfs2: cleanup multi kmem_cache_{create,destroy} code Li Hong
2010-04-05 17:35 ` [PATCH 2/2] nilfs2: add a print message after loading nilfs2 Li Hong
2010-04-07 14:20   ` Li Hong
2010-04-08  2:34     ` Ryusuke Konishi
2010-04-08  5:45       ` Li Hong [this message]
2010-04-08  4:44 ` [PATCH 1/2] nilfs2: cleanup multi kmem_cache_{create,destroy} code Ryusuke Konishi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=u2p3a3680031004072245t5ea476a5xbd6cbe6d3302de00@mail.gmail.com \
    --to=lihong.hi@gmail.com \
    --cc=konishi.ryusuke@lab.ntt.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nilfs@vger.kernel.org \
    --cc=ryusuke@osrg.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).