From: Marcus Sundberg <marcus@ingate.com>
To: Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: "Gabor Z. Papp" <gzp@papp.hu>,
mostrows@speakeasy.net, linux-kernel@vger.kernel.org
Subject: [PATCH] Re: PPPoE Oops with 2.4.22-rc
Date: 22 Aug 2003 15:43:01 +0200 [thread overview]
Message-ID: <vezni16c62.fsf_-_@inigo.ingate.se> (raw)
In-Reply-To: <39a.3f392c6f.86e8b@gzp1.gzp.hu>
Hi,
this patch fixes one crash in pppoe_connect():
--- linux-2.4.21-rc2/drivers/net/pppoe.c~ Wed May 14 00:08:52 2003
+++ linux-2.4.21-rc2/drivers/net/pppoe.c Wed May 14 00:18:47 2003
@@ -606,7 +606,8 @@
/* Delete the old binding */
delete_item(po->pppoe_pa.sid,po->pppoe_pa.remote);
- dev_put(po->pppoe_dev);
+ if (po->pppoe_dev)
+ dev_put(po->pppoe_dev);
memset(po, 0, sizeof(struct pppox_opt));
po->sk = sk;
//Marcus
--
---------------------------------------+--------------------------
Marcus Sundberg <marcus@ingate.com> | Firewalls with SIP & NAT
Firewall Developer, Ingate Systems AB | http://www.ingate.com/
next prev parent reply other threads:[~2003-08-22 13:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-12 6:42 PPPoE Oops with 2.4.22-rc Gabor Z. Papp
2003-08-12 17:16 ` Marcelo Tosatti
2003-08-12 17:42 ` Gabor Z. Papp
2003-08-12 18:05 ` Gabor Z. Papp
2003-08-12 18:31 ` Gabor Z. Papp
2003-08-22 13:43 ` Marcus Sundberg [this message]
2003-08-22 16:54 ` [PATCH] " David S. Miller
[not found] <fa.fl74mr0.184m51s@ifi.uio.no>
[not found] ` <fa.k5266bj.136mf8l@ifi.uio.no>
2003-08-22 20:55 ` Junio C Hamano
2003-08-22 21:12 ` Marcus Sundberg
2003-08-25 12:57 ` Greg Stark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vezni16c62.fsf_-_@inigo.ingate.se \
--to=marcus@ingate.com \
--cc=gzp@papp.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=mostrows@speakeasy.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox