From: Krzysztof Kozlowski <krzk@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Loic Poulain <loic.poulain@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Andi Shyti <andi.shyti@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Todor Tomov <todor.too@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Jagadeesh Kona <quic_jkona@quicinc.com>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH 6/6] arm64: dts: qcom: x1e80100: Add CAMSS block definition
Date: Wed, 20 Nov 2024 09:52:57 +0100 [thread overview]
Message-ID: <vh6fvvminsq7eeovz6su336awgq56kc2r54mldmihgqxo2wkgt@wxciyxacp2ov> (raw)
In-Reply-To: <20241119-b4-linux-next-24-11-18-dtsi-x1e80100-camss-v1-6-54075d75f654@linaro.org>
On Tue, Nov 19, 2024 at 01:10:35PM +0000, Bryan O'Donoghue wrote:
> Add dtsi to describe the xe180100 CAMSS block
>
> 4 x CSIPHY
> 2 x CSID
> 2 x CSID Lite
> 2 x IFE
> 2 x IFE Lite
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/x1e80100.dtsi | 180 +++++++++++++++++++++++++++++++++
> 1 file changed, 180 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> index c19754fdc7e0fa4f674ce19f813db77fe2615cf3..f23352493cb270c0fdc3c42add032286601db1e9 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> @@ -4730,6 +4730,186 @@ cci1_i2c1: i2c-bus@1 {
> };
> };
>
> + camss: camss@ac62000 {
> + compatible = "qcom,x1e80100-camss";
> +
> + reg = <0 0x0acb7000 0 0x2000>,
It does not look like you tested the DTS against bindings. Please run
'make dtbs_check W=1' (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-11-20 8:53 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 13:10 [PATCH 0/6] Add dt-bindings and dtsi changes for CAMSS on x1e80100 silicon Bryan O'Donoghue
2024-11-19 13:10 ` [PATCH 1/6] dt-bindings: i2c: qcom-cci: Document x1e80100 compatible Bryan O'Donoghue
2024-11-20 8:49 ` Krzysztof Kozlowski
2024-11-20 14:35 ` Bryan O'Donoghue
2024-11-19 13:10 ` [PATCH 2/6] dt-bindings: media: Add qcom,x1e80100-camss binding Bryan O'Donoghue
2024-11-19 14:34 ` Vladimir Zapolskiy
2024-11-19 15:11 ` Bryan O'Donoghue
2024-11-20 23:02 ` Vladimir Zapolskiy
2024-11-20 23:27 ` Bryan O'Donoghue
2024-11-21 0:37 ` Vladimir Zapolskiy
2024-11-21 9:36 ` Bryan O'Donoghue
2024-11-20 8:55 ` Krzysztof Kozlowski
2024-11-19 13:10 ` [PATCH 3/6] dt-bindings: clock: qcom: Add second power-domain to CAMCC Bryan O'Donoghue
2024-11-19 14:47 ` Vladimir Zapolskiy
2024-11-19 15:12 ` Bryan O'Donoghue
2024-11-20 8:51 ` Krzysztof Kozlowski
2024-11-20 11:53 ` Dmitry Baryshkov
2024-11-19 13:10 ` [PATCH 4/6] arm64: dts: qcom: x1e80100: Add CAMCC block definition Bryan O'Donoghue
2024-12-02 14:27 ` Konrad Dybcio
2024-12-02 15:02 ` Dmitry Baryshkov
2024-12-02 15:30 ` Bryan O'Donoghue
2024-12-05 17:27 ` Konrad Dybcio
2024-11-19 13:10 ` [PATCH 5/6] arm64: dts: qcom: x1e80100: Add CCI definitions Bryan O'Donoghue
2024-11-19 14:42 ` Vladimir Zapolskiy
2024-12-07 11:59 ` Konrad Dybcio
2024-12-07 12:54 ` Bryan O'Donoghue
2024-11-19 13:10 ` [PATCH 6/6] arm64: dts: qcom: x1e80100: Add CAMSS block definition Bryan O'Donoghue
2024-11-19 14:44 ` Vladimir Zapolskiy
2024-11-19 15:14 ` Bryan O'Donoghue
2024-11-20 8:52 ` Krzysztof Kozlowski [this message]
2024-12-07 12:24 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vh6fvvminsq7eeovz6su336awgq56kc2r54mldmihgqxo2wkgt@wxciyxacp2ov \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_jkona@quicinc.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox