From: "werner" <w.landgraf@ru.ru>
To: randy.dunlap@oracle.com, greg@kroah.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: easycap needs smp_lock.h, fixes build error
Date: Tue, 30 Nov 2010 10:44:21 -0400 [thread overview]
Message-ID: <web-413291852@zbackend1.aha.ru> (raw)
In-Reply-To: <20101122121237.38cdd369.randy.dunlap@oracle.com>
HELLO
I dont believe this ... my 2.6.37-rc4 compilation gone bad
again, because of the same error, and I have to recompile
/ re-package it, what needs some hours again .. :( :(
The correction below worked on 2.6.37-rc3 (i.e. insert
#include <linux/smp_lock.h> into easycap_main.h)
WHY THIS WASN'T PATCHED SINCE LONG TIME ? Is the
situation of the kernel developers similar bad like of the
open office developers, so that they should be exchanged
???
w.landgraf
===========================================================
On Mon, 22 Nov 2010 12:12:37 -0800
Randy Dunlap <randy.dunlap@oracle.com> wrote:
>From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Add header file to fix build error:
>
> drivers/staging/easycap/easycap_main.c:4251: error:
>implicit declaration of function 'lock_kernel'
> drivers/staging/easycap/easycap_main.c:4254: error:
>implicit declaration of function 'unlock_kernel'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> drivers/staging/easycap/easycap.h | 1 +
> 1 file changed, 1 insertion(+)
>
> --- lnx-2637-rc3.orig/drivers/staging/easycap/easycap.h
> +++ lnx-2637-rc3/drivers/staging/easycap/easycap.h
> @@ -75,6 +75,7 @@
> #include <linux/errno.h>
> #include <linux/init.h>
> #include <linux/slab.h>
> +#include <linux/smp_lock.h>
> #include <linux/module.h>
> #include <linux/kref.h>
> #include <linux/usb.h>
>
>
"werner" <w.landgraf@ru.ru>
---
Professional hosting for everyone - http://www.host.ru
next prev parent reply other threads:[~2010-11-30 14:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 3:20 2.6.37-rc3 problems werner
2010-11-22 4:35 ` Greg KH
2010-11-22 4:56 ` Randy Dunlap
2010-11-22 5:13 ` Randy Dunlap
2010-11-22 19:47 ` Greg KH
2010-11-22 20:12 ` [PATCH] staging: easycap needs smp_lock.h, fixes build error Randy Dunlap
2010-11-30 14:44 ` werner [this message]
2010-11-30 14:57 ` Greg KH
2010-11-30 22:17 ` werner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=web-413291852@zbackend1.aha.ru \
--to=w.landgraf@ru.ru \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox