From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D695134889A for ; Mon, 26 Jan 2026 16:49:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769446172; cv=none; b=dP7c7axknF8hHJRafWlUBOmAnH4x87NU6i0S7dx0cLJW452K0Ii+ANhxYGCTi6UkJ4anODQDuszVX/M36A6kz07tcMXINTITHszfWh8D6ke/UptI0GFdV/j5qc1rSFA1QiGgeleaAsLKp5l4NOn/8TB7wUAWQKyI2o5GKwo/iBU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769446172; c=relaxed/simple; bh=uHcXECLSgsppVhP+AhoOZulbAbBN77UIUBU86+28NXw=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=PfEUsLy315PYZyzQ4qX94M4ylJEjxFex2hTVUD2SZLF8hlsYje9LxbHhxk3POBiRrSG8FcJVGM+oykRw4Fnpa88Pi7H25pABACDgu5T0k7QQVBJlG2sSH2z7ut1GosQo9besrIdP2kdrnJ6z+xenQE2ZQrHmkz2YqISsmAqYt7Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=C3VpYOpB; arc=none smtp.client-ip=209.85.128.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C3VpYOpB" Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-7927b1620ddso69028217b3.0 for ; Mon, 26 Jan 2026 08:49:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769446167; x=1770050967; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=CzIM5S1aosasnRgv4fpJy7hXx99GJuvBk4X/AumVJ6E=; b=C3VpYOpBYH6j/6Ogy6nYwz33PkgKdn7zoo8DV+MsAPUKDOmRisXtm82KK7zpBFotFd KG3HZbVdskGhXmgESjGv3ZEUogwzPyjOLe09etNtZJ5I8ENxG4Ec0XpevpkO8s6eIY23 Fq6bTrTjdxopBy4riRctLA/JUZn/LDLgm6ZFBGlSFzBLyjwAMr1fropAWpbywCnFobiX iYZDQxhrGKe8lXj9io+A/YUJTF2bXqxIlBtuPKe5oOzv7txsBTp4sXpGtj/phpq2Rc2H evXJsR49xTGdyULmbJqghynRdYxVPEfMLhE0EwS8/l05HSzQ5WHjvdXNqUsz25vXCCmL bhIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769446167; x=1770050967; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=CzIM5S1aosasnRgv4fpJy7hXx99GJuvBk4X/AumVJ6E=; b=Z8rnT8Jnf3xEaC8eOPTS+8cAIKMTFlZimoT0JNepoN834B75D95DKZWftNw6ayybKf folTQb9mTG7AxXvNkAYqNQEEmfl+VraO9k0e1UjyY5bvEgWaiBOAwVeF11odZiIY5JXr moSkwIKIptLPBblKwmA1ovHi93Lxj53vRdgckc9iApxQRbYa87sqxraBwaTSJs3uPjNR vLDdvg20IiaDqtDwl1dNEVsfKOibli1zycfTpLiFi2tOkflqf9g4OOoIeFOebh2k5jBN NFZFuZbngoJbFYN3nQXD8EFs6o8m3EVr6PcWpY68hLGM8z9xuPrp3fDtc1E6SnxLyfk8 ecjw== X-Forwarded-Encrypted: i=1; AJvYcCVCAHrekaUjAlbCFlcCOpj36BV/CgP5NUzZcwkCubh6BwTbep20yvg0Ahgc30/JGRQh3Sh/cIvknlHvipI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1Rk2zTc8qSd46dMut/LIjtrlZl58aSKApur4FbPBwL7zxeGZm KRr3GC1oy/lqdzS9t8fO+npW4NgIHoeSRaMBFMXCS3k6I8aJbmXSKkKU X-Gm-Gg: AZuq6aLXr4VtEypsYWYT6cmDfjIOPOHHghdtgoamo16XJOQazjgXx+oU/5sdD+qOo/s 9nom0VrfP6sNJ9fIGw1husMRuhV3xty2w9mCemhs1vixPVwR/ok2/vcaqizZHszZHC90zP2wZLL cIBlLUOA/j/cilLz0oZ8ZTxm1SdFskIzKiyjHaGuAphAM5sQ1MwJxktgUaZWwJOlfeghvXSKrkC YweRMXUDaIvcEa2apeigdZMhF9/l+1L2wiuO+7OwfvmB6fk0Bw1xYEefRukfPX53kCeT4p7OnzW 0g/hg2/bfy5LKdcGNUYxLPb3Izi0Czx2+ds4CzhGTGk/rjtt+adZNWyLidNChe4egvhsKafvFTg agpi0XGYGyvYiO7fAKvkV13GDkuKlaStSEPMM9DICFjw0j99H8AgVlc+uQWSOdYxYYrJsIIkKfQ dpajY6m9fUVlMhkhjqRYnUIoUhXq72TwNxrce/O9rVAqzKibEPkapN94rSdp8= X-Received: by 2002:a05:690c:6809:b0:794:107f:12b8 with SMTP id 00721157ae682-7945abe5d41mr35771317b3.10.1769446167253; Mon, 26 Jan 2026 08:49:27 -0800 (PST) Received: from gmail.com (21.33.48.34.bc.googleusercontent.com. [34.48.33.21]) by smtp.gmail.com with UTF8SMTPSA id 00721157ae682-7943b2b9bfcsm49990507b3.38.2026.01.26.08.49.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jan 2026 08:49:26 -0800 (PST) Date: Mon, 26 Jan 2026 11:49:26 -0500 From: Willem de Bruijn To: Jibin Zhang , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Neal Cardwell , Kuniyuki Iwashima , David Ahern , Matthias Brugger , AngeloGioacchino Del Regno , bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, steffen.klassert@secunet.com Cc: wsd_upstream@mediatek.com, Jibin Zhang Message-ID: In-Reply-To: <20260126152114.1211-1-jibin.zhang@mediatek.com> References: <20260126152114.1211-1-jibin.zhang@mediatek.com> Subject: Re: [PATCH v4] net: fix segmentation of forwarding fraglist GRO Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit [PATCH net v4] Jibin Zhang wrote: > This patch enhances GSO segment handling by properly checking > the SKB_GSO_DODGY flag for frag_list GSO packets, addressing > low throughput issues observed when a station accesses IPv4 > servers via hotspots with an IPv6-only upstream interface. > > Specifically, it fixes a bug in GSO segmentation when forwarding > GRO packets containing a frag_list. The function skb_segment_list > cannot correctly process GRO skbs that have been converted by XLAT, > since XLAT only translates the header of the head skb. Consequently, > skbs in the frag_list may remain untranslated, resulting in protocol > inconsistencies and reduced throughput. > > To address this, the patch explicitly sets the SKB_GSO_DODGY flag > for GSO packets in XLAT's IPv4/IPv6 protocol translation helpers > (bpf_skb_proto_4_to_6 and bpf_skb_proto_6_to_4). This marks GSO > packets as potentially modified after protocol translation. As a > result, GSO segmentation will avoid using skb_segment_list and > instead falls back to skb_segment for packets with the SKB_GSO_DODGY > flag. This ensures that only safe and fully translated frag_list > packets are processed by skb_segment_list, resolving protocol > inconsistencies and improving throughput when forwarding GRO packets > converted by XLAT. Fixes: 9fd1ff5d2ac7 ("udp: Support UDP fraglist GRO/GSO.") Cc: stable@vger.kernel.org