* [PATCH net-next] psp: add missing device stats to get-stats reply attributes
@ 2026-04-03 10:26 Daniel Zahka
2026-04-03 15:18 ` Willem de Bruijn
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Zahka @ 2026-04-03 10:26 UTC (permalink / raw)
To: Jakub Kicinski, Willem de Bruijn, David S. Miller, Eric Dumazet,
Paolo Abeni, Simon Horman, Donald Hunter
Cc: netdev, linux-kernel
Commit f05d26198cf2 ("psp: add stats from psp spec to driver facing
api") added device statistics (rx-packets, rx-bytes, rx-auth-fail,
rx-error, rx-bad, tx-packets, tx-bytes, tx-error) to the stats
attribute-set but did not add them to the get-stats operation reply
attributes. The kernel reports these attributes in the reply, so
list them in the spec to match.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Daniel Zahka <daniel.zahka@gmail.com>
---
This is a small fix to add the rest of the PSP hw stats from Commit
f05d26198cf2 ("psp: add stats from psp spec to driver facing api") to
the get-stats reply attributes.
The pyynl cli tool does not use these attributes for parsing
responses, but other tools, like the ynl-cpp tool, do.
---
Documentation/netlink/specs/psp.yaml | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Documentation/netlink/specs/psp.yaml b/Documentation/netlink/specs/psp.yaml
index f3a57782d2cf..100c36cda8e5 100644
--- a/Documentation/netlink/specs/psp.yaml
+++ b/Documentation/netlink/specs/psp.yaml
@@ -267,6 +267,14 @@ operations:
- dev-id
- key-rotations
- stale-events
+ - rx-packets
+ - rx-bytes
+ - rx-auth-fail
+ - rx-error
+ - rx-bad
+ - tx-packets
+ - tx-bytes
+ - tx-error
pre: psp-device-get-locked
post: psp-device-unlock
dump:
---
base-commit: 269389ba539834ec80e4d55583fca2cd70e4dc9c
change-id: 20260402-psp-yaml-fix-20661f0af865
Best regards,
--
Daniel Zahka <daniel.zahka@gmail.com>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] psp: add missing device stats to get-stats reply attributes
2026-04-03 10:26 [PATCH net-next] psp: add missing device stats to get-stats reply attributes Daniel Zahka
@ 2026-04-03 15:18 ` Willem de Bruijn
0 siblings, 0 replies; 2+ messages in thread
From: Willem de Bruijn @ 2026-04-03 15:18 UTC (permalink / raw)
To: Daniel Zahka, Jakub Kicinski, Willem de Bruijn, David S. Miller,
Eric Dumazet, Paolo Abeni, Simon Horman, Donald Hunter
Cc: netdev, linux-kernel
Daniel Zahka wrote:
> Commit f05d26198cf2 ("psp: add stats from psp spec to driver facing
> api") added device statistics (rx-packets, rx-bytes, rx-auth-fail,
> rx-error, rx-bad, tx-packets, tx-bytes, tx-error) to the stats
> attribute-set but did not add them to the get-stats operation reply
> attributes. The kernel reports these attributes in the reply, so
> list them in the spec to match.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Daniel Zahka <daniel.zahka@gmail.com>
Acked-by: Willem de Bruijn <willemb@google.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-03 15:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-03 10:26 [PATCH net-next] psp: add missing device stats to get-stats reply attributes Daniel Zahka
2026-04-03 15:18 ` Willem de Bruijn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox