From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7584A1B3925 for ; Sat, 11 Apr 2026 06:11:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775887866; cv=none; b=KHpN2deJ9AI0MLc0j9FeElPuHVEBjVEAebVKHUy0cq/9dOki14nWOXEnpEvKSMQL/Q4B1SGvZvX/AoF1HIXw7IApvZaPd/jkutRG3+kHemJCbgXuhXcR/fYc+YxyMavU5UMBsTed2qp094+lmTP0JnCPPWpbaz/Urj1i+hociIY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775887866; c=relaxed/simple; bh=cYL4j3V4ytdXyZuUC7kV8oR2EFEG33w0zTt0g1Ke2Mo=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=ZRcqk49Hx/4l0QqELit1y3ifL+/Qa7NX+ea8Vj9VphtyGbJj3PYGbS1wyVmImvBbh95lJgRFsTCr9O6l3YuD7Q0tmWPhDSNGDkZuAguI7O5IjTdl+p8D5LyLwkI+aYYvD3mtJGRtn61VSTUaJre8ZkYWTOIsa5moM5Zbbxv7Swk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fHqy0YZf; arc=none smtp.client-ip=209.85.128.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fHqy0YZf" Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-7a299d84b7dso20293297b3.0 for ; Fri, 10 Apr 2026 23:11:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775887864; x=1776492664; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=C/eTqprS95K8wlJFF8+XPts5K73Fqnj28VTy+rHT1rA=; b=fHqy0YZfOrFx0++GBzITpAJRe1dwa/6F1o9uCZinBD0eOozbaihDEGurdGwhYEM+xu jIAv0QlCGepim1HP9pFA2NDnycUwTYaSokgMxtE4WFIgqoTpjUMB7Ph8Cn/NfcxiruWu tHZPrU+0HHhjpFzUujeI8cPSQhqXQrrlKUT7K7nZypE9Yv+HSZ8WxY+8QzvpFJIofE89 +X2o2knUwIe/Spa/O3TYyPrmIS4tZj/qm1ieYYHpyM1cnN4ipgOKqlwIirHKOFYW3IFM 0x2iVstgu7SobbmNPZx2KlvbO12Fl5B/NOcXDLGb+tiJWYtRxqqVjsmUWE3WaQi6a8/j z0iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775887864; x=1776492664; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=C/eTqprS95K8wlJFF8+XPts5K73Fqnj28VTy+rHT1rA=; b=lBerAlUVs79LahEv7glrp/nDNpDQgbQHIaoSBRjECLFVniF6vyKTWazz/I13KNPR1e qjGPMV41sfQ46a6EHWjacumriFG48LEkMRpgm3irrReEs2GGjwGRVOrHX2OIZwjOhQGr Wka2NcJesctlEnLcwRtlsVe2B8FMeDayz8wbujVTzuXuGIxVnGfvYUBBG+CgU1/LpeYT GVyjK3jU2+X5SloV0/WYGT9SBLbLFjQAYLkN/8OVVkM/IqQ+tu8Evjf2yeM81S4HJFE5 Vhre+HJnZS6ihJ7QuPX/zsn7YXgUb/4E4upvHBopoQhmzQQg5+7E9Bwb0b4mp5YzP5TL gjrw== X-Forwarded-Encrypted: i=1; AJvYcCV8fD+jSAgjTOL6C/WSgC2amYRN3EQrD1EIyBxutdEurwUZbwJCaE5EFY6sm+ILp7Fpxu8I6hl5GbgSUtw=@vger.kernel.org X-Gm-Message-State: AOJu0YzIsiS7ISr7wRmJVPXYab4XUrTA1yFycp4g2QKOD4L6UHKMfK+S 4Ae3GWUYpbDPvSqj7E7JktM1jCe5kNemMiQ0Y5He8d/YSG4EeTaedDGb X-Gm-Gg: AeBDiet74hM5XKeVX4fuAAkqpjiMYsXwDrZ/2mBVHxhi3pyLpzrLL1pgyOi8hnZsq8O hcpYKGDZktHyMJRDepFOGReod4iqMkpgQMQihmsrinDlxFB3HCo4BvK5O6x0EdVmBGov+UsdmFW 55SFXM/WjMuUS93Wl6ChP17V7NSI1/LheIstA6voyebB9TlfRtrotmBYpIbZKZEmnJG+8VP8tKX wGhGarFZJxsr3GFwY7CXwB/2662hTxbMvkjWuYGUuEbRdRP8sROh3LWHRvCOmZhmmf/GQCvN/j9 v47eGG+pXM7jSaefjW0wZPClfsKcxSTLTtm/bBslakphITBlz9+/Cn2Gli5pkGzONy2gAE3poff Jpglem14CpkfTOPAqYKmHkWQICDMlQvZHidBIUKFa6ET/rFUnHC06afCGI14urxV+5ZB0yqPnyX eNgw3nlCwT5ge3cEC5CNM1FoEww8Nh2WUAwbSs0w6K9+GrJ3hTf8+0zfYh0vO/tY7V+SzBvHS2n ve5 X-Received: by 2002:a05:690c:e3cd:b0:794:cef6:64ee with SMTP id 00721157ae682-7af71b53a6emr62867087b3.41.1775887864494; Fri, 10 Apr 2026 23:11:04 -0700 (PDT) Received: from gmail.com (172.165.85.34.bc.googleusercontent.com. [34.85.165.172]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7af3c8deca7sm24992327b3.3.2026.04.10.23.11.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 23:11:03 -0700 (PDT) Date: Sat, 11 Apr 2026 02:11:03 -0400 From: Willem de Bruijn To: Jakub Kicinski , Akhilesh Samineni Cc: Willem de Bruijn , davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org, willemb@google.com, daniel.zahka@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jayakrishnan.udayavarma@broadcom.com, ajit.khaparde@broadcom.com, kiran.kella@broadcom.com, sachin.suman@broadcom.com Message-ID: In-Reply-To: <20260410135736.4bc7ed46@kernel.org> References: <20260406222305.4111170-1-akhilesh.samineni@broadcom.com> <20260406222305.4111170-2-akhilesh.samineni@broadcom.com> <20260407180432.102073cf@kernel.org> <20260410135736.4bc7ed46@kernel.org> Subject: Re: [PATCH net-next 1/3] psp: add crypt-offset and spi-threshold get/set attributes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jakub Kicinski wrote: > On Sat, 11 Apr 2026 01:06:06 +0530 Akhilesh Samineni wrote: > > On Wed, Apr 8, 2026 at 6:34=E2=80=AFAM Jakub Kicinski wrote: > > > On Tue, 07 Apr 2026 17:37:41 -0400 Willem de Bruijn wrote: = > > > > PSP defines a 6-bit field in 4 octet units. Does this need bounds= checking? = > > > > > > More fundamentally, were we to support this -- is it a device prope= rty > > > or an assoc property? = > > = > > It's a device property. All associations under the device will share > > the same crypt-offset. > = > I don't think there's anything in the spec that says the crypto > offset is device level. > At the very least every L4 proto may want to have a different offset. > We should probably hold off adding this until a real user appears. On how it is configured, the spec says "The crypt offset can be specified by the transmit descriptor or by configuration". So some devices might indeed selectively set it per-packet, e.g., for specific protocols. One real use case is network telemetry, exposing the inner transport protocol ports. For that to be useful it would have to be enabled on most if not all packets.