From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92E262EBBB9 for ; Thu, 29 Jan 2026 17:17:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769707041; cv=none; b=WBzqT+d+aI5pZoj61sL5ei0TqIioSmJC3CmE4cCMfeFSPhHygV1FgPRqZie4YVmhrF778ca5yFA1f/3gKFNoa2qvvpLGRGe54v3+Jd0/GKj0oYtdhWQzIXiV6FZcQjhlsfV7MwJkjYHQqp2aYv4W9tnCPG8kd1epe6EdZ1c5XV4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769707041; c=relaxed/simple; bh=ZsEGzLjdbDVM4FWUs5Kqag0d2mXtAN4mUc8ahPmKLWA=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=N8pRcnDjFzPoYwpbM/b5eK2BtUSKthh+P2fZzJK20aYww3AGwy7l77NNtt5EHENzkaRbZoAbSwGXvGdi+Fl6+AVKPa5x9ipHNhKCKrV9EvDFPtEmFUWPLMMdqNCrIemWXAVoHqqdEhUMZW1xSjQ1OF4bBH2Fg2/pMIT4jSr0d84= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TnlGX8z7; arc=none smtp.client-ip=209.85.128.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TnlGX8z7" Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-79088484065so11090367b3.1 for ; Thu, 29 Jan 2026 09:17:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769707039; x=1770311839; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=q6HQv96L/OmgPy5YAt71t2IgfEvjAD3Iexzh66ZQuW4=; b=TnlGX8z7uaCAzfRjQAp9unkn9d47nULfG1GNVnLiQh9YPNB7FkT0tiU3QD4Nrt27IN IKt1Yep6bxyxg5BaHEvZ88JAHLAIfBlhdl1hOpwGBH+FW64yjY5HrNtLlYUsegkueEUo w+X6LBDmu5pXysAG+kmxPFUjE2SrHIs0zcT9E9ID6NsAs/WZCpTSt5KaBDQScKOzOwAk DMjswov1NH/TgvNlKnnJzvO7j9Z8uOrLb5H2xVCyMGUJ8PHGzbi5veG/dYPqMlgRAWur +zcDTB+iuEdECMMPqeTzC/GbPWFGOw8qXrTBZHnKdyLtpFOp/xGKW7mEW2F0gJptLsvq TlQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769707039; x=1770311839; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=q6HQv96L/OmgPy5YAt71t2IgfEvjAD3Iexzh66ZQuW4=; b=jzQWu3CfhRfkoryt2zOYpdV9A/DtVqeQgnZ4Hb5XAppyPKtzvHfw9yeafnQoKgGBH8 eN/CkkM5M0/JZiWi6U1ChOiIrJo77vGQGN1p+LEYJT3NN0U4FZCYC6kaFSfR9KOE0I9K calAzM2LdFI0FJSS+GKPef/GXUWt/vSeMXPgpAw91rQDlrV0PB22GT5vphQJI5Y9T0gF LQAAG3VM7e/6K45M3bpvGMe6Q+/T9TPECCi2DEus4VD71u29Xh4fC4HTxprDDq6OUnsx DHVkVgShISXtH3VR0KGdHfYh8lkPXv9sSAPSFytU3PaxONFzNMVapZuHl3lhqjKKsG+L sz0g== X-Forwarded-Encrypted: i=1; AJvYcCXPvVpBwTmFwr/1AsvNpVl6VuLfVKAq8iBw2ubucUDoCH+nCIJjq3aj8bntl3kfn2Wrw7g86W3CnBOe/mA=@vger.kernel.org X-Gm-Message-State: AOJu0YwckmM5Y4qRsok+ucEypYdVdwANP499bhTaeEHW/ypjYTVoN7zD fZNp8xQy0mnMjDhVhLJokxSAXuZi5kCtZEcl1e52xjGdo86rUZgv+1Kd X-Gm-Gg: AZuq6aKfKD0svD0Vn2uhIpSQgCSRNiGvj1j0f0eOsydxIBAVHwwyr+cvG9Fwfmm6//O /riZTewRMJZNeKMg/1JKmV9Ty1vJVX7B2IF1mrGvEQmk/I16YsyS+qc7pBw5F4WQb4IOP113bnW fyAy7D8CTnferOzGJRa57N8XCvF+k1tqa5MaWNK37VslQjQ0ctjKHwZS4wfmBgO6kRk6ZLdFouY K4J4g/mZqLgi9XpmRvNxcCqoBXrV6BbZJp8BXd6ehteQWIF2F+57TeJg6nWVItaPt8ZMFR4KfNw EzMWJ0n3vSbaK+aoGnnEOQ2BBXMJ8jpvXipVmECX17LNJKFeV3mmambeSgvh84djGktgI2GPSc1 KVaDOOsFAQsTSnfDzcOhzmBxrLCItzkh/90L4yRTIZ57cWQHVA9eoA3ch0LnPqaFeBW21614pTW eDzz9XrqKk8E/Iv+q5tEvCwf2kRgVsXGu4C87MziCf15PqaqSYMPgcYaefs3iWpukl+4MLyg== X-Received: by 2002:a05:690c:dc8:b0:789:3166:25a7 with SMTP id 00721157ae682-7949e04c6b0mr5054917b3.46.1769707039341; Thu, 29 Jan 2026 09:17:19 -0800 (PST) Received: from gmail.com (21.33.48.34.bc.googleusercontent.com. [34.48.33.21]) by smtp.gmail.com with UTF8SMTPSA id 00721157ae682-794828f75f9sm26817347b3.53.2026.01.29.09.17.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 09:17:18 -0800 (PST) Date: Thu, 29 Jan 2026 12:17:18 -0500 From: Willem de Bruijn To: Mahdi Faramarzpour , netdev@vger.kernel.org Cc: Willem de Bruijn , "David S. Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , linux-kernel@vger.kernel.org (open list), kshitiz.bartariya@zohomail.in, Mahdi Faramarzpour Message-ID: In-Reply-To: <20260129083806.204752-1-mahdifrmx@gmail.com> References: <20260129083806.204752-1-mahdifrmx@gmail.com> Subject: Re: [PATCH net-next] udp: add drop count for packets in udp_prod_queue Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Mahdi Faramarzpour wrote: > This commit adds SNMP drop count increment for the packets in > per NUMA queues which were introduced in commit b650bf0977d3 > ("udp: remove busylock and add per NUMA queues"). note that SNMP > counters are incremented currently by the caller for skb. And > that these skbs on the intermediate queue cannot be counted > there so need similar logic in their error path. > > Signed-off-by: Mahdi Faramarzpour Reviewed-by: Willem de Bruijn