From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f49.google.com (mail-yx1-f49.google.com [74.125.224.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB6B643CEED for ; Mon, 11 May 2026 17:01:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778518873; cv=none; b=Fe/+RH5+GYus5r5rnDpySpyC6QdXBaSFoDZOAJo77R5hzjryTQNQetm6ww7jw/Yctg4W2wnogcEktKpyU1MvTAEK5X4i9u3TQmKuNUiBaSCw3EmLAGCWXKOVKy2XTFbe2bxtQZiVTCYXSyZS33j/VLC12O71P1dkmxHE1uAjKHI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778518873; c=relaxed/simple; bh=iUUlpAucA/dZnek3XV6McEL9wHLXl5lrA2H26lKle70=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=HFh7+8L+NoycDKxLtZJIr2PB+JrNpBvVnZng8UtSqQSYclEmJVULb4Zr3M7sfnEQVIUJ2Nhf75Hhv0QZsfvAndAawBv9aJGpva79uZSgL/pQncjnumlEtTDXesWQH1OvAKNIlcZSLsjOXU57T8oJmrKcSe2BwoHjmTYcmNpvuTg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LldmztCI; arc=none smtp.client-ip=74.125.224.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LldmztCI" Received: by mail-yx1-f49.google.com with SMTP id 956f58d0204a3-64d5a7926cfso4182380d50.2 for ; Mon, 11 May 2026 10:01:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778518871; x=1779123671; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=fSFIFik1v36Q4UudkAaCYemmrKRYJBnkinCt0aw47nU=; b=LldmztCI6pAOLWUa9kIiz+d3VakIUT+qHrb8cqTit4HuVSdzXwle30fTWN3hw6gR7P Gyr+C1FrtPFNSydITGVon6quW1gP/TM2E8KHLffZy8NMI4KhnBtn8ipdiLuPkidp9yH7 MdhQmW2aEmA76TC7nDxclfgXOAcAT/SMfKfQ8gEFO7UgLp98Mx9XnDyEfiWHOSlmKmx6 AGxEZN+gQzeGkMGZSnyVECGiueRUZed3pgahW5OqwAP2LNw2du95K7JJcYHDKaBkxIUy tOSL2JMTvrVpDUNWHv3ndXe9Q3Oj/J9Nq+1MpaedyyyA4nAgwg6qivF872xS+dQy6pr2 PuHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778518871; x=1779123671; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=fSFIFik1v36Q4UudkAaCYemmrKRYJBnkinCt0aw47nU=; b=Ooz5uPDufwL8U2WCVURx/pvR+OWMB4QAaDkPLQUyDSsw3sYkFmJ3aU6G7cBzHQPdDI m8eIlHiG+7nWqESDMbwice5HDBxoeVxdJxQfUASnO0eSmBWk6FenWBVFeLjdVTjuYaeX V+qLJA+lSVlFZ0t3BCIGhxOVxhH2WDC7s3ewHpxkosB/+X4cTzVBJRRmPsYpOUAMFqo5 SD2cqepFCqfej0y0eXVydd061iR1arlHVQbjEuXydqYcPr/w01wui39QpkrntJ2DMmo8 asRJSVOgHAy2mQjfpF5O0ERwilCSa6xNnLd0r9wtrr4qXcAieB6jEl+2PbLjiv2kCc2k mOpA== X-Forwarded-Encrypted: i=1; AFNElJ8rHf3PdezXTlrXpGpeNNs+7bXaOwtlN/ot3GwGJhZRG5IqGzqlS/VyKlkA4bultIACtDHRn8BCNAfxKVI=@vger.kernel.org X-Gm-Message-State: AOJu0Yzi1I+saIQ3QtYcSXOlegR7e0vnMvL1t3bJxEWtbFS/i3j5RUDq 8qEaw4HVh5+NH1S3ok1s9baQYkhs0lgeRU0mTR+coNMC+rQbmhq0lOUW X-Gm-Gg: Acq92OGCxYJqM21DR7Zor570URpuRatPKH+Ikm4SrqgCwnnxzCGyhR/K4+ZFuqDMrRC IF2soe6gLwOQWCqA/g7u34JCDA2VXDaDfmQrfE4hS9qRnocuYEOgVT6eedo8XLzf3KoHXmOX5zU XFboj18gO2XMHMErdhmHW7GkyWws5GNCkkRSYvR3ORr1mXbVM3XcnZSDHnX5m+FhoJ8PkLlJiT5 s+xhit7Kigm676z3XkyjcB6Jrn1jyfq54Wbm6aJrBs9+QRoHOng1kZcEaIGpEguCXsz88buhiiO SKbUeNSOIsL3qUBMbIzYBr4WiT/z8l5cXdPfRCaIULZ0OivkHKJvXGHxmjrr5bY4C8OKVhfFu5+ Lk+9Ttj2Uw6Nd7CV1MGrOdV0YDKwAH2JergUaq3Mev2c8DQ92C6BIGsvE9PlinQwJTvuS61gYg5 15UA6ylV1/M3Eh1ku5QiPg6oRWIHIuKelwCCQrJmV7plwzDHEyiLiDKBaO+1HufNogPs10MT4i4 5BXWmHxf7v1818= X-Received: by 2002:a05:690e:42cf:b0:654:5d65:9fe1 with SMTP id 956f58d0204a3-65c79ad7682mr17440383d50.8.1778518870017; Mon, 11 May 2026 10:01:10 -0700 (PDT) Received: from gmail.com (172.235.85.34.bc.googleusercontent.com. [34.85.235.172]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-65d96baa3a6sm5563191d50.13.2026.05.11.10.01.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 10:01:09 -0700 (PDT) Date: Mon, 11 May 2026 13:01:08 -0400 From: Willem de Bruijn To: Daniel Zahka , Jakub Kicinski , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: In-Reply-To: <20260508-nsim-psp-crypto-v1-2-4b50ed09b794@gmail.com> References: <20260508-nsim-psp-crypto-v1-0-4b50ed09b794@gmail.com> <20260508-nsim-psp-crypto-v1-2-4b50ed09b794@gmail.com> Subject: Re: [PATCH net-next 2/6] netdevsim: psp: remove unnecessary UDP checksum computation Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Daniel Zahka wrote: > The PSP spec requires the implementations accept 0 checksum in psp-udp > header. Let's take advantage of that to trim netdevsim's psp code > down. psp_dev_encapsulate() already sets uh->check to 0. > > Assisted-by: Claude:claude-opus-4.6 > Signed-off-by: Daniel Zahka > --- > drivers/net/netdevsim/psp.c | 32 -------------------------------- > 1 file changed, 32 deletions(-) > > diff --git a/drivers/net/netdevsim/psp.c b/drivers/net/netdevsim/psp.c > index 5073bda60883..75740e2a731f 100644 > --- a/drivers/net/netdevsim/psp.c > +++ b/drivers/net/netdevsim/psp.c > @@ -1,8 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0 > > -#include > #include > -#include > #include > #include > > @@ -81,36 +79,6 @@ nsim_do_psp(struct sk_buff *skb, struct netdevsim *ns, > skb->len - skb_inner_transport_offset(skb)); > u64_stats_update_end(&ns->psp.syncp); > } else { > - struct ipv6hdr *ip6h __maybe_unused; > - struct iphdr *iph; > - struct udphdr *uh; > - __wsum csum; > - > - /* Do not decapsulate. Receive the skb with the udp and psp > - * headers still there as if this is a normal udp packet. > - * psp_dev_encapsulate() sets udp checksum to 0, so we need to > - * provide a valid checksum here, so the skb isn't dropped. > - */ Perhaps this was here as IPv6 does not allow zero checksums except for tunneling in specific cases (RFC 6936)? It seems benign enough to keep the code. Do you have a specific reason to remove it, beyond reducing LoC?