From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13F0030F95C for ; Wed, 6 May 2026 19:30:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778095811; cv=none; b=LF3E9blIua+iBfizCmA1JLEZGxTnQNTerkKtGag9JLndWcIvCkQYrx+7r5AsbBxaWsX6FqxGl6sts2IiX72QeMxgmYq+qnuPM+cjrnmLKTkOyPSvPcvPXnp+4MNh1f6NEMVGdt8b3z5wz/3tNuMRs5pBOxqc6Je74z1dvd67yTg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778095811; c=relaxed/simple; bh=T/Z0ue1NjRjnHIwvygpPdlK10J9GktOfORG2BaFoOP8=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=Cg3Z3TcgXc94unohgxWgozuHGJvRD+WGeNoMt4qiP/KoaWcfsYxQya9QbC8k89lech3KUXIuWLial9tpK74kNYNrcozwvrudAdScq2wppWnBV2DAelmLXAUloWJZsXS1o9y7TnQyg/AXPls+rzjRR/yJbC3ga88nCMz6uiysUUo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OyCe8NJD; arc=none smtp.client-ip=209.85.128.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OyCe8NJD" Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-79a2ee65171so6397b3.2 for ; Wed, 06 May 2026 12:30:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778095809; x=1778700609; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=/PObqSo3yI/weBtZ6Fr+3JYSL4ynGoc1gJ3FrdqU23g=; b=OyCe8NJDhKG+n/pZc7dWnp6m1nfSIu5MPq33xP3SCXVD41LLstakkV96WP+zY5de6O 25dhc67NFcBvrfVVPH6tEQXqWs86SNPz8fORCJtulgTzKpMvktzGdX4u7awITY6oYeBS vmSXd/BH3eh+I/8cPIflDI/9khdlPvFhujWBV77O4Oi+OsVTKLwpMX5sQtKcaqYlfFGg YDVC98oUi7kd35TRd4mkou1ztHlccc2zGw6o5iKKHerwZSMvtBtkZyWmx/GCkWZ1CGGj jJVNPqeU9b03yEnt7Kdcn9wudIS7lPfBqi/tj6Q0n4qTxglMk5eSl00edsIO80fNYV6p Vg5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778095809; x=1778700609; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=/PObqSo3yI/weBtZ6Fr+3JYSL4ynGoc1gJ3FrdqU23g=; b=Ji2T0F2Glvi9iPn4gQYYgR3nEE2WT+gaSlgYpBFW5EvC8kRrzIBCg9a9siPOdwYcZR IdcspiePXcxB/L5GCGQNBNF4e/0JqDnsFBSW7mYe0RIRw2aovdmMBXABDQX6HOI7KKZe bwMW3m+D3JdiKBigJ+FJysfJZI+yC/BQi08205ZMWn2XwiYdsptYYXZStnPuYNcvrXhg OM9tGghIXhqaLQAKILhavVpTXSAMHQw+jNOUIwWKxOJe9PxkwPBjLJkA4llY3NjLYhS2 ZlOGeuwUAMicglHPfd/MAYJpER1fy7cqXch158BYX0rFAwhXEv0cTcNC67JJZGE9iSLe xPKQ== X-Forwarded-Encrypted: i=1; AFNElJ+yPKf31kbeNEuKkoT99fWo9XFC07tIjFIfCfVe6BqK8ds1Hoch8ZFAZaRHkTwMB+uNvR3xwyJt95j2ZSA=@vger.kernel.org X-Gm-Message-State: AOJu0YyB8800yeyFnqfUeuzzSknGE0nnHDX2Pud3SOeSrOED1CjYfvdC LSNbDWt64KIEzTZssuJ6oN+gJtT0KY2xSQaFkJH29KbBiGuChk+n/5re X-Gm-Gg: AeBDiet4TRbHWWZMqRlMDb9Fr5DypF4piXYWG3tQqJJEjOtAB7cZ+iwFrdceDK8K+JS 7dCYZgS51Jw6xChsXyHh1GjxR4W+25HZIABc/8xb1ePntixyTsjFLbSCbHEGnq9pn6Qt2sSxX17 Qll4W+HgBiJ1UKvTmZBilJwLwPFcRQme5wzQgOFQRwPypvFDb2KOh91roJXHfU8pJByknKySeg0 5n9h/2ut2skDk3zj5uTIAHgH5jsSaxTcqpAsECDvUELK4r8GkF6Pw9tfrzxomrZnsPrIzfSJbCC qoK2nTXFS2vh9mfNPIkw+NUzt0C7A7teoKaQhT7KyL3FAvlFVmakGFQ+twQARKiK8SyNi6Smxe2 VslyyH3EQH+aXfkUP/yquMzupusB4PP2jtVlJDD2ZFcup3BTh3lxwzr1o2Z6aVO98hZqNGQv+Ma KoAPtwHoiC9p1J+B+R3wciaGHxjhZCDHnESuvrMNZxp9QC4kAzGN/NdNYTWQdMohybKtOY2P8XW sb79mFyaYrPz1U= X-Received: by 2002:a05:690c:4510:b0:7bf:27e:66ae with SMTP id 00721157ae682-7bf027e70acmr4609997b3.30.1778095808985; Wed, 06 May 2026 12:30:08 -0700 (PDT) Received: from gmail.com (172.235.85.34.bc.googleusercontent.com. [34.85.235.172]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7bd66527421sm82466277b3.2.2026.05.06.12.30.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 12:30:07 -0700 (PDT) Date: Wed, 06 May 2026 15:30:06 -0400 From: Willem de Bruijn To: Daniel Zahka , Jakub Kicinski , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , Willem de Bruijn Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: In-Reply-To: <20260505-psd-rcu-v1-1-a8f69ec1ab96@gmail.com> References: <20260505-psd-rcu-v1-0-a8f69ec1ab96@gmail.com> <20260505-psd-rcu-v1-1-a8f69ec1ab96@gmail.com> Subject: Re: [PATCH net 1/3] netdevsim: psp: only call nsim_psp_uninit() on PFs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Daniel Zahka wrote: > VFs go through nsim_init_netdevsim_vf() which never calls > nsim_psp_init(), so ns->psp.dev stays NULL. nsim_psp_uninit() guards > with !IS_ERR(ns->psp.dev), so destroying a VF reaches > psp_dev_unregister(NULL) and dereferences NULL on the first > mutex_lock(&psd->lock): > > BUG: kernel NULL pointer dereference, address: 0000000000000020 > RIP: 0010:mutex_lock+0x1c/0x30 > Call Trace: > psp_dev_unregister+0x2a/0x1a0 > nsim_psp_uninit+0x1f/0x40 [netdevsim] > nsim_destroy+0x61/0x1e0 [netdevsim] > __nsim_dev_port_del+0x47/0x90 [netdevsim] > nsim_drv_configure_vfs+0xc9/0x130 [netdevsim] > nsim_bus_dev_numvfs_store+0x79/0xb0 [netdevsim] > > Gate nsim_psp_uninit() on nsim_dev_port_is_pf(), matching the pattern > already used for nsim_exit_netdevsim() and the bpf/ipsec/macsec/queue > teardowns. > > Reproducer: > modprobe netdevsim > echo "10 1" > /sys/bus/netdevsim/new_device > echo 1 > /sys/bus/netdevsim/devices/netdevsim10/sriov_numvfs > devlink dev eswitch set netdevsim/netdevsim10 mode switchdev > echo 0 > /sys/bus/netdevsim/devices/netdevsim10/sriov_numvfs > > Fixes: f857478d6206 ("netdevsim: a basic test PSP implementation") > Assisted-by: Claude:claude-opus-4.6 > Signed-off-by: Daniel Zahka Reviewed-by: Willem de Bruijn