From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f44.google.com (mail-yx1-f44.google.com [74.125.224.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31EE4305691 for ; Fri, 15 May 2026 20:57:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778878666; cv=none; b=InPUFG2nnhwEh6pIy9l3uVDA9SjISSfLs6zhFwway9tmlWUP671JZL6bulEgTogGHRckvAD7xJL2MSEjhy7CJ8oYHNnQbsgUoQDaXYdy1AwtsiqZUqiu6GfpbuGqY4y+fi7bJ+jszsulGaDOJglC2TN9ewvjYTpaR/5vIy3qDXY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778878666; c=relaxed/simple; bh=T18phV1uWOaQaUa1vLLX0NYJ2ankHcxd9/kOPhQnwwI=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=HEwiF+wd/m5mAEK2xXOHf4TooPoU6fkJ7MyBsPRXpC72fHBwsuJ7/VNjfgRgoEn/CQ3E6IW8thgqxboh0b8kBA59asZWm/hjnRCMv2AetuMdkIE2OIrkKZlTKy4VZAcpl10yDZtq6ZBBCLVkK8+IQD/xrupDYf32KQ4CD9gcvgw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MuxcDhRt; arc=none smtp.client-ip=74.125.224.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MuxcDhRt" Received: by mail-yx1-f44.google.com with SMTP id 956f58d0204a3-65318dafbcbso517639d50.2 for ; Fri, 15 May 2026 13:57:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778878664; x=1779483464; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=T18phV1uWOaQaUa1vLLX0NYJ2ankHcxd9/kOPhQnwwI=; b=MuxcDhRtP1FFxboIgd4U1yLdLXXQP0mbyZpE9wR9SqKs1DcE97LYS2gVKYz6nFW1+Y REeMT3xFWlvqoy+SIuYVZtHsX6q9aelQR8xYHKtjUreXNaxyKlZ8C1D+M8+DRuwiLQhT ySkSqb5ETfAQQ1ZKUSjS27XeD29uJDFOsIyXQGcvUWLN/fl8fD+/Czj6fX2y6hLN4wD8 C23QKEUBRIZCiUgBizEGMZPtVB4LhPNkBRO1861gkcD9VUO5dJrlJGsdb589UTUoORXc G0ZmAmWUBYxUr1v32YR994bQaPMvRiaK0oAB/RsNKqT0fCBkRSQrUa/BtkLsIpJ+DCxs xjGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778878664; x=1779483464; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=T18phV1uWOaQaUa1vLLX0NYJ2ankHcxd9/kOPhQnwwI=; b=VckWdheCxlbB0Cis6bskAbEj9f+BA0Y38fSueMfV5X66FLefQSuwlo/QIl6nPGXRse gAr/lSGmzYmFQsmTGiXQQc3OUEG/eryIJ9odt3Ngw8SEUm5NHQPezzP8UVYvRSaTO7Nn 954mIAU9vckc+AsQnCQeS20X+Pw2+52QoOLiUAuBtD7CNr50nbeG9U5A/SYkfyQxOtVa gQVbuz5+vuLJ/Miq1ucpZPJl2dHtpbRV6w+LhW8rx5kdTyUq3eIy57lP9sF/EIhXikyq Y9YJVTW2fk3HaM8Q6ckpmmCnhU3ei5As3BTjbdC/pWCsmlEpRvJMpnuASPh3g9TMJ1ld HUQA== X-Forwarded-Encrypted: i=1; AFNElJ+ZEA1HAikb4li4TGxirDXONGVGYBV0MAF2VFJWDjamXzcaMwlCkJzL8klK0zty414267LbH4pU9+g++0s=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1o6yKtGDldN7glgiNF3+UyBSxZXCLMcLtR3xOTYWaYHmlT4Uj 88zaK0NgzpX9bTJggeFnUQ+cahcPIn4nG2A9E/ymsXSOFJCIOuVCatTU X-Gm-Gg: Acq92OGN1CyQab+1f8Aryh+MgO1hXvbLUFnG8CT4M1tw48rLnGqX0NnYz5fuA66B93P U0lTvw4FRFxYN7u0S96qvfraoH7DT0rOUk2Fs/hwBZl/DTJ5y1KdFPR3+4OUyEAIBgGs1SGVlMN 2GUjXi3rCvrWmu8oBDhVRAdxZ/qs6DsmAKfKbroN0m8mr62QEcVcryWyLhGwAqM9ih1q4B1l2pX YKvec4WuuxHVe0bU696bELYN6Ir5dXz6Wni0asqagKiiWvLHdZuX4hqYfjoPECB05crHcU+2Jc6 ge4LgAvnkgAryxKgtcbl4DhjaEKwRqMPko+47LLfSDWx5mopEnVDqzKIIkKLfRTST+8sbcqzynW KlunFevUBvSLpnrravPhWB0g4IgVstjQj0cuRfPNzyaaoh1E4UG4Oep1gjia7Z4SM4NbUgE4gp9 CTJWX9Fp61mebkOO/bTbBngyc2c2GY8yup1/Srkhqwm2JpyLp87dbTSVTs06nySbtyL7+w998g1 YGHU+00/TGetZ4= X-Received: by 2002:a05:690c:6987:b0:7b8:9418:7605 with SMTP id 00721157ae682-7c95c201035mr60281887b3.38.1778878664204; Fri, 15 May 2026 13:57:44 -0700 (PDT) Received: from gmail.com (172.235.85.34.bc.googleusercontent.com. [34.85.235.172]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7c7f2aabf9csm36060107b3.16.2026.05.15.13.57.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 13:57:43 -0700 (PDT) Date: Fri, 15 May 2026 16:57:42 -0400 From: Willem de Bruijn To: Daniel Zahka , Jakub Kicinski , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: In-Reply-To: <20260515-spi-handle-v1-1-debf8cb467cb@gmail.com> References: <20260515-spi-handle-v1-1-debf8cb467cb@gmail.com> Subject: Re: [PATCH] netdevsim: psp: reset spi on key rotation and check for exhaustion on alloc Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Daniel Zahka wrote: > The PSP spec states that the lower 31b of the SPI need to be > non-zero. Though not in the spec, I think it is reasonable to reset > the lower 31b of the spi space after a key rotation, and to also > decline to generate session keys when the lower 31b saturate. This could be stated more clearly in the spec indeed. At a minimum as a suggestion ("should"). = It does imply the second: "The SPI field is 31 bits long (since 1 bit is taken as the master key indicator), so the master keys must be rotated before the key=E2=80=99s SPI space is exhausted." > = > Assisted-by: Claude:claude-opus-4.7 > Signed-off-by: Daniel Zahka [PATCH net-next] Reviewed-by: Willem de Bruijn