From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7305317151 for ; Sat, 21 Mar 2026 00:40:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774053601; cv=none; b=ld3v7W9du4rvnjZZyUxgCh4eTEiv5J4vHehwVdcz3DSYYZ3P3aANgcl7i80YJG/VLo693m/f53vPLYtUQNHz5IifsVyIzr/m3mm2zTUG/Hwv8n7MFWQSJrjeM/lJm9ph/UBH+eE916CtMFsx9q83vz01pIC0c8n/39dhjWmnYb0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774053601; c=relaxed/simple; bh=yXs+s4BvdFYJYm2dbaHRIlcd9JxSNaE2rtcDi14iUJ8=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=SblTc7BQPONUcj/X+4DMlkNoWdRvpratNKpbeNqMosm/86m8wX2hIQfq5GqF2bbE+8lpPXNhD4rGo4Ys+5jWSb0jukY0e0LaSba9i9R0XVmJvoN+jgSsJVRtwa61x5VXjcQwbSMyQ2vXNoST//FsDmlKjAS7VAVJZ2zwNf2gtIU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Jo6ZdL+P; arc=none smtp.client-ip=209.85.128.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Jo6ZdL+P" Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-78fc4425b6bso24855297b3.1 for ; Fri, 20 Mar 2026 17:40:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774053600; x=1774658400; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=fZYPe3Fzt4XiWBzmxWxCmd97onqN8khEvECVztrT0eg=; b=Jo6ZdL+PPtu42RMyQ181vEsfhHNF+Fxqa8jwHlH41ms8mjuDU91yNYiMbxeWJb3wxG fZ4mmdIt3UdXZpTxtp46RYazm8aNFYraf11bQw0reX7EX6vja+LBg7UlTihtSsnrcNgI ruQGFtZNSvUUn+8J+Q3wEAFDcbOhHQqX32JuNcEyxnq5K65eSpTYMsw+fgbzrWRKUfF0 mgChHASSkTtCSH5UN5KuOgu6HCfLPyThDzNyXjAwBhjJK6xcH3WQ0acG3vdasJkuHsLr 7L9ReioOhdS1q+eShGt0QcIKtroAQjXvnUXsHG86vkuAiyvUS+p+5Fh+xr/DpyKlBq4f DCpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774053600; x=1774658400; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=fZYPe3Fzt4XiWBzmxWxCmd97onqN8khEvECVztrT0eg=; b=UoU8fk7zKU3Y5DVSCjDtbIazfoyOAscYlCEiea/aj21vvuO6uEJbus2+J3DYtofP9w M79MtFWG0cLtF6Efgv8oBQCXKDGvMJjeOOgXnG0150NSE8mTN6UMdsgTtWslhT71d6/o lwePaK9Nev1dlCKk5GyzpP+0XCKi6BZKpsFoqGty5s3g5dC9nWbm+RaOm7Z8AJru2MIK NHFM9m+Geu4gWOxQAciZ1/8B3zUOfVQOWOoYkB+HN/d6tAELozzj+B8/S4NHn/rTkRG/ 8iNdXSkDBXxYkfcny1aW1jXztlSsN9Zx2VaAVQ1exjdR5RsF4abB+lb311Nln8QJ6z25 7V3Q== X-Forwarded-Encrypted: i=1; AJvYcCVazePEaNiNxC+PFRy2uCWA8hHeiXP9sFuvH20lf0t+FSh5TMi1gbql27P/SUwezYvkiyDrn4jVzRLYXFI=@vger.kernel.org X-Gm-Message-State: AOJu0YymL2CaeifVxEmwW6jx83Df3WDVyhFlMnAfWaa9FZc1ADkPVJ0x cv6xjQhWATTybeowfyQlcataLZfCZ5p4jUh1MtPPQ8b7I2UDMJVNTFfa X-Gm-Gg: ATEYQzwe4HTZ1H+lynT0ZXMkqODPHbG31KTohhRjHhRRaliFejhMhHz1oAEkNSR65fx rMclj5Jg5KpJs+4ufRWe84Zqy61+Na8ddkrQyifc8UfdyfemCh9MQNQ1c82bCtWNXALg9oPEkEv IRMYiLradKOqlQNGqkFlv9DpPPYBf8OpqpA5717Fh7zaBNgJGT/4w14+Rvk7wCKBmFQ0niJ+alp fGGzgvl9zH+wcu4OXlpmjgJLpK1hg5VhRe+KBTtb2CXFuWrSe4PXKZaQ1fAhpDaEghIzEvqnk9z SnRppCu7AzeXH5Rm9UmlWcpY9eLpcEVA1gdGKnahKnRymUiPGKbXk8eg9reW7TlfkAyzGA5QCoD qf0lExubj0+0mz4bmJBPz/Vny0L7bzmu08Dzgp5+dg72ij2Lirfm0crd+D2twioInHOQwprKh2n 2RvWkPhSHm1Dyh4MYkg4/42YAPIdjB197KJvKjESSyqIsUxX5k9YtyACcbg092ESRl28uGQcf+q Ykg X-Received: by 2002:a0d:dc07:0:b0:798:5b22:ecb0 with SMTP id 00721157ae682-79a90b09f20mr37919447b3.22.1774053599741; Fri, 20 Mar 2026 17:39:59 -0700 (PDT) Received: from gmail.com (180.134.85.34.bc.googleusercontent.com. [34.85.134.180]) by smtp.gmail.com with UTF8SMTPSA id 00721157ae682-79a9054ee5bsm24336127b3.31.2026.03.20.17.39.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 17:39:58 -0700 (PDT) Date: Fri, 20 Mar 2026 20:39:58 -0400 From: Willem de Bruijn To: Nick Hudson , bpf@vger.kernel.org, netdev@vger.kernel.org Cc: Willem de Bruijn , Nick Hudson , Max Tottenham , Anna Glasgall , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org Message-ID: In-Reply-To: <20260318134242.2725749-4-nhudson@akamai.com> References: <20260318134242.2725749-1-nhudson@akamai.com> <20260318134242.2725749-4-nhudson@akamai.com> Subject: Re: [PATCH v2 3/5] bpf: add helper masks for ADJ_ROOM flags and encap validation Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Nick Hudson wrote: > Introduce helper masks for bpf_skb_adjust_room() flags to simplify > validation logic: > > - BPF_F_ADJ_ROOM_DECAP_L4_MASK > - BPF_F_ADJ_ROOM_DECAP_IPXIP_MASK > - BPF_F_ADJ_ROOM_ENCAP_MASK > - BPF_F_ADJ_ROOM_DECAP_MASK > > Add flag validation to bpf_skb_net_grow() to reject invalid encap > flags early. Refactor existing validation checks in bpf_skb_net_shrink() > and bpf_skb_adjust_room() to use the new masks (no behavior change). > > Co-developed-by: Max Tottenham > Signed-off-by: Max Tottenham > Co-developed-by: Anna Glasgall > Signed-off-by: Anna Glasgall > Signed-off-by: Nick Hudson Reviewed-by: Willem de Bruijn