From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED27A3C942C for ; Mon, 20 Apr 2026 19:42:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776714165; cv=none; b=BwFOSdLLfg11SEVDcFr3BhAwiwSy6dd1vmLW2iq14naOTcj6CM1y/LqI84K4KfGYqM4MD1p2q30IdFWAi0vxfNKgrVj7v0IoRMZWdob8/CtGlZTkzmueQOlBcXmBTQmiuqd6kizhPZSfwTRADAIKY3zdz5HxM9FabX2BbpO2KCc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776714165; c=relaxed/simple; bh=gGhv5aBvag8GkJJw8oK+HvN5ptj86XyPHMattSfFigo=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=ICITDK0qqGQDP4bAET8gOWIYIu4rvOamiSGkuczmjU4FaH9VBh42+LLfayAgtliACRRzrmjWrQH4ixBFnxC0q1kXhr2Ioyoctsh3dWBBSvtjjgXccEvdADyAYpXCjnqJqAKlnW4i51FsVLiToOSB/VssGy9O/5dw9EJOQEyKnkU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ioJuHZ+j; arc=none smtp.client-ip=209.85.128.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ioJuHZ+j" Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-7baee75f874so13572007b3.2 for ; Mon, 20 Apr 2026 12:42:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776714163; x=1777318963; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Ar9A5QrYRWGb5NIZabW3eNiZEMmSWnS35Z/zWd2ipnM=; b=ioJuHZ+jKiUhtlsNSOyP3QlO4YWFOh20tActa3Kup9u2YnAy5zNVLxuYYRAeKcAc1l sX3MeNQFoCigoYRqXNB373NG/iQVAhrotHG5wsmPUES/UE59cNaSz9jSa8mAjDzTvpZY rCnLpv/i7T6wbWZZ70HC8zF7spr3wFQwzr2vPdiooaRgQgplZoaCxPCybss+1EpILpty 6CP84QEcyJc6fyyx/Uh45pHH4RCQ1efS3KyoGmjuXXbphWfFJDUdsoIDcpgvH2VgVcWU I+bGIVjKGb2eJuRrLi/dv9azrTqFonXSNUaZy6XVNPwyCVSRndjvYX0+sTBQ/FtLqNlT T3kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776714163; x=1777318963; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Ar9A5QrYRWGb5NIZabW3eNiZEMmSWnS35Z/zWd2ipnM=; b=CdyNEas3Y3o9yKCRPonStJK9uV+7sm2ORLbte8F3ghVx0PHUDcPrM9tQmd646B60e4 DUyvwvLKETrETzYE0XiaAC2JmolCU7p3IYeAmS5pR14p906GLlDI0wx7qJyzIwTMB7Nl mQTyhTQsHKyH56QytQEQ1J4aNpT/D5ymut+wnmRolaZq8d/Kle+B0eQX0nSN8/Gg8Hr8 fvdntiIn0LelMOBID/xDpzef0dRhOfQhfVjtDZEbG5QGr7Oyx1VUE36mPkzn5iXvrsjx Ee+uORGl+8+9jCMZACvc8UXXLKlZ5XAKEbNPBieN74ZUB4ajJqzmif0z5yJAlXVLoW4o fOCg== X-Forwarded-Encrypted: i=1; AFNElJ873wZKNQtwLyRPuo4je8fINUYMIsq+q/cFVVkg618BVGN0dMTKez9fI0e153b7OOMSh9auGobcq+5QoaE=@vger.kernel.org X-Gm-Message-State: AOJu0YzdoUZXT7E3L1lHHhYsMyvv3cvnU2jdLdd2I7EakcsICKBnA13l 2kKHQJimf1Ws4b571baf9e8O2wWtD32xqt5Q47+hR5EJAHHu3HAyBDX/ X-Gm-Gg: AeBDiets8JJpFF6yuagAOUY+mlzmeZxT2EVnqISnLM/TYnrLbRbRByuXs7YGV88uBf8 c3/Xfv9hdwrh4rmhK4y+pgGiGEHe0H7gJPpy1rKJq9Yf9idhk5a+dhI7vh0UGkqWBukNVE2qt5T 6w/ldvLFiUB1+EBpHvqHkwqiBwuKy/M+RVRP5qvv+MxUZvwjJlNKwMVnuSTyQTjvPzR3R5kT23q BHEhhcPD9VZRBJvQpmVG3tNeMl8uJwNLCwOdRUjzPX6QPmYShxlUxYuy3h0do8ECIf1JFxXq5/k KXF762Gpu9ONuF7rSS8Zc2imHZhC1xIrEgttOy042esuI0wlwyDSkh3i6D8wiY1Xj53GeGh/JYI jPSW/4P363rYIGi5fs4PPZlm1Vn66y25oeHMaQrSdTeQn+/f8QuMIT3QSIjryCF+km4gk4guMzb e51KT6hPVMdzQlK7tBlpX7qhDsnpLDrrpIkEFb5dIS4sPthcamAClGP+uQ0b5lAoiJK6twr1dAI KLXw+q6wvHmIs2rHPYkIp1B7g== X-Received: by 2002:a05:690c:9201:b0:79c:ff02:a048 with SMTP id 00721157ae682-7b9ece6ad3fmr142245957b3.4.1776714162988; Mon, 20 Apr 2026 12:42:42 -0700 (PDT) Received: from gmail.com (172.165.85.34.bc.googleusercontent.com. [34.85.165.172]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7b9ee89b259sm47551907b3.2.2026.04.20.12.42.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2026 12:42:41 -0700 (PDT) Date: Mon, 20 Apr 2026 15:42:40 -0400 From: Willem de Bruijn To: Nick Hudson , bpf@vger.kernel.org, netdev@vger.kernel.org, Willem de Bruijn , Martin KaFai Lau Cc: Nick Hudson , Max Tottenham , Anna Glasgall , Daniel Borkmann , Alexei Starovoitov , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org Message-ID: In-Reply-To: <20260420104051.1528843-3-nhudson@akamai.com> References: <20260420104051.1528843-1-nhudson@akamai.com> <20260420104051.1528843-3-nhudson@akamai.com> Subject: Re: [PATCH v5 2/6] bpf: refactor masks for ADJ_ROOM flags and encap validation Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Nick Hudson wrote: > Refactor the helper masks for bpf_skb_adjust_room() flags to simplify > validation logic and introduce: > > - BPF_F_ADJ_ROOM_ENCAP_MASK > - BPF_F_ADJ_ROOM_DECAP_MASK > > Refactor existing validation checks in bpf_skb_net_shrink() > and bpf_skb_adjust_room() to use the new masks (no behavior change). > > This is in preparation for supporting the new decap flags. > > Co-developed-by: Max Tottenham > Signed-off-by: Max Tottenham > Co-developed-by: Anna Glasgall > Signed-off-by: Anna Glasgall > Signed-off-by: Nick Hudson Reviewed-by: Willem de Bruijn