Re: [PATCH 4/7] netpoll: Export zap_completion_queue

[Willem de Bruijn <willemdebruijn.kernel@gmail.com>]

Breno Leitao wrote:
> On Tue, Sep 02, 2025 at 06:50:25PM -0400, Willem de Bruijn wrote:
> > Breno Leitao wrote:
> > >  include/linux/netpoll.h | 1 +
> > >  net/core/netpoll.c      | 5 ++---
> > >  2 files changed, 3 insertions(+), 3 deletions(-)
> > > 
> ....
> > > -static void zap_completion_queue(void)
> > > +void zap_completion_queue(void)
> > >  {
> > >  	unsigned long flags;
> > >  	struct softnet_data *sd = &get_cpu_var(softnet_data);
> > > @@ -267,6 +265,7 @@ static void zap_completion_queue(void)
> > >  
> > >  	put_cpu_var(softnet_data);
> > >  }
> > > +EXPORT_SYMBOL_GPL(zap_completion_queue);
> > 
> > consider EXPORT_SYMBOL_NS_GPL(zap_completion_queue, "NETDEV_INTERNAL");
> 
> Thanks for the suggestion. First time I've heard about the export by
> Namespace. I suppose then I need to have
> `MODULE_IMPORT_NS("NETDEV_INTERNAL");` called at the caller side, right?

That's right.

The feature is fairly new. I don't think we have clear guidelines what
is and what isn't in scope yet.

In this case, it seems clear to me that this API is not intended for
broad use, so falls well within the area. More context in
Documentation/networking/netdevices.rst