From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f47.google.com (mail-yx1-f47.google.com [74.125.224.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6399E423A95 for ; Fri, 6 Mar 2026 20:37:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772829447; cv=none; b=rNLLN/fmvUy5Xrz/FdgZnyaXW2oN3AElEA5rGtGS+mxCYK6i6zD7BcJ0QdmJv8p3pkOIXwSqoO8XbCQIRzbp0aDZEs88GqFK9KjEhczm6e+efN/eGjPcaFa95aY4//SkZVfjLyQhetPDDP5oUH7VEtB9okxymJI+iLPjfXQ9dc4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772829447; c=relaxed/simple; bh=8IP266OrpRGoB9qgnxdq67NDrPYQDlKhU4OIG9LteCU=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=b7vHEeIm6CNBPPu+V19G6Aj4HqbwiGlpWkibPy8Yms4dG9gLYarXY38Rs1waJf+i5StutmoiWMLNt+TeudVb/1j+zoovkZNYGLnPgbiZe20sxD3ZWRvTRLrQw+jGxx5/Gym3Xr3CSvx2oclkEdO8f6w8Ma++8REjiBwfF5FPviw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ngzr2Eyz; arc=none smtp.client-ip=74.125.224.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ngzr2Eyz" Received: by mail-yx1-f47.google.com with SMTP id 956f58d0204a3-64c9a398bc7so9107902d50.2 for ; Fri, 06 Mar 2026 12:37:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772829444; x=1773434244; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=8IP266OrpRGoB9qgnxdq67NDrPYQDlKhU4OIG9LteCU=; b=ngzr2EyzB6iFWo6LSx6744C+ykZwA0EoW//RrgcnfGZwxxx6kAoRYTKxILdLaWqIY/ sij0F98+16T3wYa45OJbUWllZt/8zp5lfRDA0mfVVHDbXYkjHCJQJDaLflB6dzpAJe6I m6uUPT3ORaQa/v44KaDJ4lolazve8d6DNdG3cGhlF9vLQ7I2SC4fDRlh8BTjMuZ1KYQw 8gixCSJwizG+6SbrOTzyX/l1Q2Hz8C63U4fbgn5bMeL4OMOxNXBo0cPhheOdDEJT7E4U gyoeFyjAtaP6HWsC3x4e+tOV8rE95R2KEtnMB9mD0RyLglPL+52UOhsItLATNd0L0NSe boXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772829444; x=1773434244; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8IP266OrpRGoB9qgnxdq67NDrPYQDlKhU4OIG9LteCU=; b=cMO/1yVWF54xvODP5QYT1KMdg3He8hvlnqOoGs1eD/eJl7k4Ga62Xw721FXxs912Mr og8MjDGUUEao/lOBxVGceSB9ZeL8eHtiAvGjTgOq/H1HJTeTMMblSPavEXrLx3g7IJYE P4DMfnWpw0tS4MSVLKuLpAVyex7yrn/T8rPEtuVKfyHut9MlGkLdfwrItfI2NDTXbsHc p/R1DL9YZM/GVtx1EM080J042ZRTzadp6Zn5OZAZQekLB8YpOeTp8DbdmDCsMfDovnCi vxqeZN04fYRVY0M1w/pPM9Qt9G/IfXCfr0AvKJ8mIBQXmMn4p3utMA5QHoVi/RoTOvZY xulA== X-Forwarded-Encrypted: i=1; AJvYcCVwbuEqG9l8baWShJxwndff0sc4JhV3+RR5jYXYMBlxufKYmfV8Tnyqr30YeRIxL18ljpm2DV3o2YnBQJI=@vger.kernel.org X-Gm-Message-State: AOJu0YzA/T3eFzcAZids7sTh+WPpeIuW2EhVy5kDBxbQ4Haat0hhDb8k VtPR0la3+rsWBOfSiT47b3GDuMLegKSwiBzrtxn3BKV84VM9vNl7fTfT X-Gm-Gg: ATEYQzzY+vuJQ9oXnznIOOheFyAoAOK35JSRCzpIC82KxgoQo0ZnNTfgxEooJr7go8H p8CI8cFt2QWkuCqxGf2j+cFXvqOx6L1gbLbBRPuqUQ4gWMiofNtI93/c35ufxUtTWc8uRGWsMGe 9IEBBXwAU/zvfifhcw/6rpw1ratR/dc5GXt9Tegw/awVhNt85mmGcvwr9pm7S7v67xpckUWywmT tnNrjNxEckv2Ir87lRTU3teETjAEn2j28IYRPKU4jYbtb1pntVMMJOCzmyVTkWCwCkBca6T/QYf cO+0aUdYDZfYmngCB1b/Bo1G7pcL6TJZE00nRcLa+CRh0tgro2lfnaEIuaMoPxFlLLFaAu7kXu8 yPfT4S/vxNZXZk40dGm/+50t1yiykyBD3qHwTVWpKfqkXw994UJLpN9T7fj3UtczZS/iYrG8YgM qGdbIxTqLhKsQ6x0OmUMxqiTAwYs77e3Qj+NPYnXp/YFNdf3uzokVJWYOe0IuULmpPxC0/AfU= X-Received: by 2002:a05:690c:1d:b0:798:cf7a:4ac8 with SMTP id 00721157ae682-798dd7ac0fdmr32950497b3.58.1772829444288; Fri, 06 Mar 2026 12:37:24 -0800 (PST) Received: from gmail.com (15.60.86.34.bc.googleusercontent.com. [34.86.60.15]) by smtp.gmail.com with UTF8SMTPSA id 00721157ae682-798dee48667sm11532747b3.28.2026.03.06.12.37.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 12:37:23 -0800 (PST) Date: Fri, 06 Mar 2026 15:37:22 -0500 From: Willem de Bruijn To: Akhilesh Samineni , Willem de Bruijn Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org, willemb@google.com, daniel.zahka@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jayakrishnan.udayavarma@broadcom.com, ajit.khaparde@broadcom.com, kiran.kella@broadcom.com, sachin.suman@broadcom.com Message-ID: In-Reply-To: References: <20260302195352.1015990-1-akhilesh.samineni@broadcom.com> <20260302195352.1015990-2-akhilesh.samineni@broadcom.com> Subject: Re: [net-next 1/3] psp: Support resetting statistics on a device Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Akhilesh Samineni wrote: > On Thu, Mar 5, 2026 at 7:55=E2=80=AFPM Willem de Bruijn > wrote: > > > > Akhilesh Samineni wrote: > > > On Tue, Mar 3, 2026 at 2:45=E2=80=AFAM Willem de Bruijn > > > wrote: > > > > > > > > Akhilesh Samineni wrote: > > > > > Drivers may need to reset per-device PSP statistics to zero. > > > > > > > > The series does not include rationale why this may be needed. > > > > > > > > What makes PSP counters special in this regard? > > > > > > > > > > The PSP supports dynamic administrative states, allowing it to be > > > enabled or disabled during runtime. Currently, statistics are > > > persistent across these state transitions, which can lead to baseli= ne > > > drift and complicate telemetry analysis. > > > > How is this dynamic enable/disable configured, and can stats reset be= > > part of that, rather than a separate API? > > > = > Instead of bundling the statistics reset with the transition to the > disabled mode, we considered providing a separate reset operation to > give users the flexibility to clear counters without toggling the PSP > state. Flexibility. And responsibility. A user process that waits on a notification to exercise this API? That would be quite complex and clunky. If counter reset is expected on device disable, more robust to have that part of the reset logic itself.