From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDCED37C909 for ; Tue, 7 Apr 2026 21:49:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775598572; cv=none; b=DPPeLDx3VkC2NBz1gSgmMZGh7xJeNlJZHBjWMSSUU7/5+MRbF/2i2Lm/mnAHGYsoohIxEeRleJ07YaTizdWLGVmBMi56VlN75xp7olxWR6LTy23ODh1hm8oSfhB13t4AwI9sJXpdYUfXuSvLEf5J7YW+4LEfoA6sEuEYIOZzjFk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775598572; c=relaxed/simple; bh=786cf498Ck+7N2b3p02kVFc1c2hiRJobfwl7MyR7itI=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=Ge5NnI7O3JDxNlzcfAV/G3K57cjxv5mScirA5f+wckLqR3dJhaDlovO4bvUTjLERg2N4eii0R+EzcTSmwdW0l4/5jHNNhHcQFp78sZDeaUwZzs7RH4NskmwrMz2+Wmi9lcOBj0T5R9r4oqAmvkerZMj1wxw2NGNsfG4MijHM3x4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Uuy5WLOt; arc=none smtp.client-ip=209.85.128.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Uuy5WLOt" Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-79495b1aaa7so53606337b3.1 for ; Tue, 07 Apr 2026 14:49:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775598570; x=1776203370; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=zjZgk6RqcrwcrJOXiC6eMW3xcA9r0nZNiCoTLL7m1W4=; b=Uuy5WLOtfSWaYtHyqyV2OX5kPCN1hR5aY50BPIrt+mhAMTS3v4yxxemoNo5Ic96PsR ZNjV/sgTepBKCg6ET/282qPJeR9dFnOswjVVpaob+b+CmRBq1DwwTr0dCPfSAGxChCRG aBlIt9Rn4LsV6GSMk2VjJ0DcARFE9r8W+CkTrGNh3/RokVNjyZPcQ6F+OtqEfow9y5FE QXNDSFAJsy3WQetL84APWvzF2AyHdmu9RdAPH7ImM/z9Sm2qXF7Li8BuZttFtbzf5Ul0 1jbPKo+z3Euh+UUGNiCP+e/5fmnbNfXbmIN48i1ze7po+nT59O30bhxMKiUDdS3sX7b+ XNRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775598570; x=1776203370; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=zjZgk6RqcrwcrJOXiC6eMW3xcA9r0nZNiCoTLL7m1W4=; b=kZZGMRfig3fdiecd8YB8KW5hiab6xzxk6qunPPYraKhc90nYjNS/WbpbSczqC/zrsD TMffrhspgHz/s0WENJnpKLGewuHUN/t5RbTFidLB6g5e866jHF7YYO5J026CDlQVU5Vw eFJfRqaGGgRQ2oBsuevWDNqnOebL+1456j0j8pmbOdxEHwLwhNduPSI7InQ6Q0nVHyRk aB0765Ij872Yy04vF53d6JafIoTIjuHpSluQ9maxua0BOy8XOWljQYDbqoh6WKfP3KNB F+yApZAQzjBYl5fqmJuLmmTqGrvHw/Mcp+my6qtiMkx/WKifn4ElepTPFjcLcao9c532 g4sA== X-Forwarded-Encrypted: i=1; AJvYcCX95zlg8uq9LvHENQCKhAX66tXPNBxeUfMlrEIx/8DtQHG5nrbQ2pzU7pDBn9r1yXgTc5TR7Kh09JPlfIc=@vger.kernel.org X-Gm-Message-State: AOJu0YyZXdKPflNZ5+/ENBkHCFrDbnn3D2FbUK0LZSbB3TGqhZDfvYln 7MxWp/BTDbW0XWkOW+0L7RojyDCghQ6RdFB/EGqCENEBL5ZU/J8ObOR+ X-Gm-Gg: AeBDieulDzIukypYluE/7LQNkFeHByY/3JycvE+yVIjtZ9qIh9mQGGo0A0i+tceU2Ti 30qrhacIqgdEiD3zOjfPyFH0Zh/2dCWqaa3iD0b5bBQkieGPgQPWrkK711pcGjrLufEmwe7Xvb+ GuquijEd0uXzEg82G6B4HGxcbdNowGSxFfcCMLl9glD85gbAIsDeUAnlai0PnTW7bX1cnbKH6/q 5IB+j1UQ9GCoToN6nmk84msZed9FSInb8DxLcLMKiE4a6YMrBNJ1pBoCIxltF/waVZ0iBWBTBm/ erp07nPurFGzOvicbEffoVxpGkEFl1c2BqvZ58aEemvu0bmfL2Dio9xUIuZJM1WtTgollMwlJn7 +Y+u/snwQrbCAmvXkuNi4KsDYQeLXplpqn3HjXivGUSYbfTLyxR5Zy3JjexOZs7hXyUcSaCCf2F ZoWFU1HZVmsMh84Q4aKD/6DKg+DJ/CzlKzpil1sieGPqF+f4jxXSOjQ2ZVGi5NR+bHNwW+Q9cUw WTu X-Received: by 2002:a05:690c:83:b0:79f:7972:f89a with SMTP id 00721157ae682-7a4d556ac32mr177080107b3.28.1775598569814; Tue, 07 Apr 2026 14:49:29 -0700 (PDT) Received: from gmail.com (172.165.85.34.bc.googleusercontent.com. [34.85.165.172]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7abfc962dfbsm409127b3.47.2026.04.07.14.49.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 14:49:29 -0700 (PDT) Date: Tue, 07 Apr 2026 17:49:28 -0400 From: Willem de Bruijn To: Akhilesh Samineni , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org, willemb@google.com, daniel.zahka@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jayakrishnan.udayavarma@broadcom.com, ajit.khaparde@broadcom.com, kiran.kella@broadcom.com, akhilesh.samineni@broadcom.com, sachin.suman@broadcom.com Message-ID: In-Reply-To: <20260406222305.4111170-3-akhilesh.samineni@broadcom.com> References: <20260406222305.4111170-1-akhilesh.samineni@broadcom.com> <20260406222305.4111170-3-akhilesh.samineni@broadcom.com> Subject: Re: [PATCH net-next 2/3] netdevsim: psp: handle the new crypt-offset and spi-threshold get/set operations Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Akhilesh Samineni wrote: > Implement the crypt-offset and spi-threshold get/set in netdevsim PSP. > > Signed-off-by: Akhilesh Samineni > Reviewed-by: Kiran Kella > Reviewed-by: Ajit Kumar Khaparde > --- > drivers/net/netdevsim/netdevsim.h | 2 ++ > drivers/net/netdevsim/psp.c | 6 ++++++ > 2 files changed, 8 insertions(+) > > diff --git a/drivers/net/netdevsim/netdevsim.h b/drivers/net/netdevsim/netdevsim.h > index c904e14f6b3f..3ad7d42391c0 100644 > --- a/drivers/net/netdevsim/netdevsim.h > +++ b/drivers/net/netdevsim/netdevsim.h > @@ -117,6 +117,8 @@ struct netdevsim { > struct psp_dev *dev; > u32 spi; > u32 assoc_cnt; > + u8 crypt_offset; > + u32 spi_threshold; > } psp; > > struct nsim_bus_dev *nsim_bus_dev; > diff --git a/drivers/net/netdevsim/psp.c b/drivers/net/netdevsim/psp.c > index 0b4d717253b0..9098edf00c5c 100644 > --- a/drivers/net/netdevsim/psp.c > +++ b/drivers/net/netdevsim/psp.c > @@ -122,6 +122,11 @@ static int > nsim_psp_set_config(struct psp_dev *psd, struct psp_dev_config *conf, > struct netlink_ext_ack *extack) > { > + struct netdevsim *ns = psd->drv_priv; > + > + ns->psp.crypt_offset = conf->crypt_offset; > + ns->psp.spi_threshold = conf->spi_threshold; > + > return 0; > } > > @@ -249,6 +254,7 @@ int nsim_psp_init(struct netdevsim *ns) > if (err) > return err; > > + ns->psp.spi_threshold = PSP_SPI_THRESHOLD_DEFAULT; > debugfs_create_file("psp_rereg", 0200, ddir, ns, &nsim_psp_rereg_fops); > return 0; Default initialization should probably all complete before the device is made visible with psp_dev_create.