Re: [PATCH net-next 1/3] psp: add crypt-offset and spi-threshold get/set attributes

Jakub Kicinski
2026-04-08T01:04:34Z

On Tue, 07 Apr 2026 17:37:41 -0400 Willem de Bruijn wrote:
> > + if (info->attrs[PSP_A_DEV_CRYPT_OFFSET])
> > + new_config.crypt_offset =
> > + nla_get_u8(info->attrs[PSP_A_DEV_CRYPT_OFFSET]);
>
> PSP defines a 6-bit field in 4 octet units. Does this need bounds checking?

More fundamentally, were we to support this -- is it a device property
or an assoc property?