From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f54.google.com (mail-yx1-f54.google.com [74.125.224.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD824388E7C for ; Wed, 20 May 2026 21:30:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779312625; cv=none; b=kr8CpIN2fjPPTf7D/yGcP4U526tQg2jvffwb0gy/fkxPtpbZzUxtBw+4egaKTOWlWWzkXEhqULddWhsTx27wn6uy0/HW0wjP74ub7jusmyTlwTl68hZZ6fJ2SEBc4FocVXBOa0pSSJgLNGwI2Nus759JGG0HiWj+Y4pVFQuHAgQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779312625; c=relaxed/simple; bh=CNa2gn4pFs3ZChw13qtMs/nrIOyVd4U11OySKw0hQjc=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=R53VJOXWEcGM6l04D7HdyNFqJBFdeCFpOABM4RwxPI0acrsMcB2gEHnj2yzJcorMvWy3aFUH++RWGK5okptvkOpfTdKKcPVGj4oP/0vIUxlxklkwCC1fvcwCO+v2NUi6Nr2xi57P2Oyp8CZdhz48fyyM21UimookiwAOJeS3EbA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Qov4Ksyo; arc=none smtp.client-ip=74.125.224.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qov4Ksyo" Received: by mail-yx1-f54.google.com with SMTP id 956f58d0204a3-65db820588aso4579503d50.2 for ; Wed, 20 May 2026 14:30:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779312622; x=1779917422; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=C+KjHLBU525JouIaDV1NgtcuH83HscW0YCgR8XNPGw0=; b=Qov4KsyodNaYoKKYGw8QXb0+Qu4SMVW8i44WdAko6Pn9HnrUsPa6L7IqX3v+/wC7+s o4SvVPDi3hO/Ka5e9rgBvgaF/rOVe5ZD5fDc2hhPu+R9gk82O4v19sddEP43dDG/5SJl 0xXQO/w3Pt+qJdM3cGdz7gw2fZc5cwHDc3EzFXpr7Szk+iSe6FFDkYWbFYxNMpnOiG6C hUfsQu2nBVJiOYio+6Q/pBEF989u6fI3mTeFsPAvqEZFu80dMIQK2jUN3BjepdAOsfKQ CCbVpag47HIJWD1qjmXFu4KTEGlnWxQSMRD01mBEDL/JsOR6ihhyv6H7oLa+O/1Uggdk IFoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779312622; x=1779917422; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=C+KjHLBU525JouIaDV1NgtcuH83HscW0YCgR8XNPGw0=; b=Y+MbeT03juJVZFXgPiFCFDdQItkQuFQ08OZkTDChXuZEMz8NRBp7G9h8obE4IH4DQ5 gcWd3sGaABaiVaOFZ28RvBlgniv/R4SqHfEWnhBGhnUgEORF2hbQDcfFMgxQZiFtJ4QY TubTN2zOvHnMVX7sUO1Urv62VsPNGXEqJ5nkLg6CLIjCNZTnKmW59/IPWvxwpAZXwkMH UhAfbqFIONh3WVWkkZQmCC3IkWcZsAVBeIG2gJVoL8dOFWjZusBxnCotnDj63vRJq/K9 CiZU0QFlfUOkNNjnOfmd66Z76J2SUoq6yFqlNRc0KLZB7cgDX/NpYqFiXlmjCslbgJSp xd6g== X-Forwarded-Encrypted: i=1; AFNElJ9g1k0xWVqSREzp3Qdon0jbpJY8/eURIcrk74i5mnrK9BGGamyTcOVrxnUqI84FptyXOU/ijgtIZXwg50E=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+a4VaNv1t+npgIMBU39/Gr741l7WI9rwDYkDIZ44+ooA4n8hL 8mzFOKaC3ydeiSO5QWs0MwJjGao566aF8P0o4Q3MwAsPSSiMK5BOyTRW X-Gm-Gg: Acq92OGwqAW/9ThCKLJOKMHfT+mqydzoa0a7A5YaOMsFGDeSgKTRUcOMTv4oa6SW11i Xtu4YUPRGTZfOGvNlqyd0ft0IZhwrmfHrQb92SY0xjc9w5kgn8jN/av+380vIN2UXeHhKG6eJtn Ub0vxNY3drP5JBZ6G0ied+nJhjwFo7LNN04NwGJzD8LOizml1BNyos0E3yPAJu4N5Bi7pF+Jf8+ nVEEpBaJ+fN4knNKqHCwBYOLD/9IPry0M5XGV3W4WsjONgxLnUO32wjYlKT40X6dXPTxuw2YGcK SXNy+wo7eftIs5GO5FDPzEO9zQqQVGGhQLt6uI9ZDFHO7PfU0h4Cfj/fG3ajR204KyPWhSJXdb3 qpU6JumHKcio4JKhil2tmAmUDck5eW0426+IxyU0VHpF28xu3hnU1+5S7AKSJlhZ0FirZEWSDdD iSE31fFdiLOKpI4YbnDpo/bssMgRz1NBA5tYWwpFYxWscFVjjhMtYO33bv9gMgfA4a3Bj7rKMow CFHtVzFyLIlSiY= X-Received: by 2002:a05:690e:bc6:b0:65e:3c31:533f with SMTP id 956f58d0204a3-65e3c3156b6mr18817387d50.51.1779312621683; Wed, 20 May 2026 14:30:21 -0700 (PDT) Received: from gmail.com (172.235.85.34.bc.googleusercontent.com. [34.85.235.172]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-65e0d89b130sm9894594d50.5.2026.05.20.14.30.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 14:30:20 -0700 (PDT) Date: Wed, 20 May 2026 17:30:20 -0400 From: Willem de Bruijn To: Willem de Bruijn , Weiming Shi , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: willemdebruijn.kernel@gmail.com, jasowang@redhat.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, cong.wang@bytedance.com, stable@vger.kernel.org, xmei5@asu.edu, Weiming Shi Message-ID: In-Reply-To: References: <20260520075736.3415676-3-bestswngs@gmail.com> Subject: Re: [PATCH] tap: fix stack info leak in tap_ioctl() SIOCGIFHWADDR Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Willem de Bruijn wrote: > Weiming Shi wrote: > > In the SIOCGIFHWADDR path, tap_ioctl() copies 16 bytes of an > > uninitialised on-stack struct sockaddr_storage to userspace via > > ifr_hwaddr, but netif_get_mac_address() only writes sa_family and > > dev->addr_len (6 for Ethernet) bytes, leaving sa_data[6..13] uninitialised. > > > > Those 8 trailing bytes leak kernel stack contents; SIOCGIFHWADDR on a > > macvtap chardev returns kernel .text and direct-map pointers, defeating > > KASLR. > > > > Initialise ss at declaration. > > > > Fixes: 3b23a32a6321 ("net: fix dev_ifsioc_locked() race condition") > > Reported-by: Xiang Mei > > Assisted-by: Claude:claude-opus-4-7 > > Signed-off-by: Weiming Shi > > Reviewed-by: Willem de Bruijn But it should target [PATCH net] and Cc: Stable@vger.kernel.org