From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f49.google.com (mail-yx1-f49.google.com [74.125.224.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 378743DE44E for ; Mon, 4 May 2026 17:14:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777914882; cv=none; b=nP1mW4RYPa8OVMXmWnx2dIEcnILC6CVzsmPR+OBm/03+P2gYu92olNrsyaRkxFY0YhSPNgmnvLVbty076XlDsWLJs0slLFLlPxEY/xFYR+6G6CdiXRV7wc1e8XHKGtGYXwL6knZPzdnOPJ9M3O5tImMnWPvxm4ldEUKr8lTl8L0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777914882; c=relaxed/simple; bh=gGhv5aBvag8GkJJw8oK+HvN5ptj86XyPHMattSfFigo=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=oog+00XJEhvjrFRL3/i/pMdaE3leEjBKGHjvw3wcf2RLmyY8Mr7/66kWrDBLUgj8lQMlXtQ8oO+OuaO3pAI96GpOenAbE3SMzeS9oXx6Nx83p6G6Fqf0Bry2EQ83TblOvUsS0YDJzgQipNMs0b9p0xLzGChkgVKbx60gd6CuRwY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DI14WPC2; arc=none smtp.client-ip=74.125.224.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DI14WPC2" Received: by mail-yx1-f49.google.com with SMTP id 956f58d0204a3-65c3ff05704so1202105d50.0 for ; Mon, 04 May 2026 10:14:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777914880; x=1778519680; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Ar9A5QrYRWGb5NIZabW3eNiZEMmSWnS35Z/zWd2ipnM=; b=DI14WPC2wnkewoRYZry85ZxY+ipIWLtEYITEHtf283ICw1sHSz3p/TiAqWEXJDd59F /BhFrabnLgIRwRsEmPg4w6tF60HHxKOpXn82PQ+ss1hJSzIvXqpzBdFm5OU6Uz1l2YQi QAXnA9fub1TVdUMGE+oEisUTVDJ0xN4l4FNWAZjTypSEXEv1NjUZltedFZZdmkq9slzm tZhIPCmy/sT2X942gaoVGepvErELv7KhVzXD7/B1SrE/85pIbGaN8NVlZB9ws2IEKQxj OJhLxh1b+1gT/KcdiSfNv++109GpFnseMArG4WZMiZSAL5129FaCx7QQLJ2oyCnUt03/ zvTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777914880; x=1778519680; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Ar9A5QrYRWGb5NIZabW3eNiZEMmSWnS35Z/zWd2ipnM=; b=iKAdyNebJ1m9U4AE/5+6npvoRV5hMWpnBMFfEFb/JV6g9+QSP+/C6RuEbsk8Akl7DB gBEwgbNfNXWHmy6wf0c1YkfgqlS8h9NTdSh+z/3psGNaFgMS1tYojfKLKFy1VWwBaKko 2fYy3JNPxmET/1/p4pA4U/uK6VPwhoCGDBh5XVi3m6gv9pto+irVzsWxfUOHOHaWz7GI 52FtLg8J02HemdmYDtZEm60kWB+xJD0xSNd5dRaE1+trsFgXCdHaN3UBYYGFAzcL6H43 voU1Kvb7g8WqSTQYtqvIVX15QL9GD0PH+RBqdWWmlA+in5U6fjeaXwMWBPtlDvROzHRM byAA== X-Forwarded-Encrypted: i=1; AFNElJ9q/efprRLiDQt2fqDtCPBLlTkEFkMlC0rQ9oF4Gn4g4HjcYam8LWe+WxBVdCSyXCu/q6BjViYqMgU4kn4=@vger.kernel.org X-Gm-Message-State: AOJu0YywCB2mDUEKuzr00uCteFbZarv0bz6K7+FkRVmX+s8x/zAlpg87 +YiNwywDlb//DnuazTr5ETc4xd/tAwu8Lb3XiS2g1cQSZGMbu6oWyj63 X-Gm-Gg: AeBDievT07Sx0QJ+X1mroWdbFngZyZCQ1SzhpAat1uFJaV+YO045gG+zHPO9g0kYVfA tdejZCU/RI1sJLL1LY9VPOX806cDzfmqJm2cRYU8E7Stnj/9qu9tDW+ciL2M0zByLbQeOeZG2iO g3am1PLoYIva6JCwKdYb/nxFS2v35ATdcxkjQ2ITLTKmaUzgnzOOhfeSMDhVWQbyv+ChnYiSPVn Vi28ZVDhkLeJB5fpV24dyRt9etwan5WLwJdzGSfcTP2gmx9ro/r3b6vTt01jQ+WJHUQl7xoFI6y YyUDcpTftMQPEguZoSsbeQtgr11pZ3AiXZ3koTe6AFRj+5k8cbGRlTNmYQIhBKVQ/HYQM+a3lts 1Sk8IfNX2EMjeeiXSiUUyVht1Q6LEdvd+f5ZzP+OIqzGNBKBpdVeQFv73zZNthAw2dr9vjaY69L m7N+ST00lJOJu9STNEofCq4atkVnifM0eKMEsoyJRuqnT2bWK3Blsh+pYd40eINJBTqCYqqUjfA gfoyvvV1ga4hu5GsQsT8Fiy+A== X-Received: by 2002:a05:690e:d41:b0:651:b13e:f9ef with SMTP id 956f58d0204a3-65c3d9a2bb6mr9826363d50.14.1777914880194; Mon, 04 May 2026 10:14:40 -0700 (PDT) Received: from gmail.com (172.235.85.34.bc.googleusercontent.com. [34.85.235.172]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-65c2e1bb5adsm5751702d50.7.2026.05.04.10.14.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 10:14:39 -0700 (PDT) Date: Mon, 04 May 2026 13:14:39 -0400 From: Willem de Bruijn To: Nick Hudson , bpf@vger.kernel.org, netdev@vger.kernel.org, Willem de Bruijn , Martin KaFai Lau Cc: Nick Hudson , Max Tottenham , Anna Glasgall , Daniel Borkmann , Alexei Starovoitov , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org Message-ID: In-Reply-To: <20260504101759.3319427-3-nhudson@akamai.com> References: <20260504101759.3319427-1-nhudson@akamai.com> <20260504101759.3319427-3-nhudson@akamai.com> Subject: Re: [PATCH v6 2/6] bpf: refactor masks for ADJ_ROOM flags and encap validation Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Nick Hudson wrote: > Refactor the helper masks for bpf_skb_adjust_room() flags to simplify > validation logic and introduce: > > - BPF_F_ADJ_ROOM_ENCAP_MASK > - BPF_F_ADJ_ROOM_DECAP_MASK > > Refactor existing validation checks in bpf_skb_net_shrink() > and bpf_skb_adjust_room() to use the new masks (no behavior change). > > This is in preparation for supporting the new decap flags. > > Co-developed-by: Max Tottenham > Signed-off-by: Max Tottenham > Co-developed-by: Anna Glasgall > Signed-off-by: Anna Glasgall > Signed-off-by: Nick Hudson Reviewed-by: Willem de Bruijn