From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FCD83803DF for ; Wed, 20 May 2026 21:22:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779312166; cv=none; b=D6J7edMBRrIGAQ+q39RT/S2vYlfZQBjIYQJOdIpOmu2pUnfZjhRdufm7BAHk63WGY3a2AOkrtpDSCfNgVrXLYg9GkdmCb0qCYR7z28gVgliE+IYzIGfsQvntOFdH/KqdIJ2YOU+Q+zX1AtYAn3uYdSdt21klouspbhmfk4LW72I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779312166; c=relaxed/simple; bh=KRHFm91BkHusMuCr++lqPfMPZLI+rXaXJEU0fHom4mQ=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=H+QsCIbi2HXbuvEsQFvwuSmSWFfneysVK+UqzBSyZ6EWP0VKGcFIy4ifCl2tJrxprxyqfjgP2Khgknthcx6IN99e3XBamS5qyAsQBKk9fGgY4ykRD2mf6CTgVBVX1V34haZVyCMRIwCuBIt+38BoqE6LaLxUG0l0d5WDZiOBMjE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QatC0i0M; arc=none smtp.client-ip=209.85.128.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QatC0i0M" Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-7c0dea734b8so50766237b3.3 for ; Wed, 20 May 2026 14:22:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779312162; x=1779916962; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=mEAw/HLd2Gukf+rbP9FYe175TBnZFF3s9mDfNnhekAY=; b=QatC0i0MBfL7me6hBc6CEWs1B7tcbGJbNzngGdQTwqEwcX4V0uIoWHyXDZjbioM3rd bkJQfASH+AUp47JfhpMVyZbR44Ue++0hyOwV1fFgmXSrSMC6rY8XQPraGyQ5TEoVOOD1 Nu5u8y18Eos4Ru5S/2S9FiacZgOI8eLBmWU8e8IAoWdWaidCNHHBuzJ7p4O0QMLjMiuu uXLI1CEDTu9ZnziYXRN2SiH5d3nwIEfCI1mrXlZcdaQqfMt+jKTT4RibKD3YGPwjtLdZ l4u9zgvKmrE1QquBfH0n3KpsgQAGee3GDRxa3q/EFdc+C7JIzHiWJfRmvH+dwU38Nul7 673w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779312162; x=1779916962; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=mEAw/HLd2Gukf+rbP9FYe175TBnZFF3s9mDfNnhekAY=; b=AWbltzWDWH2eC4FGpYfPk5HW838xybJxAx2I6Fet5qKuL9LxN3FsQql90qAlafukI8 dCV4gNaPUKMFZ+HiOayS2XcI7iWz+bD4uEjW+yDHU9gLBV/TJwAVSi6Ta5t1HCPk5tSW IaaJ6pyxck1VneuFkZbn64TVmBFraBcSHXjkk+1ehZPSqNuLvz22YGo7HHZEjAXEtSLH WFWg8z6zCK2TFsyKksfRs4bXkIskpWJFQ3MFJ5tvNtXPqdSxMaOrK/lvmVhdcMb+qYv5 n6SrnCZ0sK9IWb03aO0TjTEowHhc1aPxQmFwiOiJoXlrc1pGtUYECfcxHOywuybV96nl aHxw== X-Forwarded-Encrypted: i=1; AFNElJ9m8TS932lByzjekdx8nnQetNJH6xW/GzFMlfgghWNha0jgF4v1oWHjcbF6VPt6lCvyyFYO41C2ZCcxGzc=@vger.kernel.org X-Gm-Message-State: AOJu0YzXXwL/umHl+zNL/8u4RxQN0uAIyKydMprxBWOYUmKT2RAylLRt 01DH8K8siepMLTno9I4H9fxbbDVSxCfn1TcLdnyjgw4V82lSI9Wd5CqB X-Gm-Gg: Acq92OHc56kTx3ZG9xI7oDj+5EkrSs/o9d96PM/eMy8tHJGgYsQbw9cXNmkYxnH4kNm WyI2U/t5QMOWC5qtTHSfDL5a9PGX0YG/Vus+RSoRBnhsnQFnx8/+Grl4lCWc5QAp33AlHB05/2H 6RTnQsOfg7q3glzl6WrZ8SwyqPkqz0wTrMlPu9H/X93rrxaQszKitGrzxt/QaxH6VL1QPnNE2br WYmlfpCLt2FUd0518ll4hjlSEQMNOETkINQJc3AcUXqOAWMc/NshlsDFTuSiDAT4w3HrF14DR+M 4jPIO/ZpbX1s9j67o0XdDeCaDD1WNwS4DjGJNnQlByyFylQoNM1mQ/hI4GDIhW7O9klixjteiT8 2y3HRFyAumwb3b4lTlzRoh/K0vWYX7gf8P5wXHihnotFF+m93XBrElffGYOEToWnCQked3xlf2S /r5irQgfMtLjTOOQby8M+TmjBYZwy4ycjfTWrpwEFPBpVwwfb36TGfAebD8aDk0z2lgQIzNxtKM VLS X-Received: by 2002:a05:690c:b88:b0:7c7:5111:5f05 with SMTP id 00721157ae682-7d20d123e00mr2059477b3.48.1779312162633; Wed, 20 May 2026 14:22:42 -0700 (PDT) Received: from gmail.com (172.235.85.34.bc.googleusercontent.com. [34.85.235.172]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7cc996b7d54sm57824987b3.12.2026.05.20.14.22.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 14:22:41 -0700 (PDT) Date: Wed, 20 May 2026 17:22:41 -0400 From: Willem de Bruijn To: Weiming Shi , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: willemdebruijn.kernel@gmail.com, jasowang@redhat.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, cong.wang@bytedance.com, stable@vger.kernel.org, xmei5@asu.edu, Weiming Shi Message-ID: In-Reply-To: <20260520075736.3415676-3-bestswngs@gmail.com> References: <20260520075736.3415676-3-bestswngs@gmail.com> Subject: Re: [PATCH] tap: fix stack info leak in tap_ioctl() SIOCGIFHWADDR Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Weiming Shi wrote: > In the SIOCGIFHWADDR path, tap_ioctl() copies 16 bytes of an > uninitialised on-stack struct sockaddr_storage to userspace via > ifr_hwaddr, but netif_get_mac_address() only writes sa_family and > dev->addr_len (6 for Ethernet) bytes, leaving sa_data[6..13] uninitialised. > > Those 8 trailing bytes leak kernel stack contents; SIOCGIFHWADDR on a > macvtap chardev returns kernel .text and direct-map pointers, defeating > KASLR. > > Initialise ss at declaration. > > Fixes: 3b23a32a6321 ("net: fix dev_ifsioc_locked() race condition") > Reported-by: Xiang Mei > Assisted-by: Claude:claude-opus-4-7 > Signed-off-by: Weiming Shi Reviewed-by: Willem de Bruijn